fix onboarding promise by nkdengineer · Pull Request #47097 · Expensify/App

nkdengineer · 2024-08-08T17:06:27Z

Details

fix onboarding promise

Fixed Issues

$ #47054
$ #47157
PROPOSAL:

Tests

Clear cache and logout
Login as a new user
Verify that the onboarding modal appears
Open a new tab with the default URL of the app or edit the URL to the default URL
Verify that the onboarding modal also appears

Verify that no errors appear in the JS console

Offline tests

None

QA Steps

Clear cache and logout
Login as a new user
Verify that the onboarding modal appears
Open a new tab with the default URL of the app or edit the URL to the default URL
Verify that the onboarding modal also appears

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-08-08.at.23.56.40.mov

Android: mWeb Chrome

Screen.Recording.2024-08-08.at.23.54.11.mov

iOS: Native

Screen.Recording.2024-08-08.at.23.57.34.mov

iOS: mWeb Safari

Screen.Recording.2024-08-08.at.23.55.38.mov

MacOS: Chrome / Safari

Screen.Recording.2024-08-08.at.23.53.02.mov

MacOS: Desktop

Screen.Recording.2024-08-09.at.00.01.10.mp4

melvin-bot · 2024-08-08T17:13:57Z

@jayeshmangwani Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

DylanDylann · 2024-08-09T07:44:12Z

src/libs/actions/Welcome.ts


 let isLoadingReportData = true;
 let tryNewDotData: TryNewDot | undefined;
+let onboarding: OnboardingData | undefined;


Add my reviewing

srikarparsi · 2024-08-09T18:08:51Z

Hey, I'm thinking that this fix will take care of this issue as well, seems to be related. Could you take a look whenever you have a chance. When I use this branch I get this error but this might have something to do with me locally as it's working for both of you. (Ah I think I might have to disable strict mode)

srikarparsi · 2024-08-09T18:27:49Z

Ah yes, disabling strict mode fixed this:

OnboardingVideo.mov

Going to add this in the list of fixed issues.

ishpaul777 · 2024-08-09T19:45:30Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Record_2024-08-10-01-48-29.mp4

Android: mWeb Chrome

Record_2024-08-10-01-50-44.mp4

iOS: Native

Screen.Recording.2024-08-10.at.1.39.11.AM.mov

iOS: mWeb Safari

Screen.Recording.2024-08-10.at.1.37.21.AM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-08-10.at.1.31.05.AM.mov

MacOS: Desktop

Screen.Recording.2024-08-10.at.1.54.42.AM-1.mov

ishpaul777 · 2024-08-09T19:57:27Z

Oh so i have to disable Strict mode, to make it work

srikarparsi

Thanks for the review @ishpaul777! This looks good to me from before. @NikkiWines if you want to take a final pass at this or we can merge

NikkiWines

Works great 🎊

Screen.Recording.2024-08-09.at.22.43.59.mov

fix onboarding promise (cherry picked from commit ad59bf3) (CP triggered by marcaaron)

OSBotify · 2024-08-09T21:05:24Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-08-09T21:28:54Z

🚀 Cherry-picked to staging by https://github.com/OSBotify in version: 9.0.18-10 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

hungvu193 · 2025-02-03T03:10:15Z

src/libs/actions/Welcome.ts

+    if (onboarding === undefined) {
+        return;
+    }


Because we early return here, anonymous account with no on boarding data will stuck at home screen because this promise won't be executed.
More details:
#55239 (comment)

nkdengineer added 3 commits August 8, 2024 23:58

fix onboarding promise

af8b9ba

revert code

da9d1cb

update type of onboarding promise

c0bbb9c

nkdengineer marked this pull request as ready for review August 8, 2024 17:13

nkdengineer requested a review from a team as a code owner August 8, 2024 17:13

melvin-bot bot requested a review from jayeshmangwani August 8, 2024 17:13

melvin-bot bot removed the request for review from a team August 8, 2024 17:13

nkdengineer mentioned this pull request Aug 8, 2024

[HOLD for payment 2024-08-19] [$250] Sign in – Onboarding modal is missing in new tab #47054

Closed

6 tasks

DylanDylann reviewed Aug 9, 2024

View reviewed changes

nkdengineer added 2 commits August 9, 2024 15:13

Merge branch 'main' into fix/47054-regression

bf02ae6

refactor

de82f55

srikarparsi mentioned this pull request Aug 9, 2024

[HOLD for payment 2024-08-19] Onboarding - Onboarding modal disappears when navigate to home page #47157

Closed

6 tasks

marcaaron assigned nkdengineer Aug 9, 2024

This comment was marked as resolved.

Sign in to view

ishpaul777 approved these changes Aug 9, 2024

View reviewed changes

melvin-bot bot requested a review from NikkiWines August 9, 2024 20:28

srikarparsi approved these changes Aug 9, 2024

View reviewed changes

NikkiWines approved these changes Aug 9, 2024

View reviewed changes

srikarparsi merged commit ad59bf3 into Expensify:main Aug 9, 2024

OSBotify pushed a commit that referenced this pull request Aug 9, 2024

Merge pull request #47097 from nkdengineer/fix/47054-regression

316f885

fix onboarding promise (cherry picked from commit ad59bf3) (CP triggered by marcaaron)

github-actions bot added the CP Staging marks PRs that have been CP'd to staging label Aug 9, 2024

srikarparsi mentioned this pull request Aug 9, 2024

Revert "fix: Concierge chat opens when change priority mode to Most recent" #47183

Closed

github-actions bot mentioned this pull request Aug 9, 2024

Deploy Checklist: New Expensify 2024-08-07 #47006

Closed

88 tasks

srikarparsi mentioned this pull request Aug 9, 2024

Revert "Fix: Onboarding modal shows up after refreshing page with 2FA setup when xero connected and 2FA disabled" #47182

Closed

hungvu193 reviewed Feb 3, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix onboarding promise#47097

fix onboarding promise#47097
srikarparsi merged 5 commits intoExpensify:mainfrom
nkdengineer:fix/47054-regression

nkdengineer commented Aug 8, 2024 •

edited by srikarparsi

Loading

Uh oh!

melvin-bot bot commented Aug 8, 2024

Uh oh!

DylanDylann Aug 9, 2024

Uh oh!

nkdengineer Aug 9, 2024

Uh oh!

srikarparsi commented Aug 9, 2024 •

edited

Loading

Uh oh!

srikarparsi commented Aug 9, 2024 •

edited

Loading

Uh oh!

ishpaul777 commented Aug 9, 2024 •

edited

Loading

Uh oh!

This comment was marked as resolved.

ishpaul777 commented Aug 9, 2024

Uh oh!

srikarparsi left a comment

Uh oh!

NikkiWines left a comment

Uh oh!

OSBotify commented Aug 9, 2024

Uh oh!

OSBotify commented Aug 9, 2024

Uh oh!

hungvu193 Feb 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

nkdengineer commented Aug 8, 2024 • edited by srikarparsi Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Aug 8, 2024

Uh oh!

DylanDylann Aug 9, 2024

Choose a reason for hiding this comment

Uh oh!

nkdengineer Aug 9, 2024

Choose a reason for hiding this comment

Uh oh!

srikarparsi commented Aug 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

srikarparsi commented Aug 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ishpaul777 commented Aug 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

This comment was marked as resolved.

ishpaul777 commented Aug 9, 2024

Uh oh!

srikarparsi left a comment

Choose a reason for hiding this comment

Uh oh!

NikkiWines left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Aug 9, 2024

Uh oh!

OSBotify commented Aug 9, 2024

Uh oh!

hungvu193 Feb 3, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

nkdengineer commented Aug 8, 2024 •

edited by srikarparsi

Loading

srikarparsi commented Aug 9, 2024 •

edited

Loading

srikarparsi commented Aug 9, 2024 •

edited

Loading

ishpaul777 commented Aug 9, 2024 •

edited

Loading