fix: Not here page when create new request

[nkdengineer]

Details

Fixed Issues

$ #49801
PROPOSAL: #49801 (comment)

Tests

Case 1

1. Go to workspace chat> + > Submit expense> Complete the flow
2. Pay the request
3. Go to transaction thread> Click on header> Cancel payment
4. Go to main page> + > Submit expense> Complete the flow
5. Navigate to newly created request
6. Verify that: Transaction thread should open

Precondition: Use control workspace and approvals is disabled

Case 2

1. Submit expense
2. Pay the expense
3. Cancel the expense
4. In the same workspace chat try to create a new expense
5. Verify that: Submit expense and Create expense button is not displayed

• Verify that no errors appear in the JS console

Offline tests

same as above

QA Steps

same as above

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

android-resize.mp4

Android: mWeb Chrome

android-mweb-resize.mp4

iOS: Native

ios-resize.mp4

iOS: mWeb Safari

ios-mweb-resize.mp4

MacOS: Chrome / Safari

web-resize.mp4

MacOS: Desktop

desktop-resize.mp4

[melvin-bot]

@rushatgabhane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[rushatgabhane]

Go to workspace chat> + > Submit expense> Complete the flow
Pay the request
Go to transaction thread> Click on header> Cancel payment
Go to main page> + > Submit expense> Complete the flow

@nkdengineer hey i followed these steps for a workspace. But I'm getting API error - 403 New request cannot be added to this expense report

[nkdengineer]

It works well for me.

Screen.Recording.2024-10-26.at.01.02.49.mov

[rushatgabhane]

i tried from another account but i still get the same error 😕
@nkdengineer maybe can you re-login and try again?

[rushatgabhane]

Try requesting money from parent thread maybe

[nkdengineer]

@rushatgabhane i still can't reproduce this bug, please add more details and video screenshot

[nkdengineer]

@rushatgabhane friendly bump

[nkdengineer]

@rushatgabhane Friendly bump.

[rushatgabhane]

bug: can't add expenses to the cancelled request

1. submit expense
2. pay the expense
3. cancel the expense
4. request another expense in the same workspace chat

Actual: there is an error when creating the new expense - New request cannot be added to this expense

Screen.Recording.2024-11-11.at.09.23.03.mov

[nkdengineer]

Can reproduce now.

[nkdengineer]

@tgolen Another problem here, in OpenReport API, iouReportID of the policy expense report is returned as null.

[tgolen]

OK, thanks! Can you please report that using the template here: https://github.com/Expensify/App/issues/new?assignees=&labels=Hot+Pick%2C+Daily%2C+Internal%2C+AutoAssignerNewDotQuality&projects=&template=Internal.md and then someone can get that looked into

[nkdengineer]

@tgolen This problem is blocking us from testing this PR and aslo related to this issue can you handle this?

[tgolen]

I can, yes. It would still be nice if you could use that template and then I can just assign it to myself. I'm not 100% clear on what the problem is or how to reproduce it. This one is a bit different than the one I previously fixed (parentReportID)

[nkdengineer]

@tgolen Created the new issue here.

[nkdengineer]

@tgolen Is the backend fix done?

[tgolen]

I think so. I see this backend issue was closed and the PR fixing it has been deployed. Could you see if you're still able to reproduce the problem?

As a reminder, the backend bug that was done that should fix this was a bug in this step here:

[nkdengineer]

I added the test but it seems to be failing test 1, will check today

[nkdengineer]

@rushatgabhane @tgolen i added the tests, please check again

[tgolen]

The util looks good! Here are some suggestions to improve the comments.

[nkdengineer]

@tgolen Updated.

[tgolen]

Oops, sorry I didn't catch these earlier. The comments look better now!

[nkdengineer]

@tgolen All done.

Do you think we should create a new issue to update all the same instances in the test to use getOnyxData helper? If yes, I'd like to work on this.

[tgolen]

In general, I think the cleanup would be nice, but it's very low in value and priority. Just doing a quick search I see about 187 instances of const connection = Onyx.connect({ in the test files.

I think trying to use the new utility when you can and pointing it out when reviewing PRs is a good place to start for now.

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[github-actions]

🚀 Deployed to staging by https://github.com/tgolen in version: 9.0.74-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

[github-actions]

🚀 Deployed to production by https://github.com/luacmartins in version: 9.0.74-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅