[NoQA][GR Phase 3] Step 5 - navigation, default data, logic and API call to save it by burczu · Pull Request #53053 · Expensify/App

burczu · 2024-11-25T09:22:37Z

Explanation of Change

Implementation of Step 5 of the NonUSD Global Reimbursement project's flow.

P.S.
Some texts and translations are still under discussion, so I didn't mark suitable checkboxes in Author Checklist as done yet - I'll do it when ready and the code is updated.

Fixed Issues

$: #50907
PROPOSAL: n/a

Tests

Log in to the App
Create a Workspace selecting one these currencies: CAD, EUR, AUD, GBP,
Go to Workflows and start Connect bank account flow
Go through the flow to Step 5
Test the flow for the case where you are a Signer or Director (the case where you are not will be covered separately)

Verify that no errors appear in the JS console

Offline tests

Same as above.

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Same as above

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-04-10.at.10.24.10.mov

Android: mWeb Chrome

Screen.Recording.2025-04-10.at.10.28.39.mov

iOS: Native

Screen.Recording.2025-04-11.at.08.05.12.mov

iOS: mWeb Safari

Screen.Recording.2025-04-11.at.11.19.35.mov

MacOS: Chrome / Safari

Screen.Recording.2025-04-10.at.10.04.55.mov

MacOS: Desktop

Screen.Recording.2025-04-10.at.10.07.53.mov

…api-call

burczu · 2025-04-11T09:22:20Z

@hungvu193 I think you can get back to reviewing this - the flow is updated, and I've updated screen recordings. Still waiting for translations confirmation - I think I'll have it soon.

madmax330 · 2025-04-11T09:27:35Z

Did you mean @hungvu193?

burczu · 2025-04-11T09:30:44Z

Did you mean @hungvu193?

Ahhh... you are right :)

hungvu193 · 2025-04-11T10:58:25Z

Nice. It's working 🎉 . I'll complete the review this week

hungvu193 · 2025-04-14T09:37:16Z

All good. Then I think the final thing here is the translations right? @burczu

burczu · 2025-04-14T09:47:14Z

@hungvu193 Yes, I'm still waiting for it - will let you know once I apply them in the code.

burczu · 2025-04-15T05:41:59Z

@hungvu193 Spanish translations updated.

hungvu193

LGTM

melvin-bot · 2025-04-15T06:06:17Z

🎯 @hungvu193, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #60244.

hungvu193 · 2025-04-15T06:06:39Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android.mov

Android: mWeb Chrome

mAndroid.mov

iOS: Native

IOS.mov

iOS: mWeb Safari

Safari.mov

MacOS: Chrome / Safari

Chrome.mov

MacOS: Desktop

Desk.mov

madmax330 · 2025-04-15T08:02:47Z


    const handleSendReminder = () => {
-        // TODO remove that
+        // TODO this should send a message to the email provided in the previous step


What was this for?

It is a handler for the button on the last screen below, on the right:

I presumed I will call the AskForCorpaySignerInformation endpoint, is it correct? And this is part of another issue, will be done in separate PR after we merge this one.

Ah ok yeah, sounds good

madmax330 · 2025-04-15T08:04:30Z


-    const handleEmailSubmit = () => {
+    const handleEmailSubmit = useCallback(() => {
+        // TODO: the message to the email provided in the previous step should be sent


Not sure what this is? Isn't think done in the AskForCorpaySignerInformation command?

yes - this is placeholder for handling this endpoint, we do it in other PR, as this was intented to be done as separate issue

sounds good 👍🏽

OSBotify · 2025-04-15T09:18:03Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-04-16T21:38:44Z

🚀 Deployed to staging by https://github.com/madmax330 in version: 9.1.29-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-04-18T20:30:39Z

🚀 Deployed to production by https://github.com/marcaaron in version: 9.1.29-10 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

burczu force-pushed the feat/50907-GR-Phase3-Step5-nav-api-call branch 3 times, most recently from 8333755 to 41dc57e Compare December 2, 2024 08:14

burczu added 6 commits December 6, 2024 10:18

step 3 implementation applied

81e594c

getting corpay onboarding fields call added to signer info page

5f213c7

unnecessary api call prevented

aadaf97

save corpay onboarding director information endpoint handling

8aaecc4

prettier fixes

a1f0be5

save director information api call temp

8c0dff5

burczu force-pushed the feat/50907-GR-Phase3-Step5-nav-api-call branch from be3577c to 8c0dff5 Compare December 6, 2024 09:18

burczu added 20 commits December 10, 2024 08:10

Merge branch 'main' into feat/50907-GR-Phase3-Step5-nav-api-call

fa24353

Merge branch 'feat/step-3-logic' into feat/50907-GR-Phase3-Step5-nav-…

5801d10

…api-call

duplicated import removed

cb68762

switched to destination country

4d18148

Merge branch 'feat/step-4-logic' into feat/50907-GR-Phase3-Step5-nav-…

68de54a

…api-call

Merge branch 'main' into feat/50907-GR-Phase3-Step5-nav-api-call

50a07f6

Merge branch 'feat/step-4-logic' into feat/50907-GR-Phase3-Step5-nav-…

5172a67

…api-call

Merge branch 'main' into feat/50907-GR-Phase3-Step5-nav-api-call

df189c0

Merge branch 'feat/step-4-logic' into feat/50907-GR-Phase3-Step5-nav-…

e9d25fe

…api-call

sending documents added

dcdbe8f

onyx data handling added to the save director information action

62e531a

Merge branch 'main' into feat/50907-GR-Phase3-Step5-nav-api-call

eb9681b

body content usage fixed

531be87

Merge branch 'main' into feat/50907-GR-Phase3-Step5-nav-api-call

e65b3c3

use callback wrapper utilized

93444f5

Merge branch 'feat/step-4-logic' into feat/50907-GR-Phase3-Step5-nav-…

993afee

…api-call

removing files fixed

517f4af

error utils usage fixed

3f4a312

uploading documents improved

7e8bb10

temporary files

9498a17

CAD case fixed

9d31c9f

hungvu193 suggested changes Apr 12, 2025

View reviewed changes

Comment thread src/components/UploadFile.tsx Outdated

burczu added 2 commits April 14, 2025 09:42

Merge branch 'main' into feat/50907-GR-Phase3-Step5-nav-api-call

cc49908

unnecessary skip of file uploads removed

8c5309b

burczu force-pushed the feat/50907-GR-Phase3-Step5-nav-api-call branch from 407a13e to 8c5309b Compare April 14, 2025 08:36

allow multiple issue fixed

6082db3

spanish translations updated

2f8bc03

hungvu193 approved these changes Apr 15, 2025

View reviewed changes

melvin-bot Bot mentioned this pull request Apr 15, 2025

[HOLD for payment 2025-04-25] [$250]Payment issue for E/App PR#53053 #60244

Closed

hungvu193 approved these changes Apr 15, 2025

View reviewed changes

madmax330 reviewed Apr 15, 2025

View reviewed changes

burczu added 3 commits April 15, 2025 10:22

unnecessary directorIDs property removed from payload

14a3028

hook deps fixed

52f961a

unnecessary code removed

60d7a02

madmax330 approved these changes Apr 15, 2025

View reviewed changes

madmax330 merged commit e4a523e into Expensify:main Apr 15, 2025
16 checks passed

github-actions Bot mentioned this pull request Apr 16, 2025

Deploy Checklist: New Expensify 2025-04-16 #60369

Closed

87 tasks

ChavdaSachin mentioned this pull request Apr 19, 2025

Bank account-Back button on "Hang tight" page closes RHP instead of returning to previous step #60516

Closed

8 tasks

Conversation

burczu commented Nov 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

burczu commented Apr 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

madmax330 commented Apr 11, 2025

Uh oh!

burczu commented Apr 11, 2025

Uh oh!

hungvu193 commented Apr 11, 2025

Uh oh!

Uh oh!

hungvu193 commented Apr 14, 2025

Uh oh!

burczu commented Apr 14, 2025

Uh oh!

burczu commented Apr 15, 2025

Uh oh!

hungvu193 left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented Apr 15, 2025

Uh oh!

hungvu193 commented Apr 15, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

Uh oh!

madmax330 Apr 15, 2025

Choose a reason for hiding this comment

Uh oh!

burczu Apr 15, 2025

Choose a reason for hiding this comment

Uh oh!

madmax330 Apr 15, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

madmax330 Apr 15, 2025

Choose a reason for hiding this comment

Uh oh!

burczu Apr 15, 2025

Choose a reason for hiding this comment

Uh oh!

madmax330 Apr 15, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Apr 15, 2025

Uh oh!

github-actions Bot commented Apr 16, 2025

Uh oh!

github-actions Bot commented Apr 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

burczu commented Nov 25, 2024 •

edited

Loading

burczu commented Apr 11, 2025 •

edited

Loading