Can't add new report actions in Debug mode #53969

pac-guerreiro · 2024-12-11T22:33:29Z

Explanation of Change

Fixed Issues

$#53683
PROPOSAL:

Implement Debug.mergeDebugData using Onyx.merge to update a report action or add a new report action
Use InteractionManager.runAfterInteractions to prevent Not Found page from showing after deleting onyx data

Tests

Report Actions

Enable Debug mode in Troubleshoot
Open any chat from LHN, go to chat details then click on Debug
On Debug mode, go to actions tab and create a new report action
Confirm that the list of report actions contains the old actions and the new one you created on top.
Delete the report action you just created and confirm that the Not Found page is not shown while navigation back.
Delete the report in the details tab and confirm that the Not Found page is not shown while navigating back.

Transactions

Enable Debug mode in Troubleshoot
Open an expense chat from LHN, go to chat details then click on Debug
Click on View Transaction on details tab
Go to violations and open on any violation from the list. If no violation is present, create one.
Delete the violation and confirm that the Not Found page is not shown during navigation.
Delete the transaction and confirm that the Not Found page is not shown during navigation

Offline tests

Same as tests.

QA Steps

Same as tests.

PR Author Checklist

Screenshots/Videos

Android: Native

Android.-.Native.mp4

Android: mWeb Chrome

Android.-.Chrome.mp4

iOS: Native

iOS.-.Native.mp4

iOS: mWeb Safari

iOS.-.Safari.mp4

MacOS: Chrome / Safari

MacOS.-.Chrome.mp4

MacOS: Desktop

MacOS.-.Desktop.mp4

pac-guerreiro · 2024-12-11T22:35:28Z

Todo:

Add testing steps
Add screen recordings

…actions-in-debug-mode

pac-guerreiro · 2024-12-12T23:00:24Z

Today:

Add testing steps
Add screen recordings

Todo:

Fix Not Found screen shown when navigating back after deleting a report

melvin-bot · 2024-12-12T23:00:55Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

pac-guerreiro · 2024-12-12T23:02:02Z

@DylanDylann The PR is now ready for review! 😄

There's a minor issue where the Not Found page is shown if the user goes back after deleting a report. I'll look for a fix for this issue tomorrow!

…actions-in-debug-mode

pac-guerreiro · 2024-12-17T00:11:51Z

@DylanDylann

Last friday (12/13/24)

I didn't have much time to focus on the remaining issue but I did some investigation and got some ideas to try

Today

I tried some ideas and managed to find one that fixed the Not Found page showing after deleting a report, going to concierge and pressing back button on the header

pac-guerreiro · 2024-12-18T00:07:58Z

Waiting on @DylanDylann review 😄

DylanDylann · 2024-12-18T04:58:34Z

Reviewing today

DylanDylann · 2024-12-18T08:34:22Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-12-18.at.16.40.59.mov

Android: mWeb Chrome

Screen.Recording.2024-12-18.at.15.52.51.mov

iOS: Native

Screen.Recording.2024-12-18.at.15.50.55.mov

iOS: mWeb Safari

Screen.Recording.2024-12-18.at.15.47.21.mov

MacOS: Chrome / Safari

Screen.Recording.2024-12-18.at.15.40.50.mov

MacOS: Desktop

Screen.Recording.2024-12-18.at.15.48.14.mov

OSBotify · 2024-12-18T16:58:09Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-12-23T20:58:01Z

🚀 Deployed to staging by https://github.com/puneetlath in version: 9.0.78-0 🚀

platform	result
🤖 android 🤖	cancelled 🔪
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	cancelled 🔪
🍎🔄 iOS HybridApp 🍎🔄	cancelled 🔪

github-actions · 2024-12-23T21:41:57Z

🚀 Deployed to staging by https://github.com/puneetlath in version: 9.0.78-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2024-12-23T21:49:27Z

🚀 Deployed to staging by https://github.com/puneetlath in version: 9.0.78-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2024-12-24T00:05:12Z

🚀 Deployed to staging by https://github.com/puneetlath in version: 9.0.78-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2024-12-24T00:52:51Z

🚀 Deployed to staging by https://github.com/puneetlath in version: 9.0.78-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2024-12-24T19:42:58Z

🚀 Deployed to staging by https://github.com/puneetlath in version: 9.0.78-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2024-12-24T19:59:54Z

🚀 Deployed to staging by https://github.com/puneetlath in version: 9.0.78-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2024-12-26T20:27:09Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.0.78-6 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

fix(debug mode): unable to add new report actions

297a113

pac-guerreiro mentioned this pull request Dec 11, 2024

[HOLD for payment 2025-01-02] Can't add new report actions in Debug mode #53683

Closed

pac-guerreiro added 2 commits December 11, 2024 22:51

docs: add missing prop descriptions

f0d383c

Merge branch 'main' into pac-guerreiro/fix/53683-cant-add-new-report-…

d4e8917

…actions-in-debug-mode

pac-guerreiro marked this pull request as ready for review December 12, 2024 23:00

pac-guerreiro requested a review from a team as a code owner December 12, 2024 23:00

melvin-bot bot requested review from DylanDylann and removed request for a team December 12, 2024 23:00

pac-guerreiro changed the title ~~[WIP] Can't add new report actions in Debug mode~~ Can't add new report actions in Debug mode Dec 12, 2024

pac-guerreiro added 3 commits December 16, 2024 10:31

Merge branch 'main' into pac-guerreiro/fix/53683-cant-add-new-report-…

69f0b8a

…actions-in-debug-mode

fix: going back from a full page report screen not returning home

22e0bc2

Merge branch 'main' into pac-guerreiro/fix/53683-cant-add-new-report-…

b4f814f

…actions-in-debug-mode

DylanDylann approved these changes Dec 18, 2024

View reviewed changes

melvin-bot bot requested a review from puneetlath December 18, 2024 09:05

puneetlath approved these changes Dec 18, 2024

View reviewed changes

puneetlath merged commit 804df09 into Expensify:main Dec 18, 2024
15 checks passed

github-actions bot mentioned this pull request Dec 23, 2024

Deploy Checklist: New Expensify 2024-12-23 #54476

Closed

daledah mentioned this pull request Dec 24, 2024

[READY for payment 2025-01-07] [HOLD for payment 2025-01-02] Chat- Back button from expense detail leads to LHN rather than expense report conversation #54496

Closed

8 tasks

Can't add new report actions in Debug mode #53969

Can't add new report actions in Debug mode #53969

Uh oh!

Conversation

pac-guerreiro commented Dec 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Report Actions

Transactions

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

pac-guerreiro commented Dec 11, 2024

Uh oh!

pac-guerreiro commented Dec 12, 2024

Uh oh!

melvin-bot bot commented Dec 12, 2024

Uh oh!

pac-guerreiro commented Dec 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pac-guerreiro commented Dec 17, 2024

Uh oh!

pac-guerreiro commented Dec 18, 2024

Uh oh!

DylanDylann commented Dec 18, 2024

Uh oh!

DylanDylann commented Dec 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

OSBotify commented Dec 18, 2024

Uh oh!

github-actions bot commented Dec 23, 2024

Uh oh!

github-actions bot commented Dec 23, 2024

Uh oh!

github-actions bot commented Dec 23, 2024

Uh oh!

github-actions bot commented Dec 24, 2024

Uh oh!

github-actions bot commented Dec 24, 2024

Uh oh!

github-actions bot commented Dec 24, 2024

Uh oh!

github-actions bot commented Dec 24, 2024

Uh oh!

github-actions bot commented Dec 26, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

pac-guerreiro commented Dec 11, 2024 •

edited

Loading

pac-guerreiro commented Dec 12, 2024 •

edited

Loading

DylanDylann commented Dec 18, 2024 •

edited

Loading