-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[HybridApp] Necessary copilot changes #54296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
chiragsalian
merged 10 commits into
Expensify:main
from
software-mansion-labs:war-in/enable-hybrid-app-copilot
Jan 16, 2025
+72
−20
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
71d5082
modify HybridAppModule method
war-in 04e3401
Merge branch 'refs/heads/main' into war-in/enable-hybrid-app-copilot
war-in 139bc5c
update ND copilot data when switching from OD
war-in f1722dc
Merge branch 'main' into war-in/enable-hybrid-app-copilot
war-in c036e93
finish copilot integration - entire flow is working now
war-in cc9ac72
Merge branch 'main' into war-in/enable-hybrid-app-copilot
war-in f993b3b
fix ios flow (use response data for session and credentials)
war-in cf0e4b3
fix lint
war-in 672ec4d
Merge branch 'main' into war-in/enable-hybrid-app-copilot
war-in 60ccc17
Update src/libs/actions/Session/index.ts
war-in File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@war-in
I think we gotta check here if
HybridAppModuleexists before calling the function like we do everywhere else on the App.This is crashing on web on dev and throws an error on production when a user switches to their main account from being a copilot.
Screen.Recording.2025-02-04.at.9.27.52.AM.mov
cc: @dangrous @chiragsalian
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah okay thanks! is there an issue for that crash?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh hey it also crashes on connecting as delegate. Your fix works there too. @c3024 can you create a PR if you haven't already?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dangrous
No, there is no issue created for this. I found this when I was checking something else. I am creating a PR. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR here