Fix - remove all onboarding videos by FitseTLT · Pull Request #55902 · Expensify/App

FitseTLT · 2025-01-28T21:44:14Z

Details

Fixed Issues

$ #55642
PROPOSAL: #55642 (comment)

Tests

Sign up with a new account
Select Manage teams in the Onboarding modal that appears
Select any options and finish the boarding flow
Verify that there are no onboarding videos (please note that there might be a gif and what we are removing in this PR is videos) in concierge
Verify also that there are no onboarding videos in all other onboarding flows like Track and budget expenses, Get paid by my employer, chat and split expenses with friends

Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

Same as above

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

2025-01-29.00-40-38.mp4

Android: mWeb Chrome

2025-01-29.00-43-13.mp4

iOS: Native

i.onb.mp4

iOS: mWeb Safari

iw.onb.mp4

MacOS: Chrome / Safari

w.onb.mp4

MacOS: Desktop

d.onb.mp4

melvin-bot · 2025-01-28T21:44:19Z

@c3024 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

FitseTLT · 2025-01-28T21:49:43Z

@danielrvidal I want to you to confirm that we are ok with the message displayed above the tasks like the ones that end with Here is how, I mean, previously there were videos below the message now that they are removed I wanted to make sure they are ok without the video or we need a copy change
These are the copies I want a confirmation

    message: 'Getting paid back is as easy as sending a message. Let’s go over the basics.',
            message: 'Splitting bills with friends is as easy as sending a message. Here’s how.',

c3024 · 2025-01-29T03:14:49Z

I want to you to confirm that we are ok with the message displayed above the tasks like the ones that end with Here is how, I mean, previously there were videos below the message now that they are removed I wanted to make sure they are ok without the video or we need a copy change
These are the copies I want a confirmation
message: 'Getting paid back is as easy as sending a message. Let’s go over the basics.',
message: 'Splitting bills with friends is as easy as sending a message. Here’s how.',

@FitseTLT, please add the screenshots with these messages (after removing videos) so that it’s easier to see if the message looks okay with the tasks that follow.

FitseTLT · 2025-01-29T12:45:35Z

I want to you to confirm that we are ok with the message displayed above the tasks like the ones that end with Here is how, I mean, previously there were videos below the message now that they are removed I wanted to make sure they are ok without the video or we need a copy change
These are the copies I want a confirmation
message: 'Getting paid back is as easy as sending a message. Let’s go over the basics.',
message: 'Splitting bills with friends is as easy as sending a message. Here’s how.',

@FitseTLT, please add the screenshots with these messages (after removing videos) so that it’s easier to see if the message looks okay with the tasks that follow.

@c3024 I intentionally included screenshots of the different platforms from different onboarding flows. So @danielrvidal You can use the videos in OP if needed.

c3024 · 2025-01-30T10:40:14Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

removeVideosAndroid.mov

Android: mWeb Chrome

Screenrecorder-2025-01-30-16-03-56-148.mp4

iOS: Native

removeVideosiOS.mov

iOS: mWeb Safari

videosiOSmWeb-compressed.mp4

MacOS: Chrome / Safari

removeVideosChrome.mov

MacOS: Desktop

removeVideosDesktop.mov

c3024 · 2025-01-30T10:49:43Z

With reference to this comment, the text does not seem out of place with respect to the tasks to me.

A GIF is sent from the backend for the “Manage team” intent (when signing up with an email without a “+” in it). If we want to remove this GIF too, a backend fix is needed.

Screen.Recording.2025-01-30.at.4.13.58.PM.mov