promise chaining to ensure proper form initialization by sosek108 · Pull Request #58375 · Expensify/App

sosek108 · 2025-03-13T14:06:57Z

PR

#temp

Explanation of Change

In some cases ReimbursementAccountPage is not properly initialized and this is because of concurrent Onyx.merge action and useOnyx subscription. It results in undefined default object passed to forms. This change ensures, that Merge is finished before useOnyx is called.

Fixed Issues

$ #58369 (comment)
PROPOSAL: #58369 (comment)

Tests

Create two Workspaces with USD currency
Go to Workspace 1 > Workflows > Connect bank Account
Click on Connect Manually
Fill routing number and account number and click Next
Close form
Go to Workspace 2 and repeat the process
Return to Workspace 1
Go to Workflows > Connect bank account
Click Continue setup
Return back two times
Click Continue setup again
Validate that fields are properly completed
Validate that user can continue the process

Offline tests

N/A

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Create two Workspaces with USD currency
Go to Workspace 1 > Workflows > Connect bank Account
Click on Connect Manually
Fill routing number and account number and click Next
Close form
Go to Workspace 2 and repeat the process
Return to Workspace 1
Go to Workflows > Connect bank account
Click Continue setup
Return back two times
Click Continue setup again
Validate that fields are properly completed
Validate that user can continue the process

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2025-03-13T14:07:03Z

@dominictb Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dominictb · 2025-03-13T18:31:35Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

Screen.Recording.2025-03-21.at.02.38.48.mov

iOS: Native

Screen.Recording.2025-03-21.at.02.29.50-compressed.mov

iOS: mWeb Safari

Screen.Recording.2025-03-21.at.02.32.00.mov

MacOS: Chrome / Safari

Screen.Recording.2025-03-21.at.02.08.14.mov

MacOS: Desktop

Screen.Recording.2025-03-21.at.02.27.58.mov

dominictb · 2025-03-13T18:41:53Z

@sosek108 Please update your Tests and QA steps so that the testing steps indicate the expected outcome with the changes in this PR rather than the current behavior.

dominictb · 2025-03-13T19:56:27Z

@sosek108 BUG: The form data in workspace 1 is reset after filling account & routing numbers in workspace 2:

Screen.Recording.2025-03-14.at.02.52.40.mov

sosek108 · 2025-03-14T08:19:59Z

@sosek108 Please update your Tests and QA steps so that the testing steps indicate the expected outcome with the changes in this PR rather than the current behavior.

@dominictb Done, thanks for catching that up

dominictb · 2025-03-17T16:45:05Z

@sosek108 Don't forget to take a glance at #58375 (comment) 😄

sosek108 · 2025-03-18T07:59:33Z

@dominictb it appears that you cannot use the same account number in two workspaces (makes sense to me).

You wrote the same number in both cases. When you changed back to first workspace the response from API resets setup state with this:

{
            "key": "reimbursementAccount",
            "onyxMethod": "merge",
            "value": {
                "achData": {
                    "state": ""
                }
            }
        },

Everything works if you pass different account number

dominictb

melvin-bot · 2025-03-20T19:34:15Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #58369 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

dominictb · 2025-03-20T19:41:51Z

@rafecolton will review this PR.

rafecolton

Primary change LGTM. Looks like there's an unrelated change to the Mobile-Expensify submodule. Will you please merge main and update your local submodule to ensure that change is not present? Ok to force push to your branch for this fix if you prefer

sosek108 · 2025-03-21T08:05:38Z

Primary change LGTM. Looks like there's an unrelated change to the Mobile-Expensify submodule. Will you please merge main and update your local submodule to ensure that change is not present? Ok to force push to your branch for this fix if you prefer

Done, thanks for catching that up!

rafecolton

LGTM, thanks!

OSBotify · 2025-03-21T19:23:39Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-03-21T22:44:31Z

🚀 Deployed to staging by https://github.com/rafecolton in version: 9.1.17-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2025-03-24T21:15:00Z

🚀 Deployed to production by https://github.com/cristipaval in version: 9.1.17-1 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

promise chaining to ensure proper form initialization

62ce9c4

sosek108 requested a review from a team as a code owner March 13, 2025 14:06

melvin-bot Bot requested a review from dominictb March 13, 2025 14:07

melvin-bot Bot removed the request for review from a team March 13, 2025 14:07

sosek108 mentioned this pull request Mar 13, 2025

[Needs Checklist] Bank account input fields are disabled and empty #58369

Closed

8 tasks

dominictb approved these changes Mar 20, 2025

View reviewed changes

rafecolton requested changes Mar 20, 2025

View reviewed changes

Fix: Reset Mobile-Expensify submodule to 7afb93

9c6ac86

rafecolton approved these changes Mar 21, 2025

View reviewed changes

rafecolton merged commit 509b9af into Expensify:main Mar 21, 2025

github-actions Bot mentioned this pull request Mar 21, 2025

Deploy Checklist: New Expensify 2025-03-21 #58928

Closed

65 tasks

Conversation

sosek108 commented Mar 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Mar 13, 2025

Uh oh!

dominictb commented Mar 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

dominictb commented Mar 13, 2025

Uh oh!

dominictb commented Mar 13, 2025

Uh oh!

sosek108 commented Mar 14, 2025

Uh oh!

dominictb commented Mar 17, 2025

Uh oh!

sosek108 commented Mar 18, 2025

Uh oh!

dominictb left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented Mar 20, 2025

Uh oh!

dominictb commented Mar 20, 2025

Uh oh!

rafecolton left a comment

Choose a reason for hiding this comment

Uh oh!

sosek108 commented Mar 21, 2025

Uh oh!

rafecolton left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Mar 21, 2025

Uh oh!

github-actions Bot commented Mar 21, 2025

Uh oh!

github-actions Bot commented Mar 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

sosek108 commented Mar 13, 2025 •

edited

Loading

dominictb commented Mar 13, 2025 •

edited

Loading