fix: empty background when invited to private chat by daledah · Pull Request #58543 · Expensify/App

daledah · 2025-03-17T03:59:05Z

Explanation of Change

Fixed Issues

$ #57769
PROPOSAL: #57769 (comment)

Tests

Precondition: User A and B logged in on two different devices

Log in with User A account.
Switch to User B account.
Open any private room conversation in which User A is not a member, or create one if necessary.
Tap on room header and select "Share"
Copy the room URL and send it to a conversation with User A.
Switch to User A account.
Open conversation with User B and navigate to room link.
Check that you are navigated to a "It´s not here" page.
Without closing that page, switch to User B account again.
Invite User A to the room.
Switch to User A account again.
Verify that: Screen background and title is shown

Verify that no errors appear in the JS console

Offline tests

QA Steps

Log in with User A account.
Switch to User B account.
Open any private room conversation in which User A is not a member, or create one if necessary.
Tap on room header and select "Share"
Copy the room URL and send it to a conversation with User A.
Switch to User A account.
Open conversation with User B and navigate to room link.
Check that you are navigated to a "It´s not here" page.
Without closing that page, switch to User B account again.
Invite User A to the room.
Switch to User A account again.
Verify that: Screen background and title is shown

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-03-17.at.21.28.10.mp4

Android: mWeb Chrome

Screen.Recording.2025-03-17.at.21.29.58.mp4

iOS: Native

Screen.Recording.2025-03-17.at.21.32.37.mp4

iOS: mWeb Safari

Screen.Recording.2025-03-17.at.21.37.04.mp4

MacOS: Chrome / Safari

Screen.Recording.2025-03-17.at.10.51.13.mov

MacOS: Desktop

Screen.Recording.2025-03-17.at.21.42.18.mp4

melvin-bot · 2025-03-17T17:20:30Z

@hungvu193 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

hungvu193 · 2025-03-19T06:45:16Z

I'll review later today

hungvu193 · 2025-03-19T16:04:01Z

+        if (prevReportActions.length !== 0 || reportActions.length === 0) {
+            return;
+        }


If we use OR condition here, fetchReport will be constantly called when reportActions changes, meanwhile we only want to fix the case when user was first invited to the room. This code looks different compared to the proposal that you proposed. Is there any reason for that?

In the proposal I used direct condition, where if prevReportActions.length === 0 && reportActions.length > 0 then we call fetchReport. In the PR, I use inverse condition to early return as it is our codebase convention.

If we use OR condition here, fetchReport will be constantly called when reportActions changes

I don't think this change creates this behavior, because we return everytime prevReportActions have lengh. Can you check again please?

Ty. I don't know why I read it as prevReportActions.length == 0 at first 😳

hungvu193 · 2025-03-20T06:38:54Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2025-03-20.at.14.14.11.mov

Android: mWeb Chrome

Screen.Recording.2025-03-20.at.13.33.25.mp4

iOS: Native

Screen.Recording.2025-03-20.at.13.38.01.mov

iOS: mWeb Safari

Screen.Recording.2025-03-20.at.13.25.32.mov

MacOS: Chrome / Safari

Screen.Recording.2025-03-20.at.13.25.32.mov

MacOS: Desktop

Screen.Recording.2025-03-20.at.14.30.10.mov

Screen.Recording.2025-03-20.at.13.25.32.mov

OSBotify · 2025-03-20T15:20:37Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-03-21T22:44:46Z

🚀 Deployed to staging by https://github.com/techievivek in version: 9.1.17-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2025-03-24T21:15:15Z

🚀 Deployed to production by https://github.com/cristipaval in version: 9.1.17-1 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

daledah added 3 commits March 17, 2025 10:53

fix: empty background when invited to private chat

df42753

Merge branch 'main' into fix/57769

c86b079

fix: test

7629792

daledah marked this pull request as ready for review March 17, 2025 17:20

daledah requested a review from a team as a code owner March 17, 2025 17:20

melvin-bot Bot requested review from hungvu193 and removed request for a team March 17, 2025 17:20

daledah mentioned this pull request Mar 17, 2025

[Due for payment 2025-04-23] [Due for payment 2025-03-31] [$250] Room - Empty background shown when user is invited to private room after navigating to link. #57769

Closed

8 tasks

hungvu193 suggested changes Mar 19, 2025

View reviewed changes

hungvu193 approved these changes Mar 20, 2025

View reviewed changes

melvin-bot Bot requested a review from techievivek March 20, 2025 06:45

techievivek assigned daledah Mar 20, 2025

techievivek approved these changes Mar 20, 2025

View reviewed changes

techievivek merged commit e4d3540 into Expensify:main Mar 20, 2025

github-actions Bot mentioned this pull request Mar 21, 2025

Deploy Checklist: New Expensify 2025-03-21 #58928

Closed

65 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: empty background when invited to private chat#58543

fix: empty background when invited to private chat#58543
techievivek merged 3 commits into
Expensify:mainfrom
daledah:fix/57769

daledah commented Mar 17, 2025 •

edited

Loading

Uh oh!

melvin-bot Bot commented Mar 17, 2025

Uh oh!

hungvu193 commented Mar 19, 2025

Uh oh!

hungvu193 Mar 19, 2025

Uh oh!

daledah Mar 20, 2025 •

edited

Loading

Uh oh!

hungvu193 Mar 20, 2025

Uh oh!

hungvu193 commented Mar 20, 2025 •

edited

Loading

Uh oh!

OSBotify commented Mar 20, 2025

Uh oh!

github-actions Bot commented Mar 21, 2025

Uh oh!

github-actions Bot commented Mar 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

daledah commented Mar 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Mar 17, 2025

Uh oh!

hungvu193 commented Mar 19, 2025

Uh oh!

hungvu193 Mar 19, 2025

Choose a reason for hiding this comment

Uh oh!

daledah Mar 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hungvu193 Mar 20, 2025

Choose a reason for hiding this comment

Uh oh!

hungvu193 commented Mar 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

OSBotify commented Mar 20, 2025

Uh oh!

github-actions Bot commented Mar 21, 2025

Uh oh!

github-actions Bot commented Mar 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

daledah commented Mar 17, 2025 •

edited

Loading

daledah Mar 20, 2025 •

edited

Loading

hungvu193 commented Mar 20, 2025 •

edited

Loading