Fix - Update the scanned expense creation flow to allow user to see full receipt

[FitseTLT]

Details

Fixed Issues

$ #58589
PROPOSAL: #58589 (comment)

Tests

1. Open any chat
2. Create an expense
3. Scan a receipt
4. On the confirmation page, click on the receipt to open the image to see it fully
5. Verify that Replace and Download options in three dot menu works well
6. Confirm the expense and verify it is created

• Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

Same as above

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

2025-03-19.17-36-52.mp4

Android: mWeb Chrome

2025-03-19.17-35-12.mp4

iOS: Native

2025-03-19.17-50-55.mp4

iOS: mWeb Safari

re.iw.mp4

MacOS: Chrome / Safari

re.w.mp4

MacOS: Desktop

re.d.mp4

[melvin-bot]

@brunovjk Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[brunovjk]

I would like to confirm if we need the gray border in the confirmation preview? Just like we have in the expense preview, more details in this comment. I think it makes it clearer to the user that they can click there, but that's just my opinion, I would like to know what the @Expensify/design team thinks about it. Thanks.

[dannymcclain]

The rest of the design team can gut check me here, but I think we should include the border. I see no reason not to make it the same as on the expense details screen.

[shawnborton]

Totally agree with Danny here, let's make em consistent!

[brunovjk]

Great, thanks everyone. @FitseTLT when it's ready let me know so I can review it? Thanks.

[dubielzyk-expensify]

Aligned with the designers 👍

[FitseTLT]

Here is how it looks now:

[brunovjk]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
• I verified tests pass on all platforms & I tested again on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

58725_android_native.mov

Android: mWeb Chrome

58725_android_web.mov

iOS: Native

58725_ios_native.mov

iOS: mWeb Safari

58725_ios_web.mov

MacOS: Chrome / Safari

58725_web_chrome.mov

MacOS: Desktop

58725_web_desktop.mov

[brunovjk]

@FitseTLT can you merge main here? I cant build native, but on my lastest main I can.
Other than that, everything is looking good. Thank you.

[FitseTLT]

@brunovjk Done

[brunovjk]

LGTM. We just need confirmation from the @Expensify/design team and we're good to go.

[dannymcclain]

Looking really good! Can we just confirm that this border is 1px and using our standard borders color? It looks a little thick to me, but I can't tell if it's just my eyes playing tricks on me in the video recording.

[FitseTLT]

Nope perfect vision it is 2px but I applied the same borderWidth and border color as the money request view receipt preview are you sure you want this to be 1px?

[dannymcclain]

Oh wow you're right—that is how it shows up elsewhere. Let's leave it then.

@Expensify/design do we need to create a separate issue to make that 1px everywhere? Or do we want it to be 2px? (I see it as 1px in Figma).

[shawnborton]

The border style looks better. Though it looks like there is a slight gap above the receipt image - any ideas?

Can you pull main too? I think we made the receipt images here slightly less wide.

[FitseTLT]

Here is how it looks after pulling main

2025-03-24.23-34-05.mp4

2025-03-24.23-38-36.mp4

[dannymcclain]

The border style looks better. Though it looks like there is a slight gap above the receipt image - any ideas?

Border looks right to me too—thanks! It does seem like there's a weird little gap above the image though?

[FitseTLT]

Could it be due to the receipt image. Do you see difference between main and the branch below?

Main:

This branch:

2025-03-24.23-50-18.mp4

[dannymcclain]

Weird. They look the same to me. Can you just use a different receipt image? Like this one?

[FitseTLT]

Yes looks like it

2025-03-25.00-08-14.mp4

[dubielzyk-expensify]

Can we see a video of tapping the image again just for triple checking everything being a-ok on the visual side?

[shawnborton]

Agree, the updated border styles look good but would love one final "full flow" video to make sure it's all good. Let's try to get that soon so we can get this over the finish line!

[brunovjk]

Great! I will retest in all platforms and make those videos :D Give me a moment

[brunovjk]

What do you think @Expensify/design ? Thank you :D

Screenshots/Videos

Android: Native

58725_android_native.mov

Android: mWeb Chrome

58725_android_web.mov

iOS: Native

58725_ios_native.mov

iOS: mWeb Safari

58725_ios_web.mov

MacOS: Chrome / Safari

58725_web_chrome.mov

MacOS: Desktop

58725_web_desktop.mov

[FitseTLT]

@brunovjk I think I have seen a dupe issue with the above can u ask in slack group?

[brunovjk]

@brunovjk I think I have seen a dupe issue with the above can u ask in slack group?

Thank you @FitseTLT

[neil-marcellini]

Latest changes look fine. I'll merge after design approves.

[shawnborton]

Videos are looking good to me 👍

[neil-marcellini]

Do I need to wait for the rest of the team to approve or should I merge it now @shawnborton?

[shawnborton]

@dannymcclain should still be online, so let's have him double check and then if he's all good with it, I think we're good to merge. Based on what I saw, I feel pretty confident that both Danny and Jon will give the thumbs up.

[dannymcclain]

Videos are looking good to me too 👍

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[github-actions]

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 9.1.19-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

[github-actions]

🚀 Deployed to production by https://github.com/cristipaval in version: 9.1.19-5 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌