Skip to content

[CP Staging] fix: prevent long press on chat item #59151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cristipaval merged 1 commit into from
Mar 26, 2025
+7 −2
Merged

[CP Staging] fix: prevent long press on chat item #59151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/components/Search/SearchList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,9 @@ type SearchListProps = Pick<FlatListPropsWithLayout<SearchListItem>, 'onScroll'

/** Whether to prevent default focusing of options and focus the textinput when selecting an option */
shouldPreventDefaultFocusOnSelectRow?: boolean;

/** Whether to prevent long press of options */
shouldPreventLongPressRow?: boolean;
};

function SearchList(
Expand All @@ -80,6 +83,7 @@ function SearchList(
containerStyle,
ListFooterComponent,
shouldPreventDefaultFocusOnSelectRow,
shouldPreventLongPressRow,
}: SearchListProps,
ref: ForwardedRef<SearchListHandle>,
) {
Expand Down Expand Up @@ -143,13 +147,13 @@ function SearchList(
const handleLongPressRow = useCallback(
(item: SearchListItem) => {
// eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
if (!isSmallScreenWidth || item?.isDisabled || item?.isDisabledCheckbox || !isFocused) {
if (shouldPreventLongPressRow || !isSmallScreenWidth || item?.isDisabled || item?.isDisabledCheckbox || !isFocused) {
return;
}
setLongPressedItem(item);
setIsModalVisible(true);
},
[isFocused, isSmallScreenWidth],
[isFocused, isSmallScreenWidth, shouldPreventLongPressRow],
);

const turnOnSelectionMode = useCallback(() => {
Expand Down
1 change: 1 addition & 0 deletions src/components/Search/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -454,6 +454,7 @@ function Search({queryJSON, currentSearchResults, lastNonEmptySearchResults, onS
onCheckboxPress={toggleTransaction}
onAllCheckboxPress={toggleAllTransactions}
canSelectMultiple={type !== CONST.SEARCH.DATA_TYPES.CHAT && canSelectMultiple}
shouldPreventLongPressRow={isChat}
SearchTableHeader={
!isLargeScreenWidth ? undefined : (
<SearchTableHeader
Expand Down