Native Share follow ups#59239
Merged
grgia merged 9 commits intoExpensify:mainfrom Apr 16, 2025
Merged
Conversation
|
@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Contributor
Author
|
The pr is ready to review cc @grgia @shubham1206agra who worked on the original Native Share PR |
Contributor
|
🚧 @grgia has triggered a test app build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
Contributor
|
Hmm looks like there may be some build fails here? |
Contributor
Author
|
Looking at the build errors that's probably because of importing |
Contributor
Author
|
@grgia Should be fixed |
Contributor
|
🚧 @grgia has triggered a test app build. You can view the workflow run here. |
Contributor
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
Contributor
Author
|
I am not sure what is causing the Hybrid Android build fail. I hope that merging main will help. |
Contributor
|
🚧 @grgia has triggered a test app build. You can view the workflow run here. |
Contributor
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪 |
grgia
reviewed
Apr 1, 2025
| addComment(report.reportID, message); | ||
| const routeToNavigate = ROUTES.REPORT_WITH_ID.getRoute(reportOrAccountID); | ||
| Navigation.navigate(routeToNavigate); | ||
| Navigation.navigate(routeToNavigate, {forceReplace: true}); |
Contributor
Author
There was a problem hiding this comment.
Sorry, I forgot to comment on this line. It fixes the problem with navigation I've fixed before but I forgot about the sharing plain text case. This way when we share (text or file) and click back button we wont end up in the share flow again.
grgia
previously approved these changes
Apr 1, 2025
Contributor
grgia
left a comment
grgia
left a comment
There was a problem hiding this comment.
Code LGTM, minor Q for documentation sake
Contributor
|
@shubham1206agra ready for you 🙏 |
Contributor
|
@shubham1206agra bump |
Contributor
|
@shubham1206agra are you able to take this one? |
Contributor
|
@grgia Can you trigger adhoc build here? |
Contributor
Contributor
Screen.Recording.2025-04-08.at.8.33.11.PM.movBUG: Able to move message input on dragging. |
Contributor
|
BUG: I sometimes see the error modal twice. It's hard to repro, but I got this issue twice. |
grgia
approved these changes
Apr 11, 2025
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2025-04-11.at.11.08.40.PM.moviOS: NativeScreen.Recording.2025-04-11.at.10.07.59.PM.mov |
shubham1206agra
approved these changes
Apr 11, 2025
grgia
previously approved these changes
Apr 14, 2025
Contributor
|
@289Adam289 could you fix conflicts? Also do we need to merge mobile PR first? |
Contributor
Author
|
The mobile pr is connected to a different pr. This one should work on it's own. Let me just fix the conflicts and we are good to merge here. |
Contributor
Author
|
@grgia once the checks pass we are good to go |
grgia
approved these changes
Apr 14, 2025
Contributor
Author
|
@grgia Would you mind starting the perf-test workflow again? The fail was unrelated and should be fixed now |
Contributor
|
@289Adam289 retriggered again |
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
github-actions
Bot
added
the
DeployBlockerCash
Contributor
Performance Comparison Report 📊 (1/4)Significant Changes To Duration
Show details
|
Contributor
Performance Comparison Report 📊 (2/4)Meaningless Changes To Duration (1/3)Show entries
Show details
|
Contributor
Performance Comparison Report 📊 (3/4)Meaningless Changes To Duration (2/3)Show entries
Show details
|
Contributor
Performance Comparison Report 📊 (4/4)Meaningless Changes To Duration (3/3)Show entries
Show details
|
Contributor
|
@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker. |
87 tasks
Contributor
|
🚀 Deployed to staging by https://github.com/grgia in version: 9.1.29-0 🚀
|
Contributor
Author
|
@kavimuru There might be some confusion regarding #59017 probably caused by my testing steps. The behavior on phones you have provided is expected. The user should not be able to swipe down on an image before taping and opening a new screen with image only. The reproduction can be seen in an original video from #59017. cc @grgia @shubham1206agra for confirmation |
Contributor
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.1.29-10 🚀
|
This was referenced Apr 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr fixes linked issues:
ImageViewtoImagethis fixes problem with blank image previewIt also fixes navigation issue when sharing text on android
Explanation of Change
Fixed Issues
$ #59017
$ #59020
$ #59022
PROPOSAL:
Tests
Attachement preview bug:
Size error:
/homerouteError appears twice:
Offline tests
QA Steps
Same as tests
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2025-03-27.at.18.01.07.mov
Android: mWeb Chrome
iOS: Native
Screen.Recording.2025-03-27.at.17.57.37.mov
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop