Fix/59945 update api calls for expensify cards by koko57 · Pull Request #59996 · Expensify/App

koko57 · 2025-04-10T07:56:58Z

Explanation of Change

This PR changes the params sent to create a new virtual and physical Expensify Card to make it compatible with domain cards.

I also fixed 2 problems that I've discovered during working on this:

The domain card was not deactivated properly - afetr the request was sent it was still in the card list. It disappeared after logging out and back in.
When opening a workspace right after logging in and going to Expensify Card Page loader wasn't shown, but the empty card list screen was displayed for a split of a second before the card list appeared. Also instead of Empty State screen the emty card list page was displayed for the workspaces with no paymentAccountID.

Fixed Issues

$ #59945
PROPOSAL: -

Tests

PREREQUISITES: domain cards enabled on a policy

Go to Workspaces -> Your Workspace (with domain cards) -> Expensify Card
Try to issue both a virtual and a physical card (the same way it's done for Expensify Cards)
Verify that the cards are issued with no errors and they are displayed in the card list
Additional steps:
Try to deactivate a domain card - it should work like for the workspace cards.
Verify that the Expensify Card page is displayed properly for these cases:

Expensify Card enabled, no account added as a payment account - Empty Card State
Expensify Card enabled, account added - empty card list
Expensify Card enabled, cards issued - card list with cards
for each case check if the loader is displayed if the data is loading (you can log out before checking each case to verify) and no other. screen is glitching before the proper one appears
Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2025-04-16T13:45:51Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

koko57 · 2025-04-16T14:07:20Z

@DylanDylann I also fixed 2 issues - more in the PR description.

DylanDylann · 2025-04-17T06:23:42Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2025-04-17.at.14.34.44.mov

Android: mWeb Chrome

Screen.Recording.2025-04-17.at.14.32.14.mov

iOS: Native

Screen.Recording.2025-04-17.at.14.35.17.mov

iOS: mWeb Safari

Screen.Recording.2025-04-17.at.14.30.58.mov

MacOS: Chrome / Safari

Screen.Recording.2025-04-17.at.14.28.39.mov

MacOS: Desktop

Screen.Recording.2025-04-17.at.14.36.47.mov

DylanDylann · 2025-04-17T07:39:42Z

Discovering a new bug while reviewing this PR (not related to this change)

In mobile, after entering the correct magic code, the App navigates to the issue new card page before coming back to the card list page

I get this bug on MWeb Chrome and IOS native

Screen.Recording.2025-04-17.at.14.32.14.mov

Screen.Recording.2025-04-17.at.14.35.17.mov

koko57 · 2025-04-17T12:16:28Z

@DylanDylann can you please check if the issue is already reported? If not I think it's better to create a new one, as it's out of scope of this PR

OSBotify · 2025-04-17T15:32:24Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

…i-calls-for-expensify-cards Fix/59945 update api calls for expensify cards (cherry picked from commit e730f5b) (CP triggered by puneetlath)

github-actions · 2025-04-17T16:20:47Z

🚀 Cherry-picked to staging by https://github.com/puneetlath in version: 9.1.29-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

github-actions · 2025-04-18T20:31:48Z

🚀 Deployed to production by https://github.com/marcaaron in version: 9.1.29-10 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

dukenv0307 · 2025-05-14T17:35:53Z

    API.write(
        WRITE_COMMANDS.CREATE_ADMIN_ISSUED_VIRTUAL_CARD,
-        {...parameters, domainAccountID},
+        {...parameters},


Coming from: #61051. We should pass policyID here

koko57 added 9 commits April 10, 2025 09:47

fix: send domainAccountID in requests

83c6558

Merge branch 'main' into fix/59945-update-api-calls-for-expensify-cards

1ba6972

Merge branch 'main' into fix/59945-update-api-calls-for-expensify-cards

0ecf5ad

fix: update params

184f984

fix: fix deactivating cards

93969f4

fix: remove unused import

2103af4

fix: fix rendering a proper screen for expensify card

242ecb0

fix: lint

2a8c4b7

fix: prettier

bb99b6b

koko57 marked this pull request as ready for review April 16, 2025 13:45

koko57 requested a review from a team as a code owner April 16, 2025 13:45

melvin-bot Bot requested review from DylanDylann and removed request for a team April 16, 2025 13:45

koko57 mentioned this pull request Apr 16, 2025

[Due for payment 2025-04-28] [Due for payment 2025-04-25] Update CreateAdminIssuedVirtualCard and CreateExpensifyCard for domain cards #59945

Closed

DylanDylann approved these changes Apr 17, 2025

View reviewed changes

melvin-bot Bot requested a review from puneetlath April 17, 2025 07:37

koko57 mentioned this pull request Apr 17, 2025

Expensify card - The issue card flow error displays after issuing a card #60407

Closed

8 tasks

puneetlath approved these changes Apr 17, 2025

View reviewed changes

puneetlath merged commit e730f5b into Expensify:main Apr 17, 2025
18 checks passed

github-actions Bot added the CP Staging marks PRs that have been CP'd to staging label Apr 17, 2025

github-actions Bot mentioned this pull request Apr 17, 2025

Deploy Checklist: New Expensify 2025-04-16 #60369

Closed

87 tasks

dukenv0307 reviewed May 14, 2025

View reviewed changes

koko57 deleted the fix/59945-update-api-calls-for-expensify-cards branch March 30, 2026 09:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix/59945 update api calls for expensify cards#59996

Fix/59945 update api calls for expensify cards#59996
puneetlath merged 9 commits intoExpensify:mainfrom
callstack-internal:fix/59945-update-api-calls-for-expensify-cards

koko57 commented Apr 10, 2025 •

edited

Loading

Uh oh!

melvin-bot Bot commented Apr 16, 2025

Uh oh!

koko57 commented Apr 16, 2025

Uh oh!

DylanDylann commented Apr 17, 2025 •

edited

Loading

Uh oh!

DylanDylann commented Apr 17, 2025 •

edited

Loading

Uh oh!

koko57 commented Apr 17, 2025

Uh oh!

Uh oh!

OSBotify commented Apr 17, 2025

Uh oh!

github-actions Bot commented Apr 17, 2025

Uh oh!

github-actions Bot commented Apr 18, 2025

Uh oh!

dukenv0307 May 14, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

koko57 commented Apr 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Apr 16, 2025

Uh oh!

koko57 commented Apr 16, 2025

Uh oh!

DylanDylann commented Apr 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

DylanDylann commented Apr 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

koko57 commented Apr 17, 2025

Uh oh!

Uh oh!

OSBotify commented Apr 17, 2025

Uh oh!

github-actions Bot commented Apr 17, 2025

Uh oh!

github-actions Bot commented Apr 18, 2025

Uh oh!

dukenv0307 May 14, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

koko57 commented Apr 10, 2025 •

edited

Loading

DylanDylann commented Apr 17, 2025 •

edited

Loading

DylanDylann commented Apr 17, 2025 •

edited

Loading