Conversation
|
A preview of your ExpensifyHelp changes have been deployed to https://90f32e9d.helpdot.pages.dev ⚡️ |
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? cc @lschurr |
|
@thesahindia @lschurr One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
|
Preview of the new page: https://90f32e9d.helpdot.pages.dev/articles/expensify-classic/expensify-billing/Receipt-Breakdown |
amyevans
left a comment
There was a problem hiding this comment.
1 small comment, otherwise looks good to me! @lschurr would you like to review?
Alternatively, feel free to merge @laurenreidexpensify if you want to skip my NAB and don't need review from @lschurr
|
@amyevans I can't merge, all over to you :) |
|
Ah whoops, I didn't realize that! I'll do the honors 😄 |
|
@amyevans looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
|
Not an emergency |
|
🚀 Deployed to staging by https://github.com/amyevans in version: 9.1.29-0 🚀
|
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.1.29-10 🚀
|
Explanation of Change
As part of the Pricing project, we are updating the help site resources to include references to the new $5 pricing point. This change:
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/479597
Tests
N/A
Offline tests
N/A
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop