[CP Staging] Revert the debounced search in Search by rezkiy37 · Pull Request #60417 · Expensify/App

rezkiy37 · 2025-04-17T09:10:26Z

Explanation of Change

The PR reverts the debounced behavior.

Fixed Issues

$ #59262
$ #60395

PROPOSAL: N/A

Tests

Navigate to the staging.new.expensify.com and sign in
Start a 1:1 conversation, say some messages like "Hi", "Hello"
While on the conversation page, click on the Search icon at the top right corner
Select an option to search in the current conversation
Check the search box
A search syntax is added to the search box after clicking on the option to search in the current conversation

Verify that no errors appear in the JS console

Apply all characters

Turn off internet
Tap on search icon at the top screen
Type some characters
Verify that user can type characters for searching

Select by the keyboard

Tap the search icon at the top of the screen.
Enter "type:" into the search field.
Press the down arrow key on your keyboard.
Confirm that the highlighted suggestion is inserted into the input field.

Offline tests

Same as tests.

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

Same as tests.

PR Author Checklist

Screenshots/Videos

Android: Native

Android.mp4

Android: mWeb Chrome

Android.Chrome.mp4

iOS: Native

IOS.mp4

iOS: mWeb Safari

IOS.Safari.mp4

MacOS: Chrome / Safari

Chrome.mp4

Chrome.2.mp4

MacOS: Desktop

Desktop.mp4

Desktop.2.mp4

… to remove local state management and implement debounced state handling. Update input handling to directly use props for better performance and consistency.

…o allow missing data in useOnyx calls, enhancing robustness in data handling.

melvin-bot · 2025-04-17T11:36:02Z

@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

parasharrajat · 2025-04-17T17:16:57Z

Screenshots

🔲 iOS / native

🔲 iOS / Safari

🔲 MacOS / Desktop

🔲 MacOS / Chrome

17.04.2025_22.12.44_REC.mp4

🔲 Android / Chrome

🔲 Android / native

rezkiy37 · 2025-04-17T17:41:39Z

It will fixed here #60417

I can confirm #60395 is fixed here.

Video

Chrome.mp4

marcaaron · 2025-04-17T20:26:04Z

What's our ETA for testing this? I assume we are wanting to CP it? The linked issue is blocking the deploy. Thanks!

marcaaron · 2025-04-18T00:12:31Z

Confirmed it fixes the Deploy Blocker. Looking at other issue.

github-actions · 2025-04-18T00:15:06Z

🚧 @marcaaron has triggered a test app build. You can view the workflow run here.

github-actions · 2025-04-18T00:44:43Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
Android 🤖🔄	iOS 🍎🔄
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/60417-hybrid/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/60417-hybrid/index.html

Desktop 💻	Web 🕸️
N/A	N/A
N/A	N/A

👀 View the workflow run that generated this build 👀

marcaaron · 2025-04-18T01:13:28Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

marcaaron

LGTM

marcaaron · 2025-04-18T01:23:18Z

but there are conflicts 🫠

parasharrajat · 2025-04-18T02:17:41Z

Completing videos.... I was getting the build issues earlier.

289Adam289 · 2025-04-18T07:42:48Z


    // The actual input text that the user sees
-    const [textInputValue, setTextInputValue] = useState(isDefaultQuery ? '' : queryText);
+    const [textInputValue, , setTextInputValue] = useDebouncedState(isDefaultQuery ? '' : queryText, 500);


Hi, I originally reported the issue. Correct me if I am wrong, but I think that if we don't use the debounced value we are just using standard useState hook but with extra steps. The textInputValue in useDebouncedState implementation is the current state value that is updated every time the 'setTextInputValue' is called.

@289Adam289 , However, the app manages the search requests. It automatically cancels the previous requests, and only the last one is executed. I am fine with it.

@rezkiy37 When I reverted this line, I get the same result:

Screen.Recording.2025-04-18.at.11.48.34.mov

The point that Adam is raising is that the debounced value from useDebouncedState hook isn't used - and we don't understand how this change fixes the original issue, could you explain what's the fix?

I've found that the same component is used this way

App/src/components/Search/SearchRouter/SearchRouter.tsx

Line 90 in 92707c3

const [textInputValue, , setTextInputValue] = useDebouncedState('', 500);

App/src/components/Search/SearchRouter/SearchRouter.tsx

Lines 321 to 322 in 92707c3

<SearchInputSelectionWrapper

value={textInputValue}

However, the original issue is fixed. I unified the behavior.

The #59262 issue was reported in SearchRouter.tsx (the component that pops up when you hit the search icon). I'm having some difficulty understanding how the modifications in SearchPageHeaderInput.tsx can solve this issue.

Additionally, it seems that the use of useDebouncedState in 'SearchRouter.tsx` might not have been intentional. It would be helpful if we could clarify the reasoning behind it.

Does this make sense? Am I missing something here?

…/59262-search-results

rezkiy37 · 2025-04-18T08:22:30Z

I've synced it up and fixed the conflicts.
cc @marcaaron @parasharrajat

rezkiy37 · 2025-04-18T08:37:14Z

There is a eslint fail but it is not associated with the PR.

289Adam289 · 2025-04-18T11:31:04Z

If the issue #59262 is no longer reproducible, is it possible that it was resolved in a different PR? If that's the case, maybe a revert of the recent changes would be a better option.

parasharrajat · 2025-04-18T12:58:03Z

I am up for revert if original issue is fixed.

rezkiy37 · 2025-04-18T13:49:25Z

Working on it.

rezkiy37 · 2025-04-18T14:06:25Z

I've tested it with reverted changes - 13b236d. I can confirm the original bug is no longer replicable. We don't need any changes to SearchPageHeaderInput. So this PR reverts the debounced behavior. Also, no bug #60395.

Videos

IOS.mp4

Chrome.mp4

cc @parasharrajat @289Adam289 @blazejkustra @marcaaron

parasharrajat

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

🎀 👀 🎀 C+ reviewed

…sults [CP Staging] Revert the debounced search in Search (cherry picked from commit bcc30a9) (CP triggered by marcaaron)

OSBotify · 2025-04-18T18:22:17Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-04-18T18:49:11Z

🚀 Cherry-picked to staging by https://github.com/marcaaron in version: 9.1.29-10 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	cancelled 🔪
🤖 android 🤖	cancelled 🔪
🍎 iOS 🍎	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

github-actions · 2025-04-18T19:37:13Z

🚀 Cherry-picked to staging by https://github.com/marcaaron in version: 9.1.29-10 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

marcaaron · 2025-04-18T19:38:30Z

Problems are fixed, thanks!

github-actions · 2025-04-18T20:33:24Z

🚀 Deployed to production by https://github.com/marcaaron in version: 9.1.29-10 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

Refactor SearchAutocompleteInput and SearchPageHeaderInput components…

d6a93fb

… to remove local state management and implement debounced state handling. Update input handling to directly use props for better performance and consistency.

rezkiy37 mentioned this pull request Apr 17, 2025

[$250] iOS Hybrid - Search - app not apply the second character when typing offline #59262

Closed

8 tasks

Update SearchAutocompleteInput and SearchPageHeaderInput components t…

4f1c1b6

…o allow missing data in useOnyx calls, enhancing robustness in data handling.

rezkiy37 changed the title ~~[WIP] Enhance SearchPageHeaderInput with the debounced search~~ Enhance SearchPageHeaderInput with the debounced search Apr 17, 2025

rezkiy37 marked this pull request as ready for review April 17, 2025 11:35

rezkiy37 requested a review from a team as a code owner April 17, 2025 11:35

melvin-bot Bot requested review from parasharrajat and removed request for a team April 17, 2025 11:36

rezkiy37 mentioned this pull request Apr 17, 2025

Enhance SearchAutocompleteInput with the debounced search #59659

Merged

50 tasks

mollfpr mentioned this pull request Apr 17, 2025

[Due for payment 2025-04-28] [Due for payment 2025-04-25] Search-Search syntax is not added to the field after clicking to search in the current chat #60395

Closed

8 tasks

marcaaron requested a review from mollfpr April 17, 2025 20:26

marcaaron assigned rezkiy37 Apr 17, 2025

marcaaron requested review from marcaaron and removed request for mollfpr and parasharrajat April 18, 2025 00:00

marcaaron changed the title ~~Enhance SearchPageHeaderInput with the debounced search~~ [CP Staging] Enhance SearchPageHeaderInput with the debounced search Apr 18, 2025

marcaaron previously approved these changes Apr 18, 2025

View reviewed changes

289Adam289 reviewed Apr 18, 2025

View reviewed changes

Merge branch 'main' of https://github.com/rezkiy37/Expensify into fix…

64577bd

…/59262-search-results

rezkiy37 dismissed marcaaron’s stale review via 64577bd April 18, 2025 08:19

revert SearchPageHeaderInput

13b236d

rezkiy37 requested review from 289Adam289, blazejkustra and marcaaron April 18, 2025 14:06

rezkiy37 changed the title ~~[CP Staging] Enhance SearchPageHeaderInput with the debounced search~~ [CP Staging] Revert the debounced search in Search Apr 18, 2025

parasharrajat approved these changes Apr 18, 2025

View reviewed changes

blazejkustra approved these changes Apr 18, 2025

View reviewed changes

marcaaron approved these changes Apr 18, 2025

View reviewed changes

marcaaron merged commit bcc30a9 into Expensify:main Apr 18, 2025
20 checks passed

OSBotify pushed a commit that referenced this pull request Apr 18, 2025

Merge pull request #60417 from callstack-internal/fix/59262-search-re…

30df141

…sults [CP Staging] Revert the debounced search in Search (cherry picked from commit bcc30a9) (CP triggered by marcaaron)

github-actions Bot added the CP Staging marks PRs that have been CP'd to staging label Apr 18, 2025

github-actions Bot mentioned this pull request Apr 18, 2025

Deploy Checklist: New Expensify 2025-04-16 #60369

Closed

87 tasks

Conversation

rezkiy37 commented Apr 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Apply all characters

Select by the keyboard

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Apr 17, 2025

Uh oh!

parasharrajat commented Apr 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Screenshots

🔲 iOS / native

🔲 iOS / Safari

🔲 MacOS / Desktop

🔲 MacOS / Chrome

🔲 Android / Chrome

🔲 Android / native

Uh oh!

rezkiy37 commented Apr 17, 2025

Uh oh!

marcaaron commented Apr 17, 2025

Uh oh!

marcaaron commented Apr 18, 2025

Uh oh!

github-actions Bot commented Apr 18, 2025

Uh oh!

github-actions Bot commented Apr 18, 2025

Uh oh!

marcaaron commented Apr 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

marcaaron left a comment

Choose a reason for hiding this comment

Uh oh!

marcaaron commented Apr 18, 2025

Uh oh!

parasharrajat commented Apr 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

289Adam289 Apr 18, 2025

Choose a reason for hiding this comment

Uh oh!

rezkiy37 Apr 18, 2025

Choose a reason for hiding this comment

Uh oh!

blazejkustra Apr 18, 2025

Choose a reason for hiding this comment

Uh oh!

rezkiy37 Apr 18, 2025

Choose a reason for hiding this comment

Uh oh!

289Adam289 Apr 18, 2025

Choose a reason for hiding this comment

Uh oh!

rezkiy37 commented Apr 18, 2025

Uh oh!

rezkiy37 commented Apr 18, 2025

Uh oh!

289Adam289 commented Apr 18, 2025

Uh oh!

parasharrajat commented Apr 18, 2025

Uh oh!

rezkiy37 commented Apr 18, 2025

Uh oh!

rezkiy37 commented Apr 18, 2025

Uh oh!

parasharrajat left a comment

Choose a reason for hiding this comment

Reviewer Checklist

Uh oh!

Uh oh!

rezkiy37 commented Apr 17, 2025 •

edited

Loading

parasharrajat commented Apr 17, 2025 •

edited

Loading

marcaaron commented Apr 18, 2025 •

edited

Loading

parasharrajat commented Apr 18, 2025 •

edited

Loading