Update admin case so global create and reports empty state say take a test drive#60724
Conversation
… state say take a test drive
fabioh8010
left a comment
There was a problem hiding this comment.
LGTM but you have ESLint errors
…ons-to-take-a-test-drive
…ons-to-take-a-test-drive
|
@rushatgabhane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: mWeb ChromeMacOS: Chrome / SafariScreen.Recording.2025-04-28.at.21.08.42.movMacOS: Desktop |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/danieldoglas in version: 9.1.38-0 🚀
|
|
🚀 Deployed to production by https://github.com/thienlnam in version: 9.1.38-4 🚀
|
There was a problem hiding this comment.
Hey I think this PR is generating a canBeMissing error related to changes in this file
|
|
||
| const viewTourTaskReportID = introSelected?.viewTour; | ||
| const [viewTourTaskReport] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT}${viewTourTaskReportID}`); | ||
| const [viewTourTaskReport] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT}${viewTourTaskReportID}`, {canBeMissing: false}); |
There was a problem hiding this comment.
I think viewTourTaskReport should be optional, since introSelected?.viewTour can be undefined.
App/src/types/onyx/IntroSelected.ts
Line 16 in 81b1b49






… state say take a test drive
Explanation of Change
Fixed Issues
$#60583
PROPOSAL: #60583 (comment)
Tests
Manage my team's expensesthen pick1-10 employees. There's no need to select any accounting software.Account > Workspaces, open the only workspace you have, then go toMore featuresand enable invoicesExpenses,Expense ReportsandInvoicesshow modals that ask you to either create an expense/invoice or take a test drive.Take a 2-minute test drive.Offline tests
Same as tests.
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android.-.Native.mp4
Android: mWeb Chrome
Android.-.Chrome.mp4
iOS: Native
iOS.-.Native.mp4
iOS: mWeb Safari
iOS.-.Safari.mp4
MacOS: Chrome / Safari
MacOS.-.Chrome.mp4
MacOS: Desktop
MacOS.-.Desktop.mp4