fix: cursor lag during typing on mWeb SignIn page by Eskalifer1 · Pull Request #60941 · Expensify/App

Eskalifer1 · 2025-04-26T10:37:46Z

Explanation of Change

Fixed Issues

$ #60401
PROPOSAL: #60401 (comment)

Tests

Navigate to the sign in page
In the "Phone or email" field type in a quick manner several characters, eg 14253648463, watch how the cursor moves
Delete characters in a quick manner, tapping the "x" button, watch how the cursor moves
(Same as in Issue)
A few console errors related to canBeMissing are present, but they are irrelevant to this PR.

Verify that no errors appear in the JS console

Offline tests

Navigate to the sign in page
In the "Phone or email" field type in a quick manner several characters, eg 14253648463, watch how the cursor moves
Delete characters in a quick manner, tapping the "x" button, watch how the cursor moves
(Same as in Issue)

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.mp4

Android: mWeb Chrome

android-web.mp4

iOS: Native

ios.mp4

iOS: mWeb Safari

ios-web.mp4

MacOS: Chrome / Safari

web.mp4

MacOS: Desktop

desktop.mp4

melvin-bot · 2025-04-26T10:37:51Z

@hungvu193 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2025-04-26T10:38:01Z

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

Eskalifer1 · 2025-04-26T11:04:50Z

I have read the CLA Document and I hereby sign the CLA

hungvu193 · 2025-04-26T16:28:47Z

+    const [login, setLoginState] = useState(() => Str.removeSMSDomain(credentials?.login ?? ''));
+
+    const setLogin = useCallback((newLogin: string) => {
+        setLoginState(Str.removeSMSDomain(newLogin));


I don't think we need to removeSMSDomain everytime we change the login. setLoginState(newLogin) is just enough.
Can you explain?

Yes, I agree with you, I just wasn't sure if it was needed in setLogin, so I added it just in case.

I will update the PR now

Cool. Let's do it.

@hungvu193 I have a question, today before doing the PR I checked for eslint errors and there were none (I called it with the npm run lint-changed command). Now I call this command and I get 13 errors, even though they don't even refer to parts of my code, what could be the problem?

Do I need to fix them? Because I see that there are no new changes related to eslint or these pages on the main branch that would be related to this code

For example, an error is thrown on this line, although it is not related to my code and is identical to the code on the main branch

App/src/pages/signin/SignInPage.tsx

Line 156 in a9b6d36

const [account] = useOnyx(ONYXKEYS.ACCOUNT);

I don't have access to Slack to ask (I sent the request about 3 weeks ago) :)

@Eskalifer1 You still need to fix the lint, I know that wasn't related to your changes.

With Onyx linting, you can simply pass {canBeMissing: true}

//ie const [network] = useOnyx(ONYXKEYS.NETWORK, {canBeMissing: true});

Okay, I'll try to do it now, it looks pretty strange, because this code hasn't been touched for a long time, and when I did the PR, these errors were not there)

Ah yeah. We have a new ESlint rule about onyx and import syntax but it will only check for changed files. Becasue the source code is huge, we can't refactor in one go, so checking lint for changed files will be better

@hungvu193 Updated PR with eslint and your proposal changes. I apologize if something is wrong, this is my first PR, so I still don't know a lot)

No worries.

hungvu193 · 2025-04-26T17:56:54Z

+function SignInPageLoginWrapper(props: SignInPageProps, ref: ForwardedRef<SignInPageRef>) {
+    return (
+        <LoginProvider>
+            <SignInPageWithRef
+                ref={ref}
+                // eslint-disable-next-line react/jsx-props-no-spreading
+                {...props}
+            />
+        </LoginProvider>
+    );
+}
+
+SignInPageLoginWrapper.displayName = 'SignInPage';
+
+const SignInPageLoginWrapperWithRef = forwardRef(SignInPageLoginWrapper);
+


We don't need this one right? This isn't very clear to me because we already forwardRef above:

const SignInPageWithRef = forwardRef(SignInPage);

Then we did it again here:

const SignInPageLoginWrapperWithRef = forwardRef(SignInPageLoginWrapper);

How about removing this block of code and just wrapping LoginProider insideSignInPageThemeWrapper?

I mentioned this here: #60401 (comment)

As for me, the SignInPageThemeWrapper should be responsible only for the theme, as the name suggests, so I added a new Wrapper that is responsible for waking up the login. If you need, I can rework it, just let me know

Or we can just rename it to SignInPageWrapper, and then add the provider for Login

I see. Then I think just wrap it inside SignInPage then? Like you mentioned here:
#60401 (comment)

In my opinion, this will ruin the clean code a bit, because then the rendering of the component and its Wrapper will be mixed. But it's up to you to decide. It seems to me that the best option, if we are not satisfied with another separate wrapper (as I did in the PR), is to rename ThemeWrapper simply to Wrapper, then this new component will be responsible not only for the theme, but also for everything else. The final say is still yours :)

is to rename ThemeWrapper simply to Wrapper

I think this makes sense. Wdyt?

I think so. I tried to separate the logic so as not to mix Providers that are responsible for different things with each other, but we can combine everything into one component if it is acceptable

Cool. I think we only have Provider related to theme before, that's why we named it ThemeProvider, but now we have one more, so renaming it to wrapper will make it cleaner. Let's do it.

Okay, I'll update the PR now

@hungvu193 Updated PR

… component SignInPageWrapper

hungvu193 · 2025-04-26T18:29:49Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2025-04-26.at.23.12.13.mov

Android: mWeb Chrome

Screen.Recording.2025-04-26.at.23.13.37.mov

iOS: Native

Screen.Recording.2025-04-26.at.23.08.47.mov

iOS: mWeb Safari

Screen.Recording.2025-04-26.at.23.07.36.mov

MacOS: Chrome / Safari

Screen.Recording.2025-04-26.at.22.48.38.mov

MacOS: Desktop

Screen.Recording.2025-04-26.at.23.06.37.mov

hungvu193

LGTM

Valforte

LGMT!

Eskalifer1 · 2025-04-28T13:28:46Z

Hi everyone, should i do something else now?

hungvu193 · 2025-04-28T13:29:47Z

All good here. In case there is regression you should fix it. As for now, you don't need to do anything

Eskalifer1 · 2025-04-28T13:30:27Z

Okay, thx

Valforte · 2025-04-28T20:05:30Z

@Eskalifer1 can you merge main into your branch? That will fix the ESLint error

github-actions · 2025-04-29T07:22:38Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

hungvu193 · 2025-04-29T07:28:50Z

@Eskalifer1 Looks like a bad merge 0c930ec

Can you check please?

Eskalifer1 · 2025-04-29T07:37:47Z

@Valforte Hi, I've merged main to the branch, as you said

Eskalifer1 · 2025-04-29T07:38:31Z

@hungvu193 Yes, I updated, for some reason it created this as a separate commit and not as a merge, but I've already fixed it

dubielzyk-expensify · 2025-04-29T11:21:00Z

Does this need a design review?

Valforte · 2025-04-29T12:00:32Z

@dubielzyk-expensify no, ill remove the tag

hungvu193 · 2025-04-29T16:15:12Z

We have some lintings 🤔 But I don't think it's related to this PR.

Eskalifer1 · 2025-04-29T16:31:33Z

We have some lintings 🤔 But I don't think it's related to this PR.

It looks like it, but these files with errors have nothing to do with the login page where the changes were made

hungvu193 · 2025-04-29T16:54:08Z

can you merge main again? @Eskalifer1

Valforte · 2025-04-29T16:55:46Z

I checked and those are already fixed in main, so a merge is supposed to fix it

Eskalifer1 · 2025-04-29T17:54:07Z

@hungvu193 Updated PR

Valforte

LGTM

OSBotify · 2025-04-29T18:06:47Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-04-30T01:06:38Z

🚀 Deployed to staging by https://github.com/Valforte in version: 9.1.38-0 🚀

platform	result
🖥 desktop 🖥	failure ❌
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-05-01T19:36:37Z

🚀 Deployed to production by https://github.com/thienlnam in version: 9.1.38-4 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

Eskalifer1 requested a review from a team as a code owner April 26, 2025 10:37

melvin-bot Bot requested review from hungvu193 and removed request for a team April 26, 2025 10:37

fix: cursor lag during typing on mWeb SignIn page

197b9ba

Eskalifer1 force-pushed the fix-60401 branch from fc2a767 to 197b9ba Compare April 26, 2025 11:11

CLABotify added a commit to Expensify/CLA that referenced this pull request Apr 26, 2025

@Eskalifer1 has signed the CLA in Expensify/App#60941

e589ae2

Eskalifer1 mentioned this pull request Apr 26, 2025

[Due for payment 2025-05-08] [$250] mWeb-Sign in-The cursor can't keep up with the typing #60401

Closed

8 tasks

hungvu193 suggested changes Apr 26, 2025

View reviewed changes

Eskalifer1 added 2 commits April 26, 2025 20:30

fix: removed Str.removeSMSDomain from setLogin function

1ee491f

eslint fix

32a9fc7

hungvu193 suggested changes Apr 26, 2025

View reviewed changes

Replaced LoginProvider and ThemeProvider for the SignIn page into one…

2c7f5d7

… component SignInPageWrapper

hungvu193 approved these changes Apr 26, 2025

View reviewed changes

melvin-bot Bot requested a review from Valforte April 26, 2025 18:30

Valforte previously approved these changes Apr 28, 2025

View reviewed changes

Eskalifer1 dismissed Valforte’s stale review via 0c930ec April 29, 2025 07:22

Eskalifer1 requested a review from a team as a code owner April 29, 2025 07:22

Merge remote-tracking branch 'origin/main' into fix-60401

392ba86

Eskalifer1 force-pushed the fix-60401 branch from 0c930ec to 392ba86 Compare April 29, 2025 07:36

Valforte removed the request for review from a team April 29, 2025 12:00

Merge remote-tracking branch 'origin' into fix-60401

eda8b47

Valforte approved these changes Apr 29, 2025

View reviewed changes

Valforte merged commit 93657d2 into Expensify:main Apr 29, 2025
16 checks passed

github-actions Bot mentioned this pull request Apr 30, 2025

Deploy Checklist: New Expensify 2025-04-30 #61122

Closed

50 tasks

Conversation

Eskalifer1 commented Apr 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Apr 26, 2025

Uh oh!

github-actions Bot commented Apr 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Eskalifer1 commented Apr 26, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hungvu193 Apr 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hungvu193 commented Apr 26, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

hungvu193 left a comment

Choose a reason for hiding this comment

Uh oh!

Valforte left a comment

Choose a reason for hiding this comment

Uh oh!

Eskalifer1 commented Apr 28, 2025

Uh oh!

hungvu193 commented Apr 28, 2025

Uh oh!

Eskalifer1 commented Apr 28, 2025

Uh oh!

Valforte commented Apr 28, 2025

Uh oh!

github-actions Bot commented Apr 29, 2025

Uh oh!

Eskalifer1 commented Apr 26, 2025 •

edited

Loading

github-actions Bot commented Apr 26, 2025 •

edited

Loading

hungvu193 Apr 26, 2025 •

edited

Loading