Account Switcher fix emojis cut-off

[ChavdaSachin]

Explanation of Change

Fixed Issues

$ #61030
PROPOSAL: #61030

Tests

Same as QA

• Verify that no errors appear in the JS console

Offline tests

Same as QA

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

1. login with an account having emojis in the name.
2. Open settings page from bottom tab navigator.
3. Verify both text and emojis are fully visible in account switcher.

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

[melvin-bot]

@jjcoffee Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[shawnborton]

Hmm I thought we needed the line height to be 20px here, otherwise the combo of name + login ends up being taller than the avatar to the left.

As it stands now, I don't think we should merge this.

I think we should keep the line height at 20px, but just remove the overflow: hidden that is cutting the emoji off.

[shawnborton]

Can you show me a side-by-side of when a display name has an emoji vs when it doesn't? You should easily be able to see the difference in height that we are trying to avoid. Thanks!

[jjcoffee]

@ChavdaSachin friendly bump on this 🙏

[jjcoffee]

@shawnborton Here you go:

[shawnborton]

This is what I see, notice how the layout jumps when we remove lineHeight 20?

CleanShot.2025-05-05.at.10.14.38.mp4

We need to prevent the shift in layout here... curious what other ideas we have.

[ChavdaSachin]

Sorry I totally missed to update this issue.
checking out @shawnborton's idea of removing overflow: hidden property,
will provide an update within an hour or two.

[ChavdaSachin]

I tried by applying both overflow: visible and overflow: auto but this does not seem to solve the problem, I even tried by applying both properties to the parent element but no success there as well.

Since this is only happening with IOS native - there could be chances than it is an upstream bug.
looking further into it.

[ChavdaSachin]

@jjcoffee do you have anything on mind, what could be done here?

[jjcoffee]

@ChavdaSachin Like you say, it's strange that it only happens on iOS (and for me it seems to only happen on certain iOS devices - as it didn't happen when I tested the original PR).

Can you check what @shawnborton posted here? I'm curious if toggling an emoji on and off causes any layout shift on its own, or if it's simply the enabling/disabling of the line-height that does it.

When I test on Chrome (Linux), I don't see any layout shifting at all.

desktop-chrome-lineheight-toggle-2025-05-07_10.32.22.mp4

[ChavdaSachin]

@shawnborton based on my observations I am suspecting emojis are not actually being rendered in 17px size even though font size is set to 17px they are being upscaled somehow.

Could you maybe confirm if emojis being rendered are really 17px ?

What I tried to reach above conclusion.

• First I removed the lineHeight style and checked the automatically calculated line height which was 20, then I included emoji in the name and the element size increased to 27 even though font size is 17. And even by simple visual comparison emojis looks bigger than text.

[shawnborton]

I don't have any reason to believe they are NOT being rendered at 17px... based on what I see here via code inspect:

[jjcoffee]

It doesn't seem like we're moving any closer towards a solution here, unfortunately.

I'm thinking that since having emojis in your name is quite an edge case anyway, and that it isn't reproducible on all versions of iOS (I didn't see it during testing of the original PR, for example), maybe we can just add an iOS native-specific fix where we lose the line-height (and accept the minor layout adjustment)? Or I suppose we could just accept that it's a bit buggy on some versions of iOS 😄

Thoughts @shawnborton @ChavdaSachin?

[shawnborton]

Maybe we should go back to the issue and find different/better proposals that actually solve this then.

[jjcoffee]

Sorry just remembering that the alignment issue was already present on the app before the original PR (see my comment here), so I think we should either:

1. drop the line height and open a separate issue for fixing that, or
2. use the fix that @ChavdaSachin originally had on the PR, using align-items: center (before we switched to adding line-height). The result of that is also shown here, where the alignment looks fixed (eyeballing it, at least!).

[shawnborton]

I think we really just need to use overflow: visible here, and then it doesn't matter how big the emoji is:

[shawnborton]

We might even want to explicitly add height: 20px too

[jjcoffee]

@shawnborton Unfortunately, that doesn't work on iOS native (where this issue stems from), see @ChavdaSachin's comment.

[jjcoffee]

How about we just bump the line-height slightly? The difference is minuscule, but we could apply it to iOS native only if needed. @ChavdaSachin would need to test with a few different emojis to make sure it covers all bases.

As a reminder, this issue was present before the original PR (line height was never set on this element), so it's a bit of scope-creep to fix it here. I think this works fine as an initial solution, though.

With 22px line-height:

Original line-height:

[shawnborton]

I don't think we should change the line height to 22px, we want to use our standard text line height of 20px here.

[jjcoffee]

Alrighty! There was no line height set on this element before the previous PR, so I think we should proceed with this PR as-is to fix the core issue (emojis getting cropped), and create a separate issue to handle the alignment when emojis are in the display name. Since the fix is non-trivial I think it's unfair to expect the contributor to fix it here. Does that sound good?

[shawnborton]

Hmm I'm not sure if I think we should merge this PR, it seems like it is going to make things worse by:

• removing the line height which we actually want
• removes the style for the line height we have, which is used all over the app I think

[jjcoffee]

Just for a bit of extra context, the reason why the cropping happens here but not in the profile settings page (under Display name), is because there the font size is 15px, with a 20px line height (i.e. line height is 1.333x the font size). Emojis on iOS just need a bit of extra breathing room, which can done in a few ways:

• line height
• padding
• font size

[shawnborton]

If that's the case, I would suggest we try something that only styles the emoji itself but maintains the same vertical alignment within the 20px box we expect for the name. Again, that area should only be 20px tall.

[jjcoffee]

The underlying issue here is that iOS clips emojis when their bounding box exceeds the line height, so you can't style the emoji separately whilst also maintaining a fixed line height on the parent element. In other words I don't think what you're asking is possible here.

I suspect that the reason the emojis were rendered at 15px originally here was to work around this exact issue, as the smaller font size combined with the 1.3x larger line height gives the emoji glyph sufficient breathing room to render without clipping.

[ChavdaSachin]

I am sorry I wasn't able to participate in the conversation, but I am OOO today. Tomorrow I would try to come up with something concrete which should help us conclude this issue.

What ideas I have on my mind as of now

• Try to find a native fix.
• Remove all existing styles from the accountSwitcher component and restyle it.

[ChavdaSachin]

@jjcoffee this seems to be a more widespread problem.

I could notice - emojis are being cutoff in composer and other input fields too.

Checkout these attachments.

[ChavdaSachin]

This issue has been around for really long time.
Previously it was solved by adding verticalMargin: -7 for iOS native. Reference

We could make use of the same component for this issue.

-                                <Text
-                                    numberOfLines={1}
+                                <TextWithEmojiFragment
+                                    message={currentUserPersonalDetails?.displayName}
                                     style={[styles.textBold, styles.textLarge, styles.flexShrink1
, styles.lineHeightXLarge]}
-                                >
-                                    {currentUserPersonalDetails?.displayName}
-                                </Text>
+                                />

does this look good enough @shawnborton ?

[shawnborton]

That does look better, yes.

[jjcoffee]

@ChavdaSachin Do you want to go ahead and implement the change you suggested?

[ChavdaSachin]

Changes are up. Ready for review, Screenshots are updated.

cc. @jjcoffee

[jjcoffee]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
• I verified tests pass on all platforms & I tested again on:
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

[jjcoffee]

I'm having problems building iOS, I'll have to retry on Monday. @ChavdaSachin Are you able to provide a screenshot on iPhone 13? Just so we're sure this is fixed on the tester device from the original issue.

[ChavdaSachin]

Alright I would test it on iPhone 13.

I also faced a build issue on Android, but locally merging with the main branch and reinstall modules and pods worked.

[jjcoffee]

@ChavdaSachin Bump on this. Also could you merge main? I'm still unable to test iOS but only on this PR now.

[ChavdaSachin]

would get it done within 24 hrs.

[ChavdaSachin]

Merged main

and here's the ss of iPhone 13

[ChavdaSachin]

@jjcoffee do let me know if you're facing any issue.

And you could trigger an adHoc build and test(if you have a physical device).

[jjcoffee]

Thanks! And sorry, I had more urgent tasks to take care of.

[jjcoffee]

LGTM!

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[github-actions]

🚀 Deployed to staging by https://github.com/MariaHCD in version: 9.1.60-1 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[github-actions]

🚀 Deployed to production by https://github.com/roryabraham in version: 9.1.61-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

[github-actions]

🚀 Deployed to staging by https://github.com/MariaHCD in version: 9.1.62-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

[github-actions]

🚀 Deployed to production by https://github.com/Julesssss in version: 9.1.62-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅