[CP-stag] Remove fallback value#61286
Conversation
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
|
Proceeding to merge without waiting for C+ to review because this fixes an hourly blocker. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
[CP-stag] Remove fallback value (cherry picked from commit 62a49d2) (cherry-picked to staging by marcaaron)
Performance Comparison Report 📊 (1/10)Significant Changes To Duration
Show details
|
Performance Comparison Report 📊 (10/10)Meaningless Changes To Duration (9/9)Show entries
Show details
|
Performance Comparison Report 📊 (2/10)Meaningless Changes To Duration (1/9)Show entries
Show details
|
Performance Comparison Report 📊 (3/10)Meaningless Changes To Duration (2/9)Show entries
Show details
|
Performance Comparison Report 📊 (4/10)Meaningless Changes To Duration (3/9)Show entries
Show details
|
Performance Comparison Report 📊 (5/10)Meaningless Changes To Duration (4/9)Show entries
Show details
|
Performance Comparison Report 📊 (6/10)Meaningless Changes To Duration (5/9)Show entries
Show details
|
Performance Comparison Report 📊 (7/10)Meaningless Changes To Duration (6/9)Show entries
Show details
|
Performance Comparison Report 📊 (8/10)Meaningless Changes To Duration (7/9)Show entries
Show details
|
Performance Comparison Report 📊 (9/10)Meaningless Changes To Duration (8/9)Show entries
Show details
|
|
@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker. |
|
🚀 Cherry-picked to staging by https://github.com/marcaaron in version: 9.1.39-2 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.1.39-8 🚀
|
|
🚀 Cherry-picked to staging by https://github.com/marcaaron in version: 9.1.40-0 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.1.40-7 🚀
|
Explanation of Change
Fixed Issues
$ #61275
PROPOSAL: #61275 (comment)
Tests
Same as QA
Offline tests
Same as QA
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2025-05-02.at.6.19.35.AM.mov
Android: mWeb Chrome
Screen.Recording.2025-05-02.at.6.20.35.AM.mov
iOS: Native
Screen.Recording.2025-05-02.at.6.43.13.AM.mov
iOS: mWeb Safari
Screen.Recording.2025-05-02.at.6.22.46.AM.mov
MacOS: Chrome / Safari
Screen.Recording.2025-05-02.at.6.03.47.AM.mov
MacOS: Desktop
Screen.Recording.2025-05-02.at.6.33.32.AM.mov