[CP Staging] Fix: Workspace chat tooltip not displayed when invited to workspace#61338
Conversation
|
@ishpaul777 PR is ready for review |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2025-05-03.at.12.44.18.AM.movAndroid: mWeb ChromeScreen.Recording.2025-05-03.at.12.32.38.AM.moviOS: HybridAppScreen.Recording.2025-05-03.at.12.41.04.AM.moviOS: mWeb SafariScreen.Recording.2025-05-03.at.12.35.50.AM.movMacOS: Chrome / SafariScreen.Recording.2025-05-03.at.12.19.18.AM.movMacOS: DesktopScreen.Recording.2025-05-03.at.1.03.31.AM.mov |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Performance Comparison Report 📊 (1/11)Significant Changes To Duration
Show details
|
Performance Comparison Report 📊 (10/11)Meaningless Changes To Duration (9/10)Show entries
Show details
|
Performance Comparison Report 📊 (11/11)Meaningless Changes To Duration (10/10)Show entries
Show details
|
Performance Comparison Report 📊 (2/11)Meaningless Changes To Duration (1/10)Show entries
Show details
|
Performance Comparison Report 📊 (3/11)Meaningless Changes To Duration (2/10)Show entries
Show details
|
Performance Comparison Report 📊 (4/11)Meaningless Changes To Duration (3/10)Show entries
Show details
|
Performance Comparison Report 📊 (5/11)Meaningless Changes To Duration (4/10)Show entries
Show details
|
Performance Comparison Report 📊 (6/11)Meaningless Changes To Duration (5/10)Show entries
Show details
|
Performance Comparison Report 📊 (7/11)Meaningless Changes To Duration (6/10)Show entries
Show details
|
Performance Comparison Report 📊 (8/11)Meaningless Changes To Duration (7/10)Show entries
Show details
|
Performance Comparison Report 📊 (9/11)Meaningless Changes To Duration (8/10)Show entries
Show details
|
|
@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker. |
[CP Staging] Fix: Workspace chat tooltip not displayed when invited to workspace (cherry picked from commit 017630a) (cherry-picked to staging by yuwenmemon)
|
🚀 Cherry-picked to staging by https://github.com/yuwenmemon in version: 9.1.39-8 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.1.39-8 🚀
|
|
🚀 Cherry-picked to staging by https://github.com/yuwenmemon in version: 9.1.40-0 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.1.40-7 🚀
|

Explanation of Change
We need to determine if the LHN GBR/RBR tooltips is dismissed using
nvp_dismissedProductTraininginstead of calling theuseProductTrainingContexthookFixed Issues
$ #61295
$ #61351
PROPOSAL:
Tests
Offline tests
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2025-05-02.at.4.57.39.PM.mov
Android: mWeb Chrome
Screen.Recording.2025-05-02.at.4.58.22.PM.mov
iOS: Native
Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2025-05-02.at.16.33.05.mp4
iOS: mWeb Safari
Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2025-05-02.at.16.52.54.mp4
MacOS: Chrome / Safari
Screen.Recording.2025-05-02.at.4.30.36.PM.mov
MacOS: Desktop
Screen.Recording.2025-05-02.at.4.22.16.PM.mov