-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Include Mobile-Expensify PRs in the App release checklist #61540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Julesssss
wants to merge
23
commits into
main
Choose a base branch
from
jules-includeMobilePrsInChecklist
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* main: (170 commits) Rename variable Update docs/articles/new-expensify/workspaces/Set-up-rules.md Update docs/articles/new-expensify/workspaces/Prohibited-Expense-Rule.md Update Prohibited-Expense-Rule.md Update and rename prohibited-expense-rule.md to Prohibited-Expense-Rule.md Update Set-up-rules.md Update prohibited-expense-rule.md Create prohibited-expense-rule.md Update Set-up-rules.md Fix storybook fix TS adjust table Bug fix Disable the new flow until ready Fix pay button overlapping avatar fix eslint rm policy prop always display button in success style fix: test fix: Keyboard opened with device back button ...
5d13957 to
92b2c6d
Compare
* main: (282 commits) Update Mobile-Expensify submodule version to 9.1.43-2 Update version to 9.1.43-2 Update Mobile-Expensify submodule version to 9.1.43-1 Update version to 9.1.43-1 Update Mobile-Expensify submodule version to 9.1.43-0 Update version to 9.1.43-0 Update Mobile-Expensify submodule version to 9.1.42-5 Update version to 9.1.42-5 Update Mobile-Expensify submodule version to 9.1.42-4 Update version to 9.1.42-4 Update Mobile-Expensify submodule to 8cf1dae Revert "feat: Add register for webinar button" Update Mobile-Expensify submodule version to 9.1.42-3 Update version to 9.1.42-3 Update Mobile-Expensify submodule version to 9.1.42-2 Update version to 9.1.42-2 fix another test fix test disable workflow if user is not member update logic ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation of Change
TODO
Fixed Issues
$ #58775
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop