Remove 'Show More' section when creating expense by nyomanjyotisa · Pull Request #62543 · Expensify/App

nyomanjyotisa · 2025-05-22T02:24:53Z

Explanation of Change

Fixed Issues

$ #62220
PROPOSAL: #62220 (comment)

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Navigate to the "Create Expense" screen
By default, the destination is set to the workspace — Verify that all fields are displayed and there is no "Show More" button
Change the destination to personal space
Verify that all fields are displayed and there is no "Show More" button

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android-Native.mp4

Android: mWeb Chrome

Android-mWeb.Chrome.mp4

iOS: Native

iOS-Native.mp4

iOS: mWeb Safari

iOS-mWeb.Safari.mp4

MacOS: Chrome / Safari

MacOS-Chrome.mp4

MacOS: Desktop

MacOS-Desktop.mp4

melvin-bot · 2025-05-22T04:14:49Z

@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

nyomanjyotisa · 2025-05-22T04:15:46Z

Do we need to adjust the sorting here? We can switch the date and category field order

Here is the comparison

Current Change	Adjusted Order

cc @eVoloshchak

eVoloshchak · 2025-05-26T17:12:42Z

@nyomanjyotisa, that is correct, the order sould remain the same

nyomanjyotisa · 2025-05-27T02:56:29Z

PR has been updated, and the videos are also updated

eVoloshchak

An intermediate structure that helps us classify the fields as "primary" and "supplementary". The primary fields are always shown to the user, while an extra action is needed to reveal the supplementary ones.

This comment in src/components/MoneyRequestConfirmationListFooter.tsx is no longer needed, as the whole classification logic was removed. classifiedFields should be fields too by that logic

nyomanjyotisa · 2025-06-02T01:07:17Z

I've updated the PR

eVoloshchak · 2025-06-04T14:43:56Z

Apologies, I'm a bit late, there are some new conflicts, could you please pull the latest main?

nyomanjyotisa · 2025-06-05T01:19:29Z

Sure, I've merged with the latest main

eVoloshchak · 2025-06-08T14:31:58Z

-                />
-            )}
-            <View style={[styles.mb5]}>{shouldShowAllFields && supplementaryFields}</View>
+            {fields.filter((field) => field.shouldShow).map((field) => field.item)}


Suggested change

{fields.filter((field) => field.shouldShow).map((field) => field.item)}

<View style={[styles.mb5]}>{fields.filter((field) => field.shouldShow).map((field) => field.item)}</View>

There's a slight difference between the two, let's keep it consistent with how it was implemented before

PR Updated!

eVoloshchak · 2025-06-11T21:14:55Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-06-11.at.23.35.45.mov

Android: mWeb Chrome

Screen.Recording.2025-06-11.at.23.28.33.mov

iOS: HybridApp

Screen.Recording.2025-06-11.at.23.21.28.mov

iOS: mWeb Safari

Screen.Recording.2025-06-11.at.23.23.16.mov

MacOS: Chrome / Safari

Screen.Recording.2025-06-11.at.23.18.26.mov

MacOS: Desktop

Screen.Recording.2025-06-11.at.23.19.05.mov

eVoloshchak

LGTM!

OSBotify · 2025-06-12T11:43:29Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-06-12T22:36:38Z

🚀 Deployed to staging by https://github.com/JS00001 in version: 9.1.66-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-06-16T10:57:58Z

🚀 Deployed to production by https://github.com/lakchote in version: 9.1.66-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

github-actions · 2025-06-16T15:53:42Z

🚀 Deployed to production by https://github.com/lakchote in version: 9.1.66-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	failure ❌

github-actions · 2025-06-16T16:14:23Z

🚀 Deployed to production by https://github.com/lakchote in version: 9.1.66-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

nyomanjyotisa added 3 commits May 22, 2025 10:15

Remove 'Show More' when creating expense

85d1333

Remove 'Show More' when creating expense

ddeb49a

TypeScript fix

c9b9d68

nyomanjyotisa marked this pull request as ready for review May 22, 2025 04:14

nyomanjyotisa requested a review from a team as a code owner May 22, 2025 04:14

melvin-bot Bot requested review from eVoloshchak and removed request for a team May 22, 2025 04:14

fix: field order

ecc6a49

Merge branch 'main' into issue-62220

2b60549

eVoloshchak suggested changes Jun 1, 2025

View reviewed changes

minor fix

ae71c34

Merge branch 'main' into issue-62220

5a39680

eVoloshchak reviewed Jun 8, 2025

View reviewed changes

minor fix

2d8e867

eVoloshchak approved these changes Jun 11, 2025

View reviewed changes

melvin-bot Bot requested a review from JS00001 June 11, 2025 21:36

JS00001 approved these changes Jun 12, 2025

View reviewed changes

JS00001 merged commit c69fa7e into Expensify:main Jun 12, 2025
18 of 19 checks passed

github-actions Bot mentioned this pull request Jun 12, 2025

Deploy Checklist: New Expensify 2025-06-12 #64109

Closed

44 tasks

melvin-bot Bot mentioned this pull request Jun 16, 2025

[Due for payment 2025-06-23] [$250] "Merchant" Field Hidden Behind "Show More" When Sending Expense to Personal Space #62220

Closed

16 tasks

trjExpensify mentioned this pull request Sep 15, 2025

Expense - In expense details page, show more button is not displayed #70583

Closed

16 tasks

	{fields.filter((field) => field.shouldShow).map((field) => field.item)}
	<View style={[styles.mb5]}>{fields.filter((field) => field.shouldShow).map((field) => field.item)}</View>

Conversation

nyomanjyotisa commented May 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented May 22, 2025

Uh oh!

nyomanjyotisa commented May 22, 2025

Uh oh!

eVoloshchak commented May 26, 2025

Uh oh!

nyomanjyotisa commented May 27, 2025

Uh oh!

eVoloshchak left a comment

Choose a reason for hiding this comment

Uh oh!

nyomanjyotisa commented Jun 2, 2025

Uh oh!

eVoloshchak commented Jun 4, 2025

Uh oh!

nyomanjyotisa commented Jun 5, 2025

Uh oh!

eVoloshchak Jun 8, 2025

Choose a reason for hiding this comment

Uh oh!

nyomanjyotisa Jun 9, 2025

Choose a reason for hiding this comment

Uh oh!

eVoloshchak commented Jun 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

eVoloshchak left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Jun 12, 2025

Uh oh!

github-actions Bot commented Jun 12, 2025

Uh oh!

github-actions Bot commented Jun 16, 2025

Uh oh!

github-actions Bot commented Jun 16, 2025

Uh oh!

github-actions Bot commented Jun 16, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

nyomanjyotisa commented May 22, 2025 •

edited

Loading

eVoloshchak commented Jun 11, 2025 •

edited

Loading