[No QA] bump fast-equals#62890
Conversation
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
|
@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
|
|
Maybe some basic smoke tests would be good here? |
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
|
@eVoloshchak @roryabraham, I’ve added the tests. Could you please take a look? |
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/roryabraham in version: 9.1.60-1 🚀
|
|
🚀 Deployed to production by https://github.com/roryabraham in version: 9.1.61-0 🚀
|
|
🚀 Deployed to staging by https://github.com/roryabraham in version: 9.1.62-0 🚀
|
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.1.62-0 🚀
|
Explanation of Change
Fixed Issues
$ #61751
PROPOSAL:
Tests
N/A - Library update
Verify that no errors appear in the JS console
Offline tests
QA Steps
N/A - Library update
Verify that no errors appear in the JS console
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop