Fix logic of single transaction report by sumo-slonik · Pull Request #62936 · Expensify/App

sumo-slonik · 2025-05-28T10:49:17Z

Explanation of Change

The main reason for this issue was that we didn’t distinguish between the regular view and the single transaction view. The single transaction view displays not only messages from the thread but also from the entire report, which is why the timestamp of the last read report action was missing. Fixing the chat bubble behavior to recognize whether it’s a single transaction or not helped resolve the problem.

Fixed Issues

$ #62579
PROPOSAL:

Tests

On desktop run using a narrow layout

Go to workspace chat.
Create Report > Submit an expense
Long press on the expense preview > Hold.
Enter reason and save it.
Tap on the expense preview to mark the hold messages as read.
Go to Reports.
Tap bookmark button.
Tap Expense Reports.
Tap on the report.
Tap app back button.

Chat bubble should be gray

Verify that no errors appear in the JS console

Offline tests

Unnesesary

QA Steps

Same as test

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Uploading Screen Recording 2025-05-28 at 15.52.45.mov…

Android: mWeb Chrome

Screen.Recording.2025-05-28.at.15.49.37.mov

iOS: Native

video.chat.bubble.mp4

iOS: mWeb Safari

Screen.Recording.2025-05-28.at.16.10.08.mov

MacOS: Chrome / Safari

Screen.Recording.2025-05-28.at.14.31.41.mov

MacOS: Desktop

Screen.Recording.2025-05-28.at.15.03.55.mov

…_when_readed # Conflicts: # src/components/TransactionItemRow/DataCells/ChatBubbleCell.tsx

melvin-bot · 2025-05-28T14:14:27Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

…_when_readed # Conflicts: # src/components/TransactionItemRow/index.tsx

DylanDylann · 2025-05-29T09:11:26Z

@sumo-slonik Please address the prettier check error

DylanDylann · 2025-05-31T07:59:29Z

This is on hold

trjExpensify · 2025-06-02T13:06:03Z

This is on hold

Added that to the title of the PR so it's clear to follow.

…_when_readed # Conflicts: # src/components/SelectionList/Search/ReportListItem.tsx # src/components/TransactionItemRow/index.tsx

sumo-slonik · 2025-06-09T06:40:35Z

@DylanDylann Would you be able to find a moment to do the review?? As we agreed here: https://swmansion.slack.com/archives/C07NMDKEFMH/p1749215252537869?thread_ts=1748968053.487999&cid=C07NMDKEFMH

DylanDylann · 2025-06-09T06:44:02Z

On my list today

DylanDylann · 2025-06-09T07:26:45Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

DylanDylann

LGTM

mountiny · 2025-06-10T23:56:14Z

@youssef-lr bump

sumo-slonik · 2025-06-12T13:10:13Z

@youssef-lr @mountiny When might we find a moment to check and merge this?

mountiny

Moving this ahead

OSBotify · 2025-06-12T15:40:14Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-06-12T22:36:47Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.66-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-06-16T10:58:07Z

🚀 Deployed to production by https://github.com/lakchote in version: 9.1.66-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

github-actions · 2025-06-16T15:53:51Z

🚀 Deployed to production by https://github.com/lakchote in version: 9.1.66-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	failure ❌

github-actions · 2025-06-16T16:14:32Z

🚀 Deployed to production by https://github.com/lakchote in version: 9.1.66-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

sumo-slonik added 3 commits May 28, 2025 12:46

fix logic of single transaction report

4053188

Merge branch 'main' into bugfix/kuba_nowakowski/make_chatbubbgle_gray…

556e46f

…_when_readed # Conflicts: # src/components/TransactionItemRow/DataCells/ChatBubbleCell.tsx

fix dependency array

2590f16

sumo-slonik marked this pull request as ready for review May 28, 2025 14:14

sumo-slonik requested a review from a team as a code owner May 28, 2025 14:14

melvin-bot Bot requested a review from DylanDylann May 28, 2025 14:14

melvin-bot Bot removed the request for review from a team May 28, 2025 14:14

Merge branch 'main' into bugfix/kuba_nowakowski/make_chatbubbgle_gray…

ed214f0

…_when_readed # Conflicts: # src/components/TransactionItemRow/index.tsx

fix prettier

0541e2d

trjExpensify changed the title ~~fix logic of single transaction report~~ [Hold #63024] fix logic of single transaction report Jun 2, 2025

sumo-slonik added 2 commits June 6, 2025 14:26

Merge branch 'main' into bugfix/kuba_nowakowski/make_chatbubbgle_gray…

fc48bf3

…_when_readed # Conflicts: # src/components/SelectionList/Search/ReportListItem.tsx # src/components/TransactionItemRow/index.tsx

fix printer

b1af887

mountiny assigned sumo-slonik Jun 6, 2025

mountiny changed the title ~~[Hold #63024] fix logic of single transaction report~~ Fix logic of single transaction report Jun 6, 2025

mountiny self-assigned this Jun 6, 2025

DylanDylann approved these changes Jun 9, 2025

View reviewed changes

melvin-bot Bot requested a review from youssef-lr June 9, 2025 07:49

mountiny removed their assignment Jun 10, 2025

mountiny approved these changes Jun 12, 2025

View reviewed changes

mountiny merged commit ad88724 into Expensify:main Jun 12, 2025
19 checks passed

github-actions Bot mentioned this pull request Jun 12, 2025

Deploy Checklist: New Expensify 2025-06-12 #64109

Closed

44 tasks

melvin-bot Bot mentioned this pull request Jun 16, 2025

[Due for payment 2025-06-23] [Better Expense Report View] [$250] Chat bubble is always green in the expense preview when hold messages are read #62579

Closed

8 tasks

Conversation

sumo-slonik commented May 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented May 28, 2025

Uh oh!

DylanDylann commented May 29, 2025

Uh oh!

DylanDylann commented May 31, 2025

Uh oh!

trjExpensify commented Jun 2, 2025

Uh oh!

sumo-slonik commented Jun 9, 2025

Uh oh!

DylanDylann commented Jun 9, 2025

Uh oh!

DylanDylann commented Jun 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

DylanDylann left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny commented Jun 10, 2025

Uh oh!

sumo-slonik commented Jun 12, 2025

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Jun 12, 2025

Uh oh!

github-actions Bot commented Jun 12, 2025

Uh oh!

github-actions Bot commented Jun 16, 2025

Uh oh!

github-actions Bot commented Jun 16, 2025

Uh oh!

github-actions Bot commented Jun 16, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

sumo-slonik commented May 28, 2025 •

edited

Loading

DylanDylann commented Jun 9, 2025 •

edited

Loading