fix: Workspace chats not showing up in search by chrispader · Pull Request #62942 · Expensify/App

chrispader · 2025-05-28T12:25:50Z

Explanation of Change

This PR fixes an issue where workspace chats are not shown in the search because of two reasons:

For workspace chats, we were not checking for the alternateText, which includes the workspace name
In the FastSearch implementation we initially just filter the options by the longest word, after which we filter again by the whole search string. This was previously only limited to the text property of every option.

This PR introduces some extra logic to FastSearch to allow for performantly storing the used search strings in memory and then later using the stored searchableString to filter in the second round instead of just filtering by text.

Fixed Issues

$ #62407
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Open search
Start searching for the name of a workspace or workspace chat.
Once you enter a space ( ), make sure that the workspace chat either shows up or does not dissapear, if it was already visible.

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2025-05-28.at.14.28.37.mov

MacOS: Desktop

melvin-bot · 2025-05-28T12:26:21Z

@lakchote Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ishpaul777 · 2025-05-29T08:37:30Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-05-30.at.4.51.53.PM.mov

Android: mWeb Chrome

Screen.Recording.2025-05-29.at.2.55.57.PM.mov

iOS: HybridApp

Screen.Recording.2025-05-29.at.2.42.01.PM.mov

iOS: mWeb Safari

Screen.Recording.2025-05-29.at.2.43.05.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2025-05-29.at.2.49.11.PM.mov

Screen.Recording.2025-05-29.at.1.44.52.PM.mov

MacOS: Desktop

Screen.Recording.2025-05-29.at.2.49.11.PM.mov

github-actions · 2025-05-29T08:54:30Z

🚧 @lakchote has triggered a test app build. You can view the workflow run here.

lakchote · 2025-05-29T08:54:51Z

@chrispader prettier is failing

chrispader · 2025-05-29T08:57:55Z

@chrispader prettier is failing

fixed! 🙌🏼

…n-search

ishpaul777 · 2025-05-29T09:50:07Z

searching for the name of a workspace does not show the workspace chat @chrispader

(happens with adhoc build only, locally its works)

Screen.Recording.2025-05-29.at.3.15.36.PM.mov

chrispader · 2025-05-29T14:21:42Z

searching for the name of a workspace does not show the workspace chat @chrispader

(happens with adhoc build only, locally its works)

@ishpaul777 i think i could repro and fix this issue.

@lakchote could you please trigger another ad-hoc build?

github-actions · 2025-05-29T19:48:15Z

🚧 @lakchote has triggered a test app build. You can view the workflow run here.

github-actions · 2025-05-29T20:20:14Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
Android 🤖🔄	iOS 🍎🔄
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/62942-hybrid/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/62942-hybrid/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/62942/NewExpensify.dmg	https://62942.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

ishpaul777

LGTM!

lakchote · 2025-06-02T12:44:28Z

@chrispader there are conflicts, when it's done I'll merge this, thanks!

…n-search

chrispader · 2025-06-02T18:51:02Z

@lakchote just merged main!

ishpaul777 · 2025-06-03T22:49:00Z

Perf. tests failing, @chrispader can you please take a look if its related

…n-search

chrispader · 2025-06-05T13:38:49Z

Perf. tests failing, @chrispader can you please take a look if its related

@ishpaul777 perf tests were not related. Just merged main and it's passing now.

@lakchote this should be ready to merge!

chrispader · 2025-06-11T13:46:21Z

@lakchote can we merge this? 🙌🏼

lakchote · 2025-06-12T08:57:40Z

Oops, sorry @chrispader I thought I had merged it!

Done!

github-actions · 2025-06-12T22:36:50Z

🚀 Deployed to staging by https://github.com/lakchote in version: 9.1.66-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-06-16T10:58:10Z

🚀 Deployed to production by https://github.com/lakchote in version: 9.1.66-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

github-actions · 2025-06-16T15:53:54Z

🚀 Deployed to production by https://github.com/lakchote in version: 9.1.66-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	failure ❌

github-actions · 2025-06-16T16:14:35Z

🚀 Deployed to production by https://github.com/lakchote in version: 9.1.66-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

chrispader added 3 commits May 28, 2025 14:02

fix: allow searching for more than just text of report

0e14f14

fix: make sure option id is unique

8a8e68e

feat: add option flag for FastSearch store searchable strings

29b2f8c

chrispader requested a review from a team as a code owner May 28, 2025 12:25

chrispader mentioned this pull request May 28, 2025

[Due for payment 2025-06-23] Workspace chat not coming up in the Inbox search result #62407

Closed

16 tasks

melvin-bot Bot requested review from lakchote and removed request for a team May 28, 2025 12:26

chrispader added 4 commits May 28, 2025 17:55

fix: enable the option for the new logic

0fe40c5

improve tests

788648f

fix: prettier

066f0bb

fix: prettier

a446e79

lakchote requested a review from ishpaul777 May 29, 2025 07:16

fix: prettier

9a04143

Merge branch 'main' into @chrispader/fix-workspace-chat-not-showing-i…

76f11f8

…n-search

This comment has been minimized.

Sign in to view

fix: add policy name to report options

ae75254

ishpaul777 approved these changes May 30, 2025

View reviewed changes

lakchote previously approved these changes Jun 2, 2025

View reviewed changes

Merge branch 'main' into @chrispader/fix-workspace-chat-not-showing-i…

658933d

…n-search

chrispader dismissed lakchote’s stale review via 658933d June 2, 2025 18:49

Merge branch 'main' into @chrispader/fix-workspace-chat-not-showing-i…

3fb13e3

…n-search

lakchote approved these changes Jun 5, 2025

View reviewed changes

lakchote merged commit c449e00 into Expensify:main Jun 12, 2025
17 checks passed

github-actions Bot mentioned this pull request Jun 12, 2025

Deploy Checklist: New Expensify 2025-06-12 #64109

Closed

44 tasks

Conversation

chrispader commented May 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented May 28, 2025

Uh oh!

ishpaul777 commented May 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

github-actions Bot commented May 29, 2025

Uh oh!

lakchote commented May 29, 2025

Uh oh!

chrispader commented May 29, 2025

Uh oh!

This comment has been minimized.

ishpaul777 commented May 29, 2025

Uh oh!

chrispader commented May 29, 2025

Uh oh!

github-actions Bot commented May 29, 2025

Uh oh!

github-actions Bot commented May 29, 2025

Uh oh!

ishpaul777 left a comment

Choose a reason for hiding this comment

Uh oh!

lakchote commented Jun 2, 2025

Uh oh!

chrispader commented Jun 2, 2025

Uh oh!

ishpaul777 commented Jun 3, 2025

Uh oh!

chrispader commented Jun 5, 2025

Uh oh!

chrispader commented Jun 11, 2025

Uh oh!

lakchote commented Jun 12, 2025

Uh oh!

Uh oh!

github-actions Bot commented Jun 12, 2025

Uh oh!

github-actions Bot commented Jun 16, 2025

Uh oh!

github-actions Bot commented Jun 16, 2025

Uh oh!

github-actions Bot commented Jun 16, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

chrispader commented May 28, 2025 •

edited

Loading

ishpaul777 commented May 29, 2025 •

edited

Loading