[NO QA] Display the AgentZeroProcessingRequestIndicator#63108
Merged
Conversation
AgentZeroProcessingRequestIndicator
…ProcessingRequestIndicator
thienlnam
previously approved these changes
May 30, 2025
AgentZeroProcessingRequestIndicatorAgentZeroProcessingRequestIndicator
Contributor
|
Need to hold until we have AZ out of NOOP mode |
rlinoz
previously approved these changes
Jun 2, 2025
Contributor
rlinoz
left a comment
There was a problem hiding this comment.
Code looks good!
Should the updated category message show after the "concierge is thinking" indicator is dismissed? And if so, are we gonna handle that in another PR as this will be behind a beta?
AgentZeroProcessingRequestIndicatorAgentZeroProcessingRequestIndicator
thienlnam
approved these changes
Jun 12, 2025
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
AgentZeroProcessingRequestIndicatorAgentZeroProcessingRequestIndicator
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
44 tasks
Contributor
|
🚀 Deployed to staging by https://github.com/jasperhuangg in version: 9.1.66-0 🚀
|
51 tasks
8 tasks
Contributor
|
🚀 Deployed to production by https://github.com/lakchote in version: 9.1.66-5 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/lakchote in version: 9.1.66-5 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/lakchote in version: 9.1.66-5 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Fixed Issues
Part of https://github.com/Expensify/Expensify/issues/504242
PROPOSAL:
Tests
Need https://github.com/Expensify/Web-Expensify/pull/46976 and https://github.com/Expensify/Auth/pull/15533
Have BWM running, and Auth set up with OpenAI creds
Screen.Recording.2025-05-30.at.4.36.12.PM.mov
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps./** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop