Skip to content

Conditionally show/hide columns#63501

Merged
youssef-lr merged 77 commits intomainfrom
youssef_auto_show_hide_columns
Jul 31, 2025
Merged

Conditionally show/hide columns#63501
youssef-lr merged 77 commits intomainfrom
youssef_auto_show_hide_columns

Conversation

@youssef-lr
Copy link
Copy Markdown
Contributor

@youssef-lr youssef-lr commented Jun 4, 2025 •
edited
Loading

Explanation of Change

Fixed Issues

$ #45450

Tests

  • Verify that no errors appear in the JS console
  1. Test that if all transactions are from the current user, we only show the "To" column
  2. Test that if all transactions are submitted to the current user, we only show the "From" column
  3. Test that we only show merchant, description, category, or tag columns only if at least one transaction has them set.
  4. Test that when we fetch new transactions with different columns a clean fadeOut/fadeIn happen.
  5. Verify these steps in the Reports groupBy as well.

Offline tests

N/A

QA Steps

  • Verify that no errors appear in the JS console
  1. Test that if all transactions are from the current user, we only show the "To" column
  2. Test that if all transactions are submitted to the current user, we only show the "From" column
  3. Test that we only show merchant, description, category, or tag columns only if at least one transaction has them set.
  4. Test that when we fetch new transactions with different columns a clean fadeOut/fadeIn happen.
  5. Verify these steps in the Reports groupBy as well.

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop

@youssef-lr youssef-lr changed the title Auto hide from/to columns Conditionally show/hide columns Jun 4, 2025
@youssef-lr youssef-lr self-assigned this Jun 30, 2025
@youssef-lr
Copy link
Copy Markdown
Contributor Author

youssef-lr commented Jun 30, 2025

@shawnborton all functionality is implemented except the fadein / fadeout until I figure out a glitch. I've kicked off a test build.

@github-actions

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 1, 2025

🚧 @shawnborton has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 1, 2025

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #63501.

Android 🤖 iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/63501/index.html https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/63501/index.html
Android iOS
Desktop 💻 Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/63501/NewExpensify.dmg https://63501.pr-testing.expensify.com
Desktop Web

👀 View the workflow run that generated this build 👀

@youssef-lr
Copy link
Copy Markdown
Contributor Author

youssef-lr commented Jul 1, 2025 •
edited
Loading

@shawnborton just noticed a bug related to the description column with my production data, it's not showing for me on dev. Will investigate it as soon as I'm back from dr appointment in a couple of hours.

image

edit: I know what's the cause, will fix when I'm back

@shawnborton
Copy link
Copy Markdown
Contributor

shawnborton commented Jul 1, 2025

Ah sounds good, I will wait for your fix before I start testing this then. Let me know when it's ready to run another test build.

@youssef-lr
Copy link
Copy Markdown
Contributor Author

youssef-lr commented Jul 1, 2025

Fixed @shawnborton

@shawnborton
Copy link
Copy Markdown
Contributor

shawnborton commented Jul 1, 2025

Great, will run another one.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 1, 2025

🚧 @shawnborton has triggered a test Expensify/App build. You can view the workflow run here.

@youssef-lr youssef-lr dismissed stale reviews from luacmartins and lakchote via af94c93 July 31, 2025 17:34
@youssef-lr youssef-lr merged commit 7ba0f03 into main Jul 31, 2025
24 checks passed
@youssef-lr youssef-lr deleted the youssef_auto_show_hide_columns branch July 31, 2025 17:47
@OSBotify
Copy link
Copy Markdown
Contributor

OSBotify commented Jul 31, 2025

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions github-actions Bot mentioned this pull request Aug 4, 2025
Closed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 4, 2025

🚀 Deployed to staging by https://github.com/youssef-lr in version: 9.1.89-1 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@chuckdries chuckdries mentioned this pull request Aug 4, 2025
Closed
8 tasks
@mitarachim mitarachim mentioned this pull request Aug 5, 2025
Closed
8 tasks
@youssef-lr youssef-lr mentioned this pull request Aug 5, 2025
Closed
8 tasks
This was referenced Aug 5, 2025
Closed
Closed
Closed
@MonilBhavsar
Copy link
Copy Markdown
Contributor

MonilBhavsar commented Aug 5, 2025

This PR likely caused #67834. If anyone can please take a look

@shawnborton
Copy link
Copy Markdown
Contributor

shawnborton commented Aug 5, 2025

cc @youssef-lr - looks like there were a bunch of deploy blockers related to this feature. Can you take a look today?

@youssef-lr
Copy link
Copy Markdown
Contributor Author

youssef-lr commented Aug 5, 2025 via email

@puneetlath
Copy link
Copy Markdown
Contributor

puneetlath commented Aug 5, 2025

If there were many deploy blockers, I'd recommend just reverting and fixing the issues in your follow-up PR. That way it isn't rushed and unblocks the deploy.

@jasperhuangg
Copy link
Copy Markdown
Contributor

jasperhuangg commented Aug 5, 2025

@puneetlath Yeah agreed, let's revert this one

mountiny added a commit that referenced this pull request Aug 6, 2025
@mountiny
Revert "Merge pull request #63501 from Expensify/youssef_auto_show_hi…
b1d5847 
…de_columns"

This reverts commit 7ba0f03, reversing
changes made to c2f2ebf.
@mountiny mountiny mentioned this pull request Aug 6, 2025
Merged
51 tasks
@mountiny
Copy link
Copy Markdown
Contributor

mountiny commented Aug 6, 2025

Revert here #68017

mountiny added a commit that referenced this pull request Aug 6, 2025
@mountiny
Merge pull request #68017 from Expensify/vit-revert63501
d752e6a 
[CP Staging] Revert "Merge pull request #63501 from Expensify/youssef_auto_show_hide_columns"
ishpaul777 added a commit to ishpaul777/App that referenced this pull request Aug 6, 2025
@ishpaul777
Revert "[CP Staging] Revert "Merge pull request Expensify#63501 from …
287bac1 
…Expensify/youssef_auto_show_hide_columns""
mountiny added a commit that referenced this pull request Aug 6, 2025
@mountiny
Merge pull request #68017 from Expensify/vit-revert63501
2172c7e 
[CP Staging] Revert "Merge pull request #63501 from Expensify/youssef_auto_show_hide_columns"

(cherry picked from commit d752e6a)

(cherry-picked to staging by mountiny)
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 6, 2025

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.1.89-21 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

@melvin-bot melvin-bot Bot mentioned this pull request Aug 6, 2025
Closed
Julesssss added a commit that referenced this pull request Aug 6, 2025
@Julesssss
Merge branch 'main' into jules-addMobilePRsToChecklist
54818b7 
* main: (1052 commits)
  Update Mobile-Expensify submodule version to 9.1.90-0
  Update version to 9.1.90-0
  chore
  chore
  update package.json
  Update Mobile-Expensify submodule version to 9.1.89-21
  Update version to 9.1.89-21
  fix typo in variable name
  Fix Prettier
  Fix TS
  Fix duplicate migrated user modal
  Update Mobile-Expensify submodule version to 9.1.89-20
  Update version to 9.1.89-20
  Revert "Merge pull request #67817 from Expensify/youssef_fix_description_html"
  Fix one more conflict
  Revert "Merge pull request #63501 from Expensify/youssef_auto_show_hide_columns"
  Update Mobile-Expensify submodule version to 9.1.89-19
  Update version to 9.1.89-19
  Update Mobile-Expensify submodule version to 9.1.89-18
  Update version to 9.1.89-18
  ...
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 6, 2025

🚀 Deployed to staging by https://github.com/youssef-lr in version: 9.1.90-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 8, 2025

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.1.90-11 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@puneetlath puneetlath puneetlath approved these changes

@lakchote lakchote lakchote left review comments

@luacmartins luacmartins luacmartins left review comments

+1 more reviewer

@ishpaul777 ishpaul777 ishpaul777 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@youssef-lr youssef-lr

Labels

Ready To Build

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.