Vacation delegate - add fallback login for non existent users by rushatgabhane · Pull Request #64869 · Expensify/App

rushatgabhane · 2025-06-25T01:50:48Z

Explanation of Change

Fixed Issues

$ #64864
$ #64885
$ #64884
PROPOSAL:

Tests

Go to Account > Status.
Click Vacation delegate.
Enter non-existing user email and select it.
Click app back button.
Verify that the email of non-existing user should appear next to the avatar in Status page, and you see an error.

User on workspace

Go to Settings > Profile > Status
Click on the "Vacation delegate" section
Search for and select a user
verify that user is navigated back to status page

Verify that no errors appear in the JS console

Offline tests

QA Steps

same as QA

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

WhatsApp.Video.2025-06-25.at.19.01.04.mp4

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

invalid

valid

MacOS: Desktop

melvin-bot · 2025-06-25T01:50:53Z

@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ZhenjaHorbach · 2025-06-25T05:53:43Z

@rushatgabhane
Do you need help with a review ?

rushatgabhane · 2025-06-25T08:53:51Z

@deetergp all yours!

rushatgabhane · 2025-06-25T08:54:35Z

@eh2077 as assigned c+

eh2077 · 2025-06-25T14:26:09Z

~~Reviewer Checklist~~ (internal employee doing checklist below)

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2025-06-25.at.11.32.10.PM.mov

MacOS: Desktop

Screen.Recording.2025-06-25.at.11.37.12.PM.mov

eh2077 · 2025-06-25T15:05:49Z

User is not navigated back if select a user who is on vacation as the delegate

Screen.Recording.2025-06-25.at.11.03.21.PM.mov

rushatgabhane · 2025-06-25T15:22:03Z

@eh2077 fixed!

eh2077 · 2025-06-25T15:28:32Z

@rushatgabhane User isn't navigated back if select a non-existing user

Screen.Recording.2025-06-25.at.11.26.57.PM.mov

eh2077 · 2025-06-25T15:30:13Z

Ok, the above bug was just fixed by latest commits!

eh2077 · 2025-06-25T15:34:43Z

@rushatgabhane Can you please add missing recordings / screenshots? Thanks

eh2077 · 2025-06-25T15:44:06Z

Mobile Chrome - delegate is not shown selection list

Screen.Recording.2025-06-25.at.11.41.49.PM.mov

eh2077 · 2025-06-25T15:48:47Z

I have completed testing on desktop and web chrome.

I'm wrapping up for the day now. I'm happy to pick this up first thing tomorrow, but if it's urgent, feel free to reassign.

cc @rushatgabhane @deetergp

rushatgabhane · 2025-06-25T16:51:12Z

Mobile Chrome - delegate is not shown selection list

umm, let me check

rushatgabhane · 2025-06-25T17:02:52Z

Mobile Chrome - delegate is not shown selection list

Not a bug. You don't see it selected because it is not a real user.
You can dismiss the error to clear the user

WhatsApp.Video.2025-06-25.at.19.01.04.mp4

I tried your user too!

WhatsApp.Video.2025-06-25.at.19.07.54.mp4

luacmartins · 2025-06-25T17:46:32Z

@rushatgabhane while testing this, I still see the old vacation delegate (the one that was removed from the workspace) as the vacation delegate of the user. Is that expected?

rushatgabhane · 2025-06-25T18:13:06Z

@luacmartins yes it is expected! a vacation delegate is not tied to a workspace

to confirm, you can visit oldDot and see if that user is set as vacation delegate

luacmartins

LGTM

Beamanator

Looking good, @eh2077 are you still working on the checklist?

rushatgabhane · 2025-06-25T19:31:10Z

@eh2077 is off #64869 (comment)

Beamanator · 2025-06-25T19:34:51Z

aah good call! well yes this is urgent b/c it fixes multiple deploy blockers :D

Beamanator · 2025-06-25T19:59:35Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

See #64869 (comment)

MacOS: Desktop

See #64869 (comment)

Vacation delegate - add fallback login for non existent users (cherry picked from commit e2476e4) (cherry-picked to staging by chiragsalian)

OSBotify · 2025-06-25T20:13:27Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-06-25T20:45:17Z

🚀 Cherry-picked to staging by https://github.com/chiragsalian in version: 9.1.71-6 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

github-actions · 2025-06-27T23:14:07Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 9.1.71-11 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

add fallback login for non existent users

98e70aa

rushatgabhane requested a review from a team as a code owner June 25, 2025 01:50

melvin-bot Bot requested a review from ZhenjaHorbach June 25, 2025 01:50

melvin-bot Bot removed the request for review from a team June 25, 2025 01:50

rushatgabhane mentioned this pull request Jun 25, 2025

[Due for payment 2025-08-13] [Due for payment 2025-07-04] [$250] Vacation delegate - Email of non-existing user is missing next to the avatar in Status page #64864

Closed

8 tasks

rushatgabhane added 2 commits June 25, 2025 10:59

Merge branch 'Expensify:main' into fix-64864

5c3ddeb

navigate on success

cd3c7e8

roryabraham requested review from eh2077 and removed request for ZhenjaHorbach June 25, 2025 15:16

add robust err handlind

81684d9

roryabraham mentioned this pull request Jun 25, 2025

Deploy Checklist: New Expensify 2025-06-24 #64820

Closed

rushatgabhane mentioned this pull request Jun 25, 2025

[Due for payment 2025-07-04] [$250] User Settings-Empty place on Vacation delegate push input after the member is removed #64884

Closed

8 tasks

luacmartins assigned rushatgabhane Jun 25, 2025

luacmartins approved these changes Jun 25, 2025

View reviewed changes

Beamanator approved these changes Jun 25, 2025

View reviewed changes

Beamanator merged commit e2476e4 into Expensify:main Jun 25, 2025
21 of 24 checks passed

OSBotify pushed a commit that referenced this pull request Jun 25, 2025

Merge pull request #64869 from rushatgabhane/fix-64864

7a91f7d

Vacation delegate - add fallback login for non existent users (cherry picked from commit e2476e4) (cherry-picked to staging by chiragsalian)

OSBotify added the CP Staging marks PRs that have been CP'd to staging label Jun 25, 2025

carlosmiceli mentioned this pull request Jun 25, 2025

[$250] Vacation delegate - "You:approved" is shown in Admin's when the report approved by delegate #64969

Closed

8 tasks

jponikarchuk mentioned this pull request Jun 26, 2025

Error when assigning a user who already has a vacation delegate as your own delegate #65045

Closed

8 tasks

melvin-bot Bot mentioned this pull request Jun 27, 2025

[Due for payment 2025-07-04] [$250] Vacation delegate - User is not navigated back to status page after assigning a delegate #64885

Closed

8 tasks

Conversation

rushatgabhane commented Jun 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

User on workspace

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

invalid

valid

Uh oh!

melvin-bot Bot commented Jun 25, 2025

Uh oh!

ZhenjaHorbach commented Jun 25, 2025

Uh oh!

rushatgabhane commented Jun 25, 2025

Uh oh!

rushatgabhane commented Jun 25, 2025

Uh oh!

eh2077 commented Jun 25, 2025 • edited by Beamanator Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Screenshots/Videos

Uh oh!

eh2077 commented Jun 25, 2025

Uh oh!

rushatgabhane commented Jun 25, 2025

Uh oh!

eh2077 commented Jun 25, 2025

Uh oh!

eh2077 commented Jun 25, 2025

Uh oh!

eh2077 commented Jun 25, 2025

Uh oh!

eh2077 commented Jun 25, 2025

Uh oh!

eh2077 commented Jun 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rushatgabhane commented Jun 25, 2025

Uh oh!

rushatgabhane commented Jun 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

luacmartins commented Jun 25, 2025

Uh oh!

rushatgabhane commented Jun 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

luacmartins left a comment

Choose a reason for hiding this comment

Uh oh!

Beamanator left a comment

Choose a reason for hiding this comment

Uh oh!

rushatgabhane commented Jun 25, 2025

Uh oh!

Beamanator commented Jun 25, 2025

Uh oh!

Beamanator commented Jun 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

OSBotify commented Jun 25, 2025

Uh oh!

github-actions Bot commented Jun 25, 2025

Uh oh!

github-actions Bot commented Jun 27, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

rushatgabhane commented Jun 25, 2025 •

edited

Loading

eh2077 commented Jun 25, 2025 •

edited by Beamanator

Loading

eh2077 commented Jun 25, 2025 •

edited

Loading

rushatgabhane commented Jun 25, 2025 •

edited

Loading

rushatgabhane commented Jun 25, 2025 •

edited

Loading

Beamanator commented Jun 25, 2025 •

edited

Loading