fix: cards filter with old ui by linhvovan29546 · Pull Request #65235 · Expensify/App

linhvovan29546 · 2025-07-01T08:41:54Z

Explanation of Change

Fixed Issues

Tests

Open ND
Run console code

Onyx

Onyx.merge('cardList', {
    '12345': {
        cardID: 12345,
        accountID: 1,
        bank: 'Expensify Card',
        domainName: 'test-domain.exfy',
        lastFourPAN: '1234',
        cardName: '455594XXXXXX1234',
        nameValuePairs: {
            cardTitle: 'John Doe Card',
            isVirtual: false,
        },
        state: 3,
        fraud: 'none',
        lastUpdated: '2025-01-01',
    },
    '12346': {
        cardID: 12346,
        accountID: 2,
        bank: 'Expensify Card',
        domainName: 'test-domain.exfy',
        lastFourPAN: '5678',
        cardName: '455594XXXXXX5678',
        nameValuePairs: {
            cardTitle: 'Jane Smith Card',
            isVirtual: true,
        },
        state: 3,
        fraud: 'none',
        lastUpdated: '2025-01-01',
    },
    '12347': {
        cardID: 12347,
        accountID: 3,
        bank: 'Expensify Card',
        domainName: 'workspace-test.exfy',
        lastFourPAN: '1111',
        cardName: '455594XXXXXX1111',
        nameValuePairs: {
            cardTitle: 'Alice Lee Card',
            isVirtual: false,
        },
        state: 3,
        fraud: 'none',
        lastUpdated: '2025-02-01',
    },
    '12348': {
        cardID: 12348,
        accountID: 4,
        bank: 'Expensify Card',
        domainName: 'workspace-test.exfy',
        lastFourPAN: '2222',
        cardName: '455594XXXXXX2222',
        nameValuePairs: {
            cardTitle: 'Bob Brown Card',
            isVirtual: true,
        },
        state: 2,
        fraud: 'none',
        lastUpdated: '2025-02-05',
    },
    '12349': {
        cardID: 12349,
        accountID: 5,
        bank: 'Expensify Card',
        domainName: 'alpha-domain.exfy',
        lastFourPAN: '3333',
        cardName: '455594XXXXXX3333',
        nameValuePairs: {
            cardTitle: 'Charlie Davis Card',
            isVirtual: false,
        },
        state: 1,
        fraud: 'suspected',
        lastUpdated: '2025-03-01',
    },
    '12350': {
        cardID: 12350,
        accountID: 6,
        bank: 'Expensify Card',
        domainName: 'beta-domain.exfy',
        lastFourPAN: '4444',
        cardName: '455594XXXXXX4444',
        nameValuePairs: {
            cardTitle: 'Diana Evans Card',
            isVirtual: true,
        },
        state: 3,
        fraud: 'none',
        lastUpdated: '2025-03-10',
    },
    '12351': {
        cardID: 12351,
        accountID: 7,
        bank: 'Expensify Card',
        domainName: 'gamma-domain.exfy',
        lastFourPAN: '5555',
        cardName: '455594XXXXXX5555',
        nameValuePairs: {
            cardTitle: 'Ethan Foster Card',
            isVirtual: false,
        },
        state: 4,
        fraud: 'none',
        lastUpdated: '2025-03-20',
    },
    '12352': {
        cardID: 12352,
        accountID: 8,
        bank: 'Expensify Card',
        domainName: 'delta-domain.exfy',
        lastFourPAN: '6666',
        cardName: '455594XXXXXX6666',
        nameValuePairs: {
            cardTitle: 'Fiona Green Card',
            isVirtual: true,
        },
        state: 3,
        fraud: 'investigation',
        lastUpdated: '2025-04-01',
    },
    '12353': {
        cardID: 12353,
        accountID: 9,
        bank: 'Expensify Card',
        domainName: 'epsilon-domain.exfy',
        lastFourPAN: '7777',
        cardName: '455594XXXXXX7777',
        nameValuePairs: {
            cardTitle: 'George Hill Card',
            isVirtual: false,
        },
        state: 1,
        fraud: 'none',
        lastUpdated: '2025-04-05',
    },
    '12354': {
        cardID: 12354,
        accountID: 10,
        bank: 'Expensify Card',
        domainName: 'zeta-domain.exfy',
        lastFourPAN: '8888',
        cardName: '455594XXXXXX8888',
        nameValuePairs: {
            cardTitle: 'Hannah Irwin Card',
            isVirtual: true,
        },
        state: 2,
        fraud: 'none',
        lastUpdated: '2025-04-10',
    },
    '12355': {
        cardID: 12355,
        accountID: 11,
        bank: 'Expensify Card',
        domainName: 'theta-domain.exfy',
        lastFourPAN: '9999',
        cardName: '455594XXXXXX9999',
        nameValuePairs: {
            cardTitle: 'Isaac Johnson Card',
            isVirtual: false,
        },
        state: 3,
        fraud: 'none',
        lastUpdated: '2025-04-15',
    },
    '12356': {
        cardID: 12356,
        accountID: 12,
        bank: 'Expensify Card',
        domainName: 'iota-domain.exfy',
        lastFourPAN: '0001',
        cardName: '455594XXXXXX0001',
        nameValuePairs: {
            cardTitle: 'Jenna King Card',
            isVirtual: true,
        },
        state: 3,
        fraud: 'none',
        lastUpdated: '2025-04-20',
    },
    '12357': {
        cardID: 12357,
        accountID: 13,
        bank: 'Expensify Card',
        domainName: 'kappa-domain.exfy',
        lastFourPAN: '0002',
        cardName: '455594XXXXXX0002',
        nameValuePairs: {
            cardTitle: 'Kevin Lee Card',
            isVirtual: false,
        },
        state: 3,
        fraud: 'none',
        lastUpdated: '2025-05-01',
    },
    '12358': {
        cardID: 12358,
        accountID: 14,
        bank: 'Expensify Card',
        domainName: 'lambda-domain.exfy',
        lastFourPAN: '0003',
        cardName: '455594XXXXXX0003',
        nameValuePairs: {
            cardTitle: 'Linda Moore Card',
            isVirtual: true,
        },
        state: 1,
        fraud: 'none',
        lastUpdated: '2025-05-10',
    },
    '12359': {
        cardID: 12359,
        accountID: 15,
        bank: 'Expensify Card',
        domainName: 'mu-domain.exfy',
        lastFourPAN: '0004',
        cardName: '455594XXXXXX0004',
        nameValuePairs: {
            cardTitle: 'Michael Nguyen Card',
            isVirtual: false,
        },
        state: 3,
        fraud: 'none',
        lastUpdated: '2025-05-15',
    }
});
Onyx.merge('cards_18755165_Expensify Card',  {
        '12347': {
            accountID: 3,
            bank: 'Expensify Card',
            fundID: '18755165',
            cardID: 12347,
            cardName: '455594XXXXXX9999',
            domainName: 'workspace-test-very-very-long.exfy',
            lastFourPAN: '9999',
            nameValuePairs: {
                cardTitle: 'Team Card 1',
            },
            state: 3, // OPEN
            fraud: 'none',
            lastUpdated: '2025-01-01',
        },
        '12348': {
            accountID: 4,
            bank: 'Expensify Card',
            fundID: '18755165',
            cardID: 12348,
            cardName: '455594XXXXXX8888',
            domainName: 'workspace-test.exfy',
            lastFourPAN: '8888',
            nameValuePairs: {
                cardTitle: 'Team Card 2',
            },
            state: 3, // OPEN
            fraud: 'none',
            lastUpdated: '2025-01-01',
        },
    });

Open search/filters/card page
Verify the Card UI has square checkboxes and Reset button

Verify that no errors appear in the JS console

Offline tests

Same as test above

QA Steps

Precondition: Use account with several cards.

Go to Reports
Click on Filters
Choose Card
Verify the Card UI has square checkboxes and Reset button

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2025-07-01.at.15.07.34.mov

MacOS: Desktop

Screen.Recording.2025-07-01.at.15.11.47.mov

linhvovan29546 · 2025-07-01T08:53:59Z

The unit test is flaky. This also occurs on the main.

melvin-bot · 2025-07-01T08:57:05Z

@c3024 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

c3024 · 2025-07-01T12:27:11Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

checkAndroid.mov

Android: mWeb Chrome

checkAndroidmWeb.mov

iOS: HybridApp

checkiOS.mov

iOS: mWeb Safari

checkiOSmWeb.mov

MacOS: Chrome / Safari

checkChrome.mov

MacOS: Desktop

checkDesktop.mov

c3024

LGTM!

c3024 · 2025-07-01T12:30:33Z

@linhvovan29546

Try merging main again. The check will run again and the test failure might get fixed.

linhvovan29546 · 2025-07-01T12:45:10Z

All tests passed.

MarioExpensify

Awesome, thank you for the quick PR @linhvovan29546. Let's move forward!

OSBotify · 2025-07-02T03:02:43Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-07-03T19:46:04Z

🚀 Deployed to staging by https://github.com/MarioExpensify in version: 9.1.75-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	cancelled 🔪
🍎 iOS 🍎	success ✅

github-actions · 2025-07-07T10:57:43Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.1.76-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

fix: cards filter with old ui

3876e7e

linhvovan29546 commented Jul 1, 2025

View reviewed changes

Comment thread src/components/SelectionList/Search/CardListItem.tsx

linhvovan29546 marked this pull request as ready for review July 1, 2025 08:57

linhvovan29546 requested a review from a team as a code owner July 1, 2025 08:57

melvin-bot Bot requested a review from c3024 July 1, 2025 08:57

melvin-bot Bot removed the request for review from a team July 1, 2025 08:57

c3024 approved these changes Jul 1, 2025

View reviewed changes

melvin-bot Bot requested a review from MarioExpensify July 1, 2025 12:29

Merge branch 'Expensify:main' into fix/64976-cards-filter-with-old-ui

f1ec9fe

MarioExpensify approved these changes Jul 2, 2025

View reviewed changes

MarioExpensify merged commit 2846678 into Expensify:main Jul 2, 2025
18 checks passed

linhvovan29546 deleted the fix/64976-cards-filter-with-old-ui branch July 2, 2025 03:04

github-actions Bot mentioned this pull request Jul 3, 2025

Deploy Checklist: New Expensify 2025-07-03 #65447

Closed

63 tasks

mitarachim mentioned this pull request Jul 4, 2025

Some filter show circles and others show squares #65465

Closed

8 tasks

melvin-bot Bot mentioned this pull request Jul 7, 2025

[Due for payment 2025-07-14] [$250] Card - Card filter with old UI #64976

Closed

16 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: cards filter with old ui#65235

fix: cards filter with old ui#65235
MarioExpensify merged 2 commits intoExpensify:mainfrom
linhvovan29546:fix/64976-cards-filter-with-old-ui

linhvovan29546 commented Jul 1, 2025 •

edited

Loading

Uh oh!

Uh oh!

linhvovan29546 commented Jul 1, 2025

Uh oh!

melvin-bot Bot commented Jul 1, 2025

Uh oh!

c3024 commented Jul 1, 2025 •

edited

Loading

Uh oh!

c3024 left a comment

Uh oh!

c3024 commented Jul 1, 2025

Uh oh!

linhvovan29546 commented Jul 1, 2025

Uh oh!

MarioExpensify left a comment

Uh oh!

Uh oh!

OSBotify commented Jul 2, 2025

Uh oh!

github-actions Bot commented Jul 3, 2025

Uh oh!

github-actions Bot commented Jul 7, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

linhvovan29546 commented Jul 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

Uh oh!

linhvovan29546 commented Jul 1, 2025

Uh oh!

melvin-bot Bot commented Jul 1, 2025

Uh oh!

c3024 commented Jul 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

c3024 left a comment

Choose a reason for hiding this comment

Uh oh!

c3024 commented Jul 1, 2025

Uh oh!

linhvovan29546 commented Jul 1, 2025

Uh oh!

MarioExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Jul 2, 2025

Uh oh!

github-actions Bot commented Jul 3, 2025

Uh oh!

github-actions Bot commented Jul 7, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

linhvovan29546 commented Jul 1, 2025 •

edited

Loading

c3024 commented Jul 1, 2025 •

edited

Loading