Skip to content

[No QA] Revert "After deleting expense and returning to Chats messages display fallback avatar"#65300

Merged
cristipaval merged 1 commit intomainfrom
revert-64403-fix/63300
Jul 2, 2025
Merged

[No QA] Revert "After deleting expense and returning to Chats messages display fallback avatar"#65300
cristipaval merged 1 commit intomainfrom
revert-64403-fix/63300

Conversation

@cristipaval
Copy link
Copy Markdown
Contributor

Reverts #64403 because it adds an extra API call. Details here. We'll go with the other solution.

@cristipaval cristipaval self-assigned this Jul 2, 2025
@cristipaval cristipaval requested a review from a team as a code owner July 2, 2025 01:51
@melvin-bot melvin-bot Bot requested a review from Beamanator July 2, 2025 01:51
@melvin-bot
Copy link
Copy Markdown

melvin-bot Bot commented Jul 2, 2025

@Beamanator Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot Bot removed the request for review from a team July 2, 2025 01:51
@cristipaval cristipaval changed the title Revert "After deleting expense and returning to Chats messages display fallback avatar" [No QA] Revert "After deleting expense and returning to Chats messages display fallback avatar" Jul 2, 2025
Copy link
Copy Markdown
Contributor

@Beamanator Beamanator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving but will let you merge 😅

@cristipaval cristipaval merged commit b95a76e into main Jul 2, 2025
20 of 23 checks passed
@cristipaval cristipaval deleted the revert-64403-fix/63300 branch July 2, 2025 19:00
@melvin-bot melvin-bot Bot added the Emergency label Jul 2, 2025
@melvin-bot
Copy link
Copy Markdown

melvin-bot Bot commented Jul 2, 2025

@cristipaval looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@cristipaval
Copy link
Copy Markdown
Contributor Author

Straight revert

@OSBotify
Copy link
Copy Markdown
Contributor

OSBotify commented Jul 2, 2025

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 3, 2025

🚀 Deployed to staging by https://github.com/cristipaval in version: 9.1.75-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 cancelled 🔪
🍎 iOS 🍎 success ✅

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 7, 2025

🚀 Deployed to production by https://github.com/mountiny in version: 9.1.76-5 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants