Fix horizontal padding when opening a receipt while creating expenses with Multi-Scan by VickyStash · Pull Request #66889 · Expensify/App

VickyStash · 2025-07-22T14:17:32Z

Explanation of Change

Fix horizontal padding when opening a receipt while creating expenses with Multi-Scan.

Fixed Issues

$ #65251
PROPOSAL: #65251 (comment)

Tests

Verify that no errors appear in the JS console

Mobile/mWeb:

Global Create -> Create expense
On the Scan tab, enable the Multi-Scan
Take a few pictures in a row
Tap on a receipt from the bottom carousel with the receipt previews
Make sure the receipt has no extra horizontal padding

All platforms:

Open any report
Send a big-picture attachment (example)
After the attachment is uploaded, open the attachment
Verify that the high-resolution info text is displayed correctly

Offline tests

Same, as in the Tests section.

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

Same, as in the Tests section.

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2025-07-22T14:33:26Z

@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2025-07-22T14:37:15Z

🚧 @cristipaval has triggered a test Expensify/App build. You can view the workflow run here.

dukenv0307 · 2025-07-22T15:45:22Z

Good catch @VickyStash, I can reproduce on android if I update the paddingBottom:

dukenv0307 · 2025-07-22T15:49:14Z

dukenv0307 · 2025-07-22T16:24:52Z

dukenv0307 · 2025-07-22T16:24:58Z

Looks good

dukenv0307 · 2025-07-22T16:25:17Z

@dubielzyk-expensify Can you please take a look?

dubielzyk-expensify · 2025-07-23T03:14:20Z

I can still see the 1px line on the left of the screen but the bigger padding issue is fixed:

Also, here's the two modals with images and how they look:

Via Filmstrip	Via Confirmation screen

VickyStash · 2025-07-23T10:46:20Z

I wasn't able reproduce the issue from my iPhone, but I've noticed the difference in the containers on the Filmstrip vs Confirmation screen previews. The preview opened from the Confirmation screen doesn't have the bottom safe area padding, I've added a red background so it's more visible

Via Filmstrip	Via Confirmation screen

To align filmstrip preview display with the confirmation one I've added enableEdgeToEdgeBottomSafeAreaPadding flag to the modal.
@dubielzyk-expensify Please, let me know if it fixes the preview for you!
cc @dukenv0307

dukenv0307 · 2025-07-23T14:41:27Z

@dubielzyk-expensify can you please trigger the new build?

github-actions · 2025-07-23T17:31:23Z

🚧 @cristipaval has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2025-07-23T18:08:13Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #66889.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/66889/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/66889/index.html

Desktop 💻	Web 🕸️
⏩ SKIPPED ⏩	⏩ SKIPPED ⏩
The build for Desktop was skipped	The build for Web was skipped

👀 View the workflow run that generated this build 👀

VickyStash · 2025-07-24T08:52:20Z

@dubielzyk-expensify Could you please check this one?

dubielzyk-expensify · 2025-07-24T22:03:30Z

Tiny white line to the left once again :/

VickyStash · 2025-07-25T06:34:49Z

@dubielzyk-expensify Does the preview from the Confirmation step has the same tiny left padding for you? I've checked you screenshot from confirmation page and I guess so, but just want to confirm! Also, could you please share what device do you use?

dubielzyk-expensify · 2025-07-25T07:47:58Z

Does the preview from the Confirmation step has the same tiny left padding for you? I've checked you screenshot from confirmation page and I guess so, but just want to confirm!

Yep, I'm getting on the confirmation page too which wasn't the case a while back. It seemed inconcisitent, but now they seem to be operating the same.

Also, could you please share what device do you use?

iPhone 15 Pro. I'm using iOS 26 beta 4 at the moment, but I believe @shawnborton had the same issue not running the iOS beta.

shawnborton · 2025-07-25T11:07:23Z

Yeah, I think we found inconsistent results across a variety of flows too for this. Are we fixing them everywhere?

VickyStash · 2025-07-25T14:33:04Z

Overall, under the hood, the Lightbox component is used across all of these pages (including attachments preview).
The image is displayed either at full width or full height, depending on its initial size.

Examples:

Narrow image	Wide image

Sometimes, if the image is already displayed at full height, but the image width isn't enough to fill the 100% of width, it can feel like there is a padding.

Simulator Screenshot - iPhone 16 - 2025-07-25 at 16 28 51

Do we want to change anything in this behaviour? @dubielzyk-expensify @shawnborton

shawnborton · 2025-07-25T16:55:28Z

That seems pretty good to me.

Maybe the only question I have for the @Expensify/design - would you expect the image to go to the bottom of the device's viewport, and have the homebar setting on top of the image? Right now we stop the image and have a SafeArea with the app BG:

dannymcclain · 2025-07-25T17:14:33Z

I think I'd expect it to stop before the home bar and not have the home bar sit on top of it. But I see examples of both in various apps so 🤷‍♂️

What do you think?

shawnborton · 2025-07-25T17:25:36Z

I think I could go either way here, but I don't feel strongly so I am down to just leave it as-is.

dukenv0307 · 2025-07-28T14:27:02Z

@dubielzyk-expensify The results above look good to me. Can you please trigger the new build and see if there're any problems?

shawnborton · 2025-07-28T15:10:17Z

I can run the test build, but the screenshots above look to be expected.

github-actions · 2025-07-28T15:11:02Z

🚧 @shawnborton has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2025-07-28T15:54:43Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #66889.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/66889/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/66889/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/66889/NewExpensify.dmg	https://66889.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

dubielzyk-expensify · 2025-07-29T01:14:24Z

Looking good to me. Still seeing the hairline space on the left. Is there any way we can fix that?

dubielzyk-expensify · 2025-07-29T01:15:33Z

Looking good to me. Still seeing the hairline space on the left. Is there any way we can fix that?

VickyStash · 2025-07-29T09:55:20Z

Still seeing the hairline space on the left. Is there any way we can fix that?

It seems to be fixed with small scale buffer applied in the getCanvasFitScale function (commit)
@dukenv0307 Can you please check it and let me know what you think?

dukenv0307 · 2025-07-29T13:05:28Z

@VickyStash I don't think it's the best idea. Can you show me the example within detailed dimension? Should we use round up?

VickyStash · 2025-07-29T16:10:17Z

@dukenv0307

Data I'm testing over:

Device: iPhone 16

image

Logged data from getCanvasFitScale (without buffer):

"canvasSizeWidth": 393,
"canvasSizeHeight": 721,
"contentSizeWidth": 2340,
"contentSizeHeight": 4160,
"minScale": 0.16794871794871793,
"maxScale": 0.1733173076923077

As you can see:

393 / 2340 => 0.16794871794871793 while actually it's ~0.16794871794871795. This difference is caused by floating-point precision. And this minor difference results in super tiny padding, cause minScale is later used in totalScale calculations.

App/src/components/MultiGestureCanvas/index.tsx

Lines 104 to 107 in 1d9156f

    
           // Adding together zoom scale and the initial scale to fit the content into the canvas 
        
           // Using the minimum content scale, so that the image is not bigger than the canvas 
        
           // and not smaller than needed to fit 
        
           const totalScale = useDerivedValue(() => zoomScale.get() * minContentScale, [minContentScale]);

I'm not sure about rounding up, as I guess the results can be more unexpected that way.

dukenv0307 · 2025-07-30T04:03:00Z

@VickyStash If we use buffer as 1.001, the minScale will change to 0.16811666666, it's quite different from the original one 0.16794871794871793. About round-up, I mean 0.16794871794871793 will be changed to 0.167949. What do you think?

VickyStash · 2025-07-30T07:46:23Z

@dukenv0307 I've tested the round up to 0.167949 and it doesn't work 😞...
Also, with round up we can't control at what % exactly we change the width by rounding, with buffer value we can be sure it's always increased by 0.1%

dukenv0307 · 2025-07-31T02:38:01Z

@VickyStash Thank you, it's quite tricky, I also can't find a better solution

Also, with round up we can't control at what % exactly we change the width by rounding, with buffer value we can be sure it's always increased by 0.1%

Yeah, let's go with your solution for now. @dubielzyk-expensify Can you please rebuild ad hoc and test it?

dubielzyk-expensify · 2025-07-31T04:20:23Z

Will run a build 👍

github-actions · 2025-07-31T04:21:13Z

🚧 @dubielzyk-expensify has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2025-07-31T05:02:43Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #66889.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/66889/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/66889/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/66889/NewExpensify.dmg	https://66889.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

dubielzyk-expensify · 2025-07-31T05:25:00Z

YAY! It's fixed 😄 Thanks for working through the details with us 🙏

cristipaval · 2025-07-31T15:53:16Z

@dukenv0307 , could you do the checklist?

dukenv0307 · 2025-07-31T16:50:49Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-07-31.at.23.46.55.mov

Android: mWeb Chrome

Screen.Recording.2025-07-31.at.23.42.43.mov

iOS: HybridApp

Screen.Recording.2025-07-31.at.23.47.15.mov

iOS: mWeb Safari

Screen.Recording.2025-07-31.at.23.41.55.mov

MacOS: Chrome / Safari

Screen.Recording.2025-07-31.at.23.40.17.mov

MacOS: Desktop

Screen.Recording.2025-07-31.at.23.50.30.mov

dukenv0307 · 2025-07-31T16:52:48Z

@cristipaval Sorry, I forgot the checklist 😅. I've just completed it, we're good to merge now 🚀

OSBotify · 2025-07-31T20:28:30Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-08-04T19:59:24Z

🚀 Deployed to staging by https://github.com/cristipaval in version: 9.1.89-1 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-08-06T19:30:20Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.1.89-21 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

Fix receipt preview padding

42f3fce

VickyStash marked this pull request as ready for review July 22, 2025 14:33

VickyStash requested a review from a team as a code owner July 22, 2025 14:33

melvin-bot Bot requested review from dukenv0307 and removed request for a team July 22, 2025 14:33

VickyStash mentioned this pull request Jul 22, 2025

[Due for payment 2025-08-13] [$250] iOS - Wrong horizontal padding when opening a receipt while creating expenses with Multi-Scan #65251

Closed

16 tasks

cristipaval requested a review from dubielzyk-expensify July 22, 2025 14:36

This comment has been minimized.

Sign in to view

Add enableEdgeToEdgeBottomSafeAreaPadding flag

8643e57

Add scale buffer to fix hairline spacing issue

5dd93ee

dukenv0307 approved these changes Jul 31, 2025

View reviewed changes

melvin-bot Bot requested a review from cristipaval July 31, 2025 15:41

cristipaval approved these changes Jul 31, 2025

View reviewed changes

dukenv0307 approved these changes Jul 31, 2025

View reviewed changes

melvin-bot Bot requested a review from cristipaval July 31, 2025 16:51

cristipaval merged commit df6ff73 into Expensify:main Jul 31, 2025
18 of 20 checks passed

github-actions Bot mentioned this pull request Aug 4, 2025

Deploy Checklist: New Expensify 2025-08-04 #67808

Closed

Conversation

VickyStash commented Jul 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jul 22, 2025

Uh oh!

github-actions Bot commented Jul 22, 2025

Uh oh!

This comment has been minimized.

dukenv0307 commented Jul 22, 2025

Uh oh!

dukenv0307 commented Jul 22, 2025

Uh oh!

dukenv0307 commented Jul 22, 2025

Uh oh!

dukenv0307 commented Jul 22, 2025

Uh oh!

dukenv0307 commented Jul 22, 2025

Uh oh!

dubielzyk-expensify commented Jul 23, 2025

Uh oh!

VickyStash commented Jul 23, 2025

Uh oh!

dukenv0307 commented Jul 23, 2025

Uh oh!

github-actions Bot commented Jul 23, 2025

Uh oh!

github-actions Bot commented Jul 23, 2025

Uh oh!

VickyStash commented Jul 24, 2025

Uh oh!

dubielzyk-expensify commented Jul 24, 2025

Uh oh!

VickyStash commented Jul 25, 2025

Uh oh!

dubielzyk-expensify commented Jul 25, 2025

Uh oh!

shawnborton commented Jul 25, 2025

Uh oh!

VickyStash commented Jul 25, 2025

Uh oh!

shawnborton commented Jul 25, 2025

Uh oh!

dannymcclain commented Jul 25, 2025

Uh oh!

shawnborton commented Jul 25, 2025

Uh oh!

dukenv0307 commented Jul 28, 2025

Uh oh!

shawnborton commented Jul 28, 2025

Uh oh!

github-actions Bot commented Jul 28, 2025

Uh oh!

github-actions Bot commented Jul 28, 2025

Uh oh!

dubielzyk-expensify commented Jul 29, 2025

Uh oh!

dubielzyk-expensify commented Jul 29, 2025

Uh oh!

VickyStash commented Jul 29, 2025

Uh oh!

dukenv0307 commented Jul 29, 2025

Uh oh!

VickyStash commented Jul 29, 2025

Uh oh!

dukenv0307 commented Jul 30, 2025

Uh oh!

VickyStash commented Jul 30, 2025

Uh oh!

dukenv0307 commented Jul 31, 2025

Uh oh!

dubielzyk-expensify commented Jul 31, 2025

Uh oh!

VickyStash commented Jul 22, 2025 •

edited

Loading