Fix/65916 Added imported contacts to new chat page

[Eskalifer1]

Explanation of Change

Fixed Issues

$#65916
PROPOSAL:#65916 (comment)

Tests

Preconditions:

• Clean installation of the app on an iOS device
• Contact permissions have been granted to the Expensify app
• Contacts are successfully imported and visible in the app (Check with FAB -> Create Expense -> Scan)

1. Open the app
2. Tap on FAB
3. Tap on Create expense > add any amount and tap on Next
4. Note that imported contacts are displayed correctly in recipient list
5. Go to LHN
6. Tap on FAB
7. Tap on Start Chat
8. Make sure imported contacts is displayed in "Contacts" section

• Verify that no errors appear in the JS console

Offline tests

Preconditions:

• Clean installation of the app on an iOS device
• Contact permissions have been granted to the Expensify app
• Contacts are successfully imported and visible in the app (Check with FAB -> Create Expense -> Scan)

1. Open the app
2. Tap on FAB
3. Tap on Create expense > add any amount and tap on Next
4. Note that imported contacts are displayed correctly in recipient list
5. Go to LHN
6. Tap on FAB
7. Tap on Start Chat
8. Make sure imported contacts is displayed in "Contacts" section

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

65916-android.mp4

Android: mWeb Chrome

65916-android-web.mp4

iOS: Native

65916-ios.mp4

iOS: mWeb Safari

65916-ios-web.mp4

MacOS: Chrome / Safari

65916-web.mp4

MacOS: Desktop

65916-desktop.mp4

[melvin-bot]

@jayeshmangwani Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[jayeshmangwani]

@Eskalifer1, please add the missing platform videos. It’s fine that the changes don’t apply to platforms other than Android and iOS, just include a video of the tests flow for completeness.

[Eskalifer1]

@jayeshmangwani Hi, added video for other platforms

[jayeshmangwani]

@Eskalifer1 Sorry for the delay, wasn't feeling well yesterday and couldn’t review this PR. Could we please resolve the merge conflicts?

[jayeshmangwani]

And BTW, merging the latest main resolved the SpellCheck failure.

[Eskalifer1]

@jayeshmangwani Hi, resolved

[jayeshmangwani]

There are a few minor comments:

1. I think the new hook should be placed under src/hooks.
2. The name useContactsImporter could be improved, maybe something like useContactImport?

[jayeshmangwani]

Overall, PR looks good to me. I’ll be running through the checklist in an hour.

[Eskalifer1]

@jayeshmangwani PR is updated

[jayeshmangwani]

@Eskalifer1 , just wanted to confirm - are you also seeing the same behavior? When we go to New Chat, we're not getting the "Import contacts" pop-up. That's why, if we go directly to the New Chat page, we can't see the contacts.

no-contact-pop-up.mov

[Eskalifer1]

@jayeshmangwani Can you please describe a little bit what do you mean?

[Eskalifer1]

If you mean that there is no modal window with importing contacts, then I think this is the expected behavior, since the task is to add a display of contacts that are already there

[jayeshmangwani]

If you mean that there is no modal window with importing contacts, then I think this is the expected behavior

I don’t think so - we should be seeing the option to import contacts on the New Chat page as well. I might be wrong, but let’s confirm with the design team.
@aldo-expensify , what do you think? Should we be prompted to import contacts on the New Chat page or not?

[Eskalifer1]

Hmm... Then it's a little different from the original problem and the difficulty increases

This was the expected result:
The search accurately finds the contact

[jayeshmangwani]

Hmm... Then it's a little different from the original problem and the difficulty increases

I’m just trying to clarify the expected result here - but at the very least, we should all align on what the expected behavior is.

[jayeshmangwani]

@aldo-expensify whenever you get a chance, please help clarify the expected result here #66910 (comment) and #66910 (comment):

When we go directly to the New Chat page for the first time after installing the app on a mobile device, we don’t see the Import Contacts option - so device contacts aren’t visible.

We’re only able to see the device contacts after navigating to the Choose recipient page.

I’m thinking we should probably request permissions on the New Chat page as well, but wanted to get your thoughts on it.

[aldo-expensify]

Sorry, I didn't have time today to get to this, but I'll do it first thing tomorrow morning.

[aldo-expensify]

@aldo-expensify whenever you get a chance, please help clarify the expected result here #66910 (comment) and #66910 (comment):

When we go directly to the New Chat page for the first time after installing the app on a mobile device, we don’t see the Import Contacts option - so device contacts aren’t visible.

We’re only able to see the device contacts after navigating to the Choose recipient page.

I’m thinking we should probably request permissions on the New Chat page as well, but wanted to get your thoughts on it.

What you are suggesting makes sense to me, but I'll confirm with someone from product or design.

Asking here: https://expensify.slack.com/archives/C03U7DCU4/p1753902648571269?thread_ts=1753902543.258859&cid=C03U7DCU4

Hmm... Then it's a little different from the original problem and the difficulty increases
This was the expected result:
The search accurately finds the contact

This is understandable, we could:

• Ask for a higher reward for the issue considering that the scope is increasing, or
• Finish with this PR addressing exactly what the GH issue is about, and open a new issue to handle what @jayeshmangwani raised

[aldo-expensify]

The conclusion from the conversation here https://expensify.slack.com/archives/C03U7DCU4/p1753902648571269?thread_ts=1753902543.258859&cid=C03U7DCU4:

It makes sense request the contacts permissions in the NewChat flow, but it is low priority since we are focused on other developments first

Considering that, I think we can just finish with this without changing the scope, and later we can create a new issue to handle adding this to the NewChat flow

[jayeshmangwani]

Considering that, I think we can just finish with this without changing the scope, and later we can create a new issue to handle adding this to the NewChat flow

Cool, I’ll go ahead and finish testing the current scope of the PR and work on the checklist.

[jayeshmangwani]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
• I verified tests pass on all platforms & I tested again on:
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android.mov

Android: mWeb Chrome

mweb-chrome.mov

iOS: HybridApp

iOs.mov

iOS: mWeb Safari

mweb-safari.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

[jayeshmangwani]

LGTM 🚀

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[github-actions]

🚀 Deployed to staging by https://github.com/aldo-expensify in version: 9.1.89-1 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[github-actions]

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.1.89-21 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌