PopoverWithMeasuredContent optimization by jmusial · Pull Request #67035 · Expensify/App

jmusial · 2025-07-24T08:48:37Z

Explanation of Change

Fixed Issues

$ #67034

PROPOSAL:

Tests

Popover with measured content is used in various places across the whole app. For testing I picked 3 sample scenarios:

1. Dropdown button in Search Filters

Open the app
Go to Reports
Open any filter
Filter can be selected or dismissed.

2. Worspaces 3 dots menu

Open the app
Go to Workspaces
Press 3 dots next to an existing workspace
Any of the options can be chosen and works as expected

3. Reaction modal

Open the app
Go to Reports
Open a report
Add a reaction to an action

Offline tests

Same as tests

QA Steps

Same as tests

PR Author Checklist

Screenshots/Videos

Android: Native

0037.andorid.native.mov

Android: mWeb Chrome

0037.android.chrome.mov

iOS: Native

0037.ios.mp4

iOS: mWeb Safari

0037.ios.safari.mp4

MacOS: Chrome / Safari

0037.desktop.chrome.mov

MacOS: Desktop

0037.desktop.native.mov

blazejkustra

LGTM!

blazejkustra · 2025-07-29T14:29:33Z

+// eslint-disable-next-line import/prefer-default-export
+export type {PopoverWithMeasuredContentProps};


You can export it as default export to get rid of the eslint disable comment

melvin-bot · 2025-07-29T14:43:34Z

@alitoshmatov Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

jmusial · 2025-07-31T08:39:42Z

hey @alitoshmatov will you have a time to take look @ this sometime soon ?

jmusial · 2025-08-04T09:54:34Z

hey @alitoshmatov will you have a time to take look @ this sometime soon ?

Bump

mountiny · 2025-08-04T19:28:06Z

@ZhenjaHorbach please go ahead with the review

ZhenjaHorbach · 2025-08-04T19:35:18Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

2025-08-04.22.01.33.mov

Android: mWeb Chrome

2025-08-04.22.03.41.mov

iOS: HybridApp

2025-08-04.21.53.08.mov

iOS: mWeb Safari

2025-08-04.21.50.09.mov

MacOS: Chrome / Safari

2025-08-04.21.45.37.mov

MacOS: Desktop

2025-08-04.21.45.37.mov

ZhenjaHorbach · 2025-08-04T20:14:07Z

Due to fast closing animation, we can see the screen change at the bottom under bottom nav on IOS after pressing Go to workspace on workspaces 3 dots menu

2025-08-04.21.56.56.mov

And the closing animation looks pretty fast on android on Dropdown button in Search Filters

2025-08-04.22.02.40.mov

But just checked on main
We have the same issues !

ZhenjaHorbach · 2025-08-04T20:23:15Z

Overall everything looks good !
so LGTM !

OSBotify · 2025-08-04T20:46:08Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Pujan92 · 2025-08-05T12:47:23Z

@jmusial I think there is an issue from this PR when 3 button navigation is enabled, we may need the correct bottom position.

issue1.webm

jmusial · 2025-08-05T13:02:00Z

@Pujan92 will take a look

jmusial · 2025-08-05T13:17:24Z

Cannot reproduce it on latest main
What device / android version are you using ?

3.button.mov

ZhenjaHorbach · 2025-08-05T14:06:41Z

Confirm
Also works good

Pujan92 · 2025-08-05T16:28:55Z

Cannot reproduce it on latest main
What device / android version are you using ?

I am still seeing it on Pixel_7_Pro / android 14

jmusial · 2025-08-06T08:49:14Z

Ok, I can reproduce the issue on Pixel 7 Pro / Android 14. But it's not a regression from this PR. Been there before as well.

I can work on a fix, will just need an issue for it :)

Pujan92 · 2025-08-06T09:37:00Z

I am not sure of it but as I am not able to see that issue if I comment this part and render withPopoverWithMeasuredContentBase only, so I thought it is from this PR.

jmusial · 2025-08-06T09:46:06Z

Interesting, I tested w/ those lines commented out and then on staging build and issue was visible in all cases. @ZhenjaHorbach can you retest as well plz ?

github-actions · 2025-08-06T20:15:40Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.90-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-08-08T02:07:55Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.1.90-11 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

chrispader · 2025-10-02T13:01:40Z

@jmusial @mountiny this PR causes the ActionSheetAwareScrollView to not work anymore on iOS, because we don't measure the content anymore and therefore don't call the MEASURE_POPOVER action anymore:

actionSheetAwareScrollViewContext.transitionActionSheetState({
    type: ActionSheetAwareScrollView.Actions.MEASURE_POPOVER,
    payload: {
        popoverHeight: Math.floor(height),
    },
});

Since we need the measurement also for popovers on small screen width, i'm not sure whether we can keep this optimization in place. Maybe we can have a more optimized measuring logic for native platforms specifically, beacuse there we will never have these "sophisticated positioning schemas" (except for maybe on tablets)

This is the problem:

Simulator.Screen.Recording.-.iPhone.17.Pro.-.2025-09-30.at.15.02.21.mov

(Originally from #68640 (comment))

@jmusial do you want to work on fixing this, as you already worked on this PR?

jmusial · 2025-10-02T13:57:41Z

Hey @chrispader I understand that you're refering to to comments not shifting when bottom modal opens ?
I don't think we want that, coming from this slack comment

chrispader · 2025-10-02T14:10:44Z

Hey @chrispader I understand that you're refering to to comments not shifting when bottom modal opens ? I don't think we want that, coming from this slack comment

@jmusial sorry my bad, i missed that thread. So in the end, we only want to move the scrollable content, when we go from open keyboard to a modal/popover? No shifting animation to show the last comment on top of the popover anymore?

jmusial · 2025-10-02T14:40:10Z

No worries :)

AFAIU we only want to move comments when opening keyboard or editing, not when showing bottom docked modal on small screen, but let's maybe wait for @mountiny to confirm.

mountiny · 2025-10-02T17:09:42Z

Yeah, I think we only need to move it when the keyboard opens so that is also during comment editing

jmusial added 8 commits July 24, 2025 10:45

Popover optimization POC

df8abd6

fix prettier

71bb99d

refactor & add comment

7813963

fix test

83bd84a

Fix Dropdown button default anchor

ddfbfbe

Merge branch 'main' into feat/popover-optimization

8b4becc

Bring back useMemo

d485575

update animation

1b7a923

blazejkustra approved these changes Jul 29, 2025

View reviewed changes

jmusial marked this pull request as ready for review July 29, 2025 14:43

jmusial requested a review from a team as a code owner July 29, 2025 14:43

melvin-bot Bot requested review from alitoshmatov and removed request for a team July 29, 2025 14:43

jmusial changed the title ~~Popover optimization POC~~ PopoverWithMeasuredContent optimization Jul 30, 2025

jmusial added 2 commits July 31, 2025 10:36

Merge branch 'main' into feat/popover-optimization

b1aae3a

fix lint

33a40cb

mountiny assigned jmusial Aug 4, 2025

mountiny requested review from ZhenjaHorbach and removed request for alitoshmatov August 4, 2025 18:53

ZhenjaHorbach approved these changes Aug 4, 2025

View reviewed changes

melvin-bot Bot requested a review from mountiny August 4, 2025 20:23

mountiny approved these changes Aug 4, 2025

View reviewed changes

mountiny merged commit 98b9987 into Expensify:main Aug 4, 2025
19 of 20 checks passed

github-actions Bot mentioned this pull request Aug 6, 2025

Deploy Checklist: New Expensify 2025-08-06 #68050

Closed

This was referenced Aug 7, 2025

iOS - Chat - After editing a message, the chat is not scrolled down #68107

Closed

[CP Staging] Revert "PopoverWithMeasuredContent optimization" #68156

Merged

melvin-bot Bot mentioned this pull request Aug 8, 2025

[Due for payment 2025-09-22] [Due for payment 2025-08-15] [$250] Optimize the PopoverWithMeasuredContent bottom_docked modal performance #67034

Closed

chrispader mentioned this pull request Oct 2, 2025

fix: Keyboard opens briefly between ReportActionContextMenu and EmojiPicker modals #68640

Merged

54 tasks

		// eslint-disable-next-line import/prefer-default-export
		export type {PopoverWithMeasuredContentProps};

Conversation

jmusial commented Jul 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

1. Dropdown button in Search Filters

2. Worspaces 3 dots menu

3. Reaction modal

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

blazejkustra left a comment

Choose a reason for hiding this comment

Uh oh!

blazejkustra Jul 29, 2025

Choose a reason for hiding this comment

Uh oh!

ZhenjaHorbach Aug 4, 2025

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented Jul 29, 2025

Uh oh!

jmusial commented Jul 31, 2025

Uh oh!

jmusial commented Aug 4, 2025

Uh oh!

mountiny commented Aug 4, 2025

Uh oh!

ZhenjaHorbach commented Aug 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

ZhenjaHorbach commented Aug 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ZhenjaHorbach commented Aug 4, 2025

Uh oh!

Uh oh!

OSBotify commented Aug 4, 2025

Uh oh!

Pujan92 commented Aug 5, 2025

Uh oh!

jmusial commented Aug 5, 2025

Uh oh!

jmusial commented Aug 5, 2025

Uh oh!

ZhenjaHorbach commented Aug 5, 2025

Uh oh!

Pujan92 commented Aug 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jmusial commented Aug 6, 2025

Uh oh!

Pujan92 commented Aug 6, 2025

Uh oh!

jmusial commented Aug 6, 2025

Uh oh!

github-actions Bot commented Aug 6, 2025

Uh oh!

github-actions Bot commented Aug 8, 2025

Uh oh!

chrispader commented Oct 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jmusial commented Oct 2, 2025

Uh oh!

chrispader commented Oct 2, 2025

Uh oh!

jmusial commented Oct 2, 2025

Uh oh!

mountiny commented Oct 2, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

jmusial commented Jul 24, 2025 •

edited

Loading

ZhenjaHorbach commented Aug 4, 2025 •

edited

Loading

ZhenjaHorbach commented Aug 4, 2025 •

edited

Loading

Pujan92 commented Aug 5, 2025 •

edited

Loading

chrispader commented Oct 2, 2025 •

edited

Loading