fix: unable to scroll down while tapping on report field#67066
Merged
justinpersaud merged 6 commits intoExpensify:mainfrom Aug 6, 2025
Merged
Conversation
linhvovan29546
commented
Jul 24, 2025
| data={reportFieldsSections} | ||
| renderItem={renderItem} | ||
| estimatedItemSize={variables.optionRowHeight} | ||
| keyExtractor={keyExtractor} |
Contributor
Author
There was a problem hiding this comment.
This change(keyExtractor) is resolve the issue briefly, when delete the report field on web/desktop
|
@alitoshmatov Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Contributor
Author
|
@alitoshmatov Kindly bump |
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppscroll-android.movAndroid: mWeb Chromescroll-mweb.moviOS: HybridAppscroll-ios.mp4iOS: mWeb Safariscroll-safari.mp4MacOS: Chrome / Safariscroll-web.movMacOS: Desktopscroll-desktop.mov |
justinpersaud
approved these changes
Aug 6, 2025
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Contributor
|
🚀 Deployed to staging by https://github.com/justinpersaud in version: 9.1.90-0 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.1.90-11 🚀
|
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
This PR update FlatList to FlashList to resolve the issue unable to scroll down while tapping on report field
Fixed Issues
$ #62240
PROPOSAL: #62240 (comment)
Tests
Precondition:
Offline tests
Same as test above
QA Steps
Same as test above
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2025-07-24.at.20.48.02.mov
Android: mWeb Chrome
Screen.Recording.2025-07-24.at.20.45.30.mov
iOS: Native
Screen.Recording.2025-07-24.at.20.30.04.mov
iOS: mWeb Safari
Screen.Recording.2025-07-24.at.20.31.34.mov
MacOS: Chrome / Safari
Screen.Recording.2025-07-24.at.20.23.03.mov
MacOS: Desktop
Screen.Recording.2025-07-24.at.20.27.01.mov