Skip to content

Refactor toggleProfileTool to remove usage of Onyx.Connect #67133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tgolen merged 6 commits into from
Jul 31, 2025
Merged

Refactor toggleProfileTool to remove usage of Onyx.Connect #67133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3190ac2
refactor `toggleProfileTool`
allgandalf Jul 25, 2025
fc396c6
Merge branch 'Expensify:main' into fixtoggleProfileTool
allgandalf Jul 31, 2025
daf104b
Update package.json
allgandalf Jul 31, 2025
14fde5a
Merge branch 'Expensify:main' into fixtoggleProfileTool
allgandalf Jul 31, 2025
9100596
Merge branch 'main' into fixtoggleProfileTool
allgandalf Jul 31, 2025
58b28b4
apply reviewers suggestions
allgandalf Jul 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
"test:debug": "TZ=utc NODE_OPTIONS='--inspect-brk --experimental-vm-modules' jest --runInBand",
"perf-test": "NODE_OPTIONS=--experimental-vm-modules npx reassure",
"typecheck": "NODE_OPTIONS=--max_old_space_size=8192 tsc",
"lint": "NODE_OPTIONS=--max_old_space_size=8192 eslint . --max-warnings=332 --cache --cache-location=node_modules/.cache/eslint",
"lint": "NODE_OPTIONS=--max_old_space_size=8192 eslint . --max-warnings=331 --cache --cache-location=node_modules/.cache/eslint",
"lint-changed": "NODE_OPTIONS=--max_old_space_size=8192 ./scripts/lintChanged.sh",
"lint-watch": "npx eslint-watch --watch --changed",
"shellcheck": "./scripts/shellCheck.sh",
Expand Down
2 changes: 1 addition & 1 deletion src/components/RecordTroubleshootDataToolMenu/BaseRecordTroubleshootDataToolMenu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ function BaseRecordTroubleshootDataToolMenu({
} else {
Performance.disableMonitoring();
}
toggleProfileTool();
toggleProfileTool(isProfilingInProgress);
return () => {
Performance.disableMonitoring();
};
Expand Down
10 changes: 2 additions & 8 deletions src/libs/actions/ProfilingTool.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,18 +3,12 @@ import Onyx from 'react-native-onyx';
import CONST from '@src/CONST';
import ONYXKEYS from '@src/ONYXKEYS';

let isProfilingInProgress = false;
Onyx.connect({
key: ONYXKEYS.APP_PROFILING_IN_PROGRESS,
callback: (val) => (isProfilingInProgress = val ?? false),
});

/**
* Toggle the test tools modal open or closed.
* Throttle the toggle to make the modal stay open if you accidentally tap an extra time, which is easy to do.
*/
function toggleProfileTool() {
const toggle = () => Onyx.set(ONYXKEYS.APP_PROFILING_IN_PROGRESS, !isProfilingInProgress);
function toggleProfileTool(isProfilingInProgress = false) {
const toggle = () => Onyx.set(ONYXKEYS.APP_PROFILING_IN_PROGRESS, isProfilingInProgress);
const throttledToggle = throttle(toggle, CONST.TIMING.TEST_TOOLS_MODAL_THROTTLE_TIME);
throttledToggle();
}
Expand Down
Loading