fix: fallback avatar shown in reports page when RHP is open and page is not in focus by Burhan-Rashid · Pull Request #67470 · Expensify/App

Burhan-Rashid · 2025-07-31T04:51:45Z

Explanation of Change

Fixed Issues

$ #67039
PROPOSAL: $ #67039 (comment)

Tests

Go to staging.expensify.com
Open any chat and send a message.
Go to Reports > Chats.
Click on the sent message.
With the RHP open, refresh the page.
Verify that the fallback avatar is not shown.

Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Go to staging.expensify.com
Open any chat and send a message.
Go to Reports > Chats.
Click on the sent message.
With the RHP open, refresh the page.
Verify that the fallback avatar is not shown.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

android.web.mp4

iOS: Native

iOS: mWeb Safari

ios.web.mp4

MacOS: Chrome / Safari

web.chrome.desktop.mp4

MacOS: Desktop

…is not in focus

melvin-bot · 2025-07-31T07:08:38Z

@c3024 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Burhan-Rashid · 2025-07-31T07:10:59Z

I have added screen recording of 3 platforms (android mWeb, IOS mWeb and MacOS chrome) where page refresh is possible. Moreover, this issue is only visible in MacOS chrome as RHP for other 2 platforms covers the whole screen. For the other 3 native platforms, page refresh/reload is not possible, so couldn't add screen recordings for them. @c3024

c3024 · 2025-07-31T09:11:58Z

+    // Trigger once on mount (e.g., on page reload), when RHP is open and screen is not focused
+    useEffect(() => {
+        handleFocusOrMount();
+        // eslint-disable-next-line


Let us specify the exact lint rule disabled here and move the comment inside.

Suggested change

// Trigger once on mount (e.g., on page reload), when RHP is open and screen is not focused

useEffect(() => {

handleFocusOrMount();

// eslint-disable-next-line

useEffect(() => {

clearTransactionsAndSetHashAndKey();

// Trigger once on mount (e.g., on page reload when RHP is open and screen is not focused)

// eslint-disable-next-line react-compiler/react-compiler, react-hooks/exhaustive-deps

c3024 · 2025-07-31T09:12:10Z

-            setCurrentSearchHashAndKey(hash, searchKey);
-        }, [hash, searchKey, clearSelectedTransactions, setCurrentSearchHashAndKey]),
-    );
+    const handleFocusOrMount = useCallback(() => {


Suggested change

const handleFocusOrMount = useCallback(() => {

const clearTransactionsAndSetHashAndKey = useCallback(() => {

Lets us change this function name to what it does like the PR author checklist suggests:

I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)

Julesssss

LGTM, leaving final review of new changes to @c3024

Burhan-Rashid · 2025-08-01T10:53:38Z

@c3024 I have fixed the PR comments. Could you pls review once you are free.

c3024 · 2025-08-01T10:56:59Z

This issue is preventing me from testing the PR. I will complete review once that is resolved.

Julesssss · 2025-08-01T17:37:04Z

This issue is preventing me from testing the PR. I will complete review once that is resolved.

Wow, that's a bad one. Seems like it's resolved now though 🎉

c3024 · 2025-08-01T17:58:13Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

refreshAndroid.mov

Android: mWeb Chrome

refreshAndroidmWeb1.mov

refreshAndroidmWeb.mov

iOS: HybridApp

refreshiOS.mov

iOS: mWeb Safari

refreshiOSmWeb.mov

MacOS: Chrome / Safari

refreshChrome.mov

MacOS: Desktop

refreshDesktop.mov

c3024

LGTM!

github-actions · 2025-08-04T20:01:45Z

🚀 Deployed to staging by https://github.com/Julesssss in version: 9.1.89-1 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-08-06T19:32:41Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.1.89-21 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

fix: fallback avatar shown in reports page when RHP is open and page …

5b5c99e

…is not in focus

Burhan-Rashid force-pushed the fix/67039 branch from 48e6a4d to 5b5c99e Compare July 31, 2025 04:54

Burhan-Rashid marked this pull request as ready for review July 31, 2025 07:08

Burhan-Rashid requested a review from a team as a code owner July 31, 2025 07:08

melvin-bot Bot requested a review from c3024 July 31, 2025 07:08

melvin-bot Bot removed the request for review from a team July 31, 2025 07:08

Burhan-Rashid mentioned this pull request Jul 31, 2025

[Due for payment 2025-08-13] [$250] Reports - Message previews show fallback avatar after refreshing the page with report RHP open #67039

Closed

8 tasks

c3024 suggested changes Jul 31, 2025

View reviewed changes

fixed pr comments

08b8473

Burhan-Rashid requested a review from c3024 July 31, 2025 10:04

Julesssss approved these changes Jul 31, 2025

View reviewed changes

c3024 approved these changes Aug 1, 2025

View reviewed changes

melvin-bot Bot requested a review from Julesssss August 1, 2025 18:00

Julesssss approved these changes Aug 1, 2025

View reviewed changes

Julesssss merged commit 3478b90 into Expensify:main Aug 1, 2025
19 of 22 checks passed

github-actions Bot mentioned this pull request Aug 4, 2025

Deploy Checklist: New Expensify 2025-08-04 #67808

Closed

BlameGPT mentioned this pull request Aug 5, 2025

[Due for payment 2025-08-15] Reports - Task - Missing Description table title, Share in and Assignee header are misaligned #67841

Closed

8 tasks

	const handleFocusOrMount = useCallback(() => {
	const clearTransactionsAndSetHashAndKey = useCallback(() => {

Conversation

Burhan-Rashid commented Jul 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jul 31, 2025

Uh oh!

Burhan-Rashid commented Jul 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

c3024 Jul 31, 2025

Choose a reason for hiding this comment

Uh oh!

Burhan-Rashid Jul 31, 2025

Choose a reason for hiding this comment

Uh oh!

c3024 Jul 31, 2025

Choose a reason for hiding this comment

Uh oh!

Burhan-Rashid Jul 31, 2025

Choose a reason for hiding this comment

Uh oh!

Julesssss left a comment

Choose a reason for hiding this comment

Uh oh!

Burhan-Rashid commented Aug 1, 2025

Uh oh!

c3024 commented Aug 1, 2025

Uh oh!

Julesssss commented Aug 1, 2025

Uh oh!

c3024 commented Aug 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

c3024 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Aug 4, 2025

Uh oh!

github-actions Bot commented Aug 6, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Burhan-Rashid commented Jul 31, 2025 •

edited

Loading

Burhan-Rashid commented Jul 31, 2025 •

edited

Loading

c3024 commented Aug 1, 2025 •

edited

Loading