fix: default new WS to Control if user is in annual subscription#67477
Merged
stitesExpensify merged 2 commits intoExpensify:mainfrom Aug 6, 2025
Merged
fix: default new WS to Control if user is in annual subscription#67477stitesExpensify merged 2 commits intoExpensify:mainfrom
stitesExpensify merged 2 commits intoExpensify:mainfrom
Conversation
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridApp01_Android_Native.mp4Android: mWeb Chrome02_Android_Chrome.mp4iOS: HybridApp03_iOS_Native.mp4iOS: mWeb Safari04_iOS_Safari.mp4MacOS: Chrome / Safari05_MacOS_Chrome.mp4MacOS: Desktop06_MacOS_Desktop.mp4 |
stitesExpensify
approved these changes
Aug 6, 2025
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Contributor
|
🚀 Deployed to staging by https://github.com/stitesExpensify in version: 9.1.90-0 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.1.90-11 🚀
|
16 tasks
52 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Fixed Issues
$ #65697
PROPOSAL: #65697 (comment)
Tests
Precondition: Account is in annual subscription
Offline tests
QA Steps
Precondition: Account is in annual subscription
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2025-08-01.at.04.10.53.mov
Android: mWeb Chrome
Screen.Recording.2025-08-01.at.04.12.00.mov
iOS: Native
iOS: mWeb Safari
Screen.Recording.2025-08-01.at.04.13.05.mov
MacOS: Chrome / Safari
Screen.Recording.2025-08-01.at.04.13.49.mov
MacOS: Desktop
Screen.Recording.2025-08-01.at.04.14.25.mov