fix: navigate to onboarding personal details from accounting#67758
Merged
inimaga merged 2 commits intoExpensify:mainfrom Aug 6, 2025
Merged
Conversation
|
@rushatgabhane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
16 tasks
Member
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppWhatsApp.Video.2025-08-06.at.12.56.47.mp4Android: mWeb ChromeiOS: HybridAppScreen.Recording.2025-08-06.at.13.09.42.moviOS: mWeb SafariScreen.Recording.2025-08-06.at.12.57.25.movMacOS: Chrome / SafariScreen.Recording.2025-08-06.at.12.58.19.movMacOS: DesktopScreen.Recording.2025-08-06.at.13.07.05.mov |
rushatgabhane
approved these changes
Aug 6, 2025
inimaga
approved these changes
Aug 6, 2025
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Contributor
|
🚀 Deployed to staging by https://github.com/inimaga in version: 9.1.90-0 🚀
|
8 tasks
Contributor
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.1.90-11 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
When choose an accounting software and press next during onboarding we were navigating to interested feature skipping personal details page even through the details has not been added initially. This PR check the initial flow and navigate the user accordingly.
Fixed Issues
$ #67008
PROPOSAL: #67008 (comment)
Tests
Test one
Test two
[x] Verify that no errors appear in the JS console
Offline tests
QA Steps
Same as test
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android.native.mov
Android: mWeb Chrome
Android.mWeb.chrome.mov
iOS: Native
IOS.native.mp4
iOS: mWeb Safari
IOS.mWeb.safari.mp4
MacOS: Chrome / Safari
macOS.chrome.mp4
MacOS: Desktop
Desktop.mp4