Skip to content

[CP Staging] Revert "Fix creating second scan expense unexpected error is shown"#68006

Merged
mountiny merged 1 commit intomainfrom
revert-67479-fix/67142-1
Aug 6, 2025
Merged

[CP Staging] Revert "Fix creating second scan expense unexpected error is shown"#68006
mountiny merged 1 commit intomainfrom
revert-67479-fix/67142-1

Conversation

@grgia
Copy link
Copy Markdown
Contributor

@grgia grgia commented Aug 6, 2025

Reverts #67479

Fixes #67876

@grgia grgia self-assigned this Aug 6, 2025
@grgia grgia requested a review from a team as a code owner August 6, 2025 11:33
@grgia grgia changed the title Revert "Fix creating second scan expense unexpected error is shown" [CP Staging] Revert "Fix creating second scan expense unexpected error is shown" Aug 6, 2025
@grgia grgia requested a review from mountiny August 6, 2025 11:33
@melvin-bot melvin-bot Bot requested a review from mollfpr August 6, 2025 11:34
@melvin-bot
Copy link
Copy Markdown

melvin-bot Bot commented Aug 6, 2025

@mollfpr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot Bot removed the request for review from a team August 6, 2025 11:34
@grgia grgia mentioned this pull request Aug 6, 2025
Closed
8 tasks
mountiny
mountiny approved these changes Aug 6, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@mountiny mountiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straight revert

@mountiny mountiny merged commit b8ad404 into main Aug 6, 2025
21 of 24 checks passed
@mountiny mountiny deleted the revert-67479-fix/67142-1 branch August 6, 2025 13:04
@melvin-bot
Copy link
Copy Markdown

melvin-bot Bot commented Aug 6, 2025

@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@melvin-bot melvin-bot Bot added the Emergency label Aug 6, 2025
@mountiny mountiny removed the Emergency label Aug 6, 2025
@mountiny
Copy link
Copy Markdown
Contributor

mountiny commented Aug 6, 2025

Straight revert

OSBotify pushed a commit that referenced this pull request Aug 6, 2025
@mountiny @OSBotify
Merge pull request #68006 from Expensify/revert-67479-fix/67142-1
24cddac 
[CP Staging] Revert "Fix creating second scan expense unexpected error is shown"

(cherry picked from commit b8ad404)

(cherry-picked to staging by mountiny)
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Aug 6, 2025
@github-actions github-actions Bot mentioned this pull request Aug 6, 2025
Closed
@OSBotify
Copy link
Copy Markdown
Contributor

OSBotify commented Aug 6, 2025

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 6, 2025

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.1.89-19 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 6, 2025

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.1.89-21 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 6, 2025

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.1.90-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 8, 2025

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.1.90-11 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mountiny mountiny mountiny approved these changes

@mollfpr mollfpr Awaiting requested review from mollfpr

Assignees

@grgia grgia

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[RCA #67479] Scan receipt - It's not here page when edit amount split expense in DM group

4 participants

@grgia @mountiny @OSBotify @jasperhuangg