PopoverWithMeasuredContent optimization for mobile by jmusial · Pull Request #68223 · Expensify/App

jmusial · 2025-08-08T15:32:34Z

Explanation of Change

On small screens PopoverWithMeasuredContent returns BottomDockedModal in the end. This fix returns BottomDockedModal earlier avoiding expensive position and measurement calculation logic.

Cotext:

This PR was reverted in connection to #68107, adding Videos and test scenario for that case.

Fixed Issues

$ #67034

PROPOSAL:

Tests

Popover with measured content is used in various places across the whole app. For testing I picked 3 sample scenarios:

1. Dropdown button in Search Filters

Open the app
Go to Reports
Open any filter
Filter can be selected or dismissed.

2. Worspaces 3 dots menu

Open the app
Go to Workspaces
Press 3 dots next to an existing workspace
Any of the options can be chosen and works as expected

3. Reaction modal

Open the app
Go to Reports
Open a report
Add a reaction to an action

4. Revert testcase

Open the app
Navigate to a conversation and enter a message
Send the message
Edit the sent message
After editing a message , the chat is scrolled down

Offline tests

Same as tests

QA Steps

Same as tests

PR Author Checklist

Screenshots/Videos

Android: Native

0037.andorid.native.mov

Android: mWeb Chrome

0037.android.chrome.mov

iOS: Native

0037.ios.mp4

iOS: mWeb Safari

0037.ios.safari.mp4

MacOS: Chrome / Safari

0037.desktop.chrome.mov

Revert testcase videos

Android: Native

Revert.-.android.native.mov

Android: mWeb Chrome

Revery.andorid.chrome.mov

iOS: Native

Revert.-ios.native.mp4

iOS: mWeb Safari

Revert.-ios.safari.mp4

melvin-bot · 2025-08-18T09:01:31Z

@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

jmusial · 2025-08-18T09:03:07Z

Hey @ZhenjaHorbach this is pretty much unchanged from 1st PR... I cannot repro the bug that caused the revert, but not 100% sure how we should proceed here? Maybe get ad hoc builds and test again ?

ZhenjaHorbach · 2025-08-19T13:51:34Z

Hey @ZhenjaHorbach this is pretty much unchanged from 1st PR... I cannot repro the bug that caused the revert, but not 100% sure how we should proceed here? Maybe get ad hoc builds and test again ?

Actually I also couldn't reproduce this issue before
But good idea
Let's check on adhoc builds !

I will ask in Slack

github-actions · 2025-08-19T13:54:57Z

🚧 @mollfpr has triggered a test Expensify/App build. You can view the workflow run here.

jmusial · 2025-08-19T15:36:56Z

hey @jasperhuangg you were able to reproduce this issue. Can you check on ad-hoc build plz ?

ZhenjaHorbach · 2025-08-21T10:58:11Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screenrecorder-2025-08-21-13-35-04-238.mp4

Android: mWeb Chrome

Screenrecorder-2025-08-21-13-37-32-278.mp4

iOS: HybridApp

ios.MP4

iOS: mWeb Safari

ios-web.MP4

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

web.mov

ZhenjaHorbach · 2025-08-21T11:09:48Z

Found this
But we have the same issue on staging also
When we go back the modal is still open
but then it closes with broken animation

2025-08-21.13.09.15.mp4

ZhenjaHorbach · 2025-08-21T11:14:17Z

Hey @ZhenjaHorbach this is pretty much unchanged from 1st PR... I cannot repro the bug that caused the revert, but not 100% sure how we should proceed here? Maybe get ad hoc builds and test again ?

And in this PR I can't reproduce this issue also
But I hope we won't encounter with this issue again

ZhenjaHorbach · 2025-08-21T11:48:30Z

Looks like we have a common issue with bottom bar on android
Which overlaps modals
But the same problem is in staging
And possible this problem is specific to specific devices

jmusial · 2025-08-22T08:26:14Z

Looks like we have a common issue with bottom bar on android Which overlaps modals But the same problem is in staging And possible this problem is specific to specific devices

Ah, I was lookiung into this one the other day. I think this is caused by

AppAndFlow/react-native-safe-area-context#634

ZhenjaHorbach · 2025-08-22T08:37:27Z

Looks like we have a common issue with bottom bar on android Which overlaps modals But the same problem is in staging And possible this problem is specific to specific devices

Ah, I was lookiung into this one the other day. I think this is caused by

AppAndFlow/react-native-safe-area-context#634

Thanks for checking !
Actually yes
Looks similar 😅

ZhenjaHorbach · 2025-08-22T08:41:59Z

Hi @m-natarajan,
Could you please take a look at this issue?

The original PR was reverted which caused this issue, and this new version includes a fix.
The tricky part is that we weren’t able to reproduce the issue before 😢
Could you try testing it using these builds?

It looks like you were able to reproduce the problem earlier here.

jmusial · 2025-08-22T08:47:02Z

Found this But we have the same issue on staging also When we go back the modal is still open but then it closes with broken animation

2025-08-21.13.09.15.mp4

for this one looking if there is an ez fix now

EDIT: cannot repro :( this is android chrome right ?
any particular version ? @ZhenjaHorbach

jmusial · 2025-08-22T08:58:12Z

Looks like we have a common issue with bottom bar on android Which overlaps modals But the same problem is in staging And possible this problem is specific to specific devices

Ah, I was lookiung into this one the other day. I think this is caused by
AppAndFlow/react-native-safe-area-context#634

Thanks for checking ! Actually yes Looks similar 😅

Yeah, in the code the insets on bottom come as 0 from the lib :(

ZhenjaHorbach · 2025-08-22T09:34:54Z

Found this But we have the same issue on staging also When we go back the modal is still open but then it closes with broken animation
2025-08-21.13.09.15.mp4

for this one looking if there is an ez fix now

EDIT: cannot repro :( this is android chrome right ? any particular version ? @ZhenjaHorbach

No
It's ios web (iPhone 13)

jmusial · 2025-08-22T10:26:46Z

Which ios version ? 18.6 seems ok ?
And what setting puts nav bar to the top in safari :D ?

Simulator.Screen.Recording.-.iPhone.13.-.2025-08-22.at.12.24.24.mp4

ZhenjaHorbach · 2025-08-22T11:05:39Z

Which ios version ? 18.6 seems ok ? And what setting puts nav bar to the top in safari :D ?

Simulator.Screen.Recording.-.iPhone.13.-.2025-08-22.at.12.24.24.mp4

I have a beta 26
Maybe this is the reason 😅

jmusial · 2025-08-27T15:16:33Z

Hey I'll be OOO till 08.09, during this time @blazejkustra will be monitoring this one.

ZhenjaHorbach · 2025-08-28T13:44:25Z

Hi @m-natarajan, Could you please take a look at this issue?

The original PR was reverted which caused this issue, and this new version includes a fix. The tricky part is that we weren’t able to reproduce the issue before 😢 Could you try testing it using these builds?

It looks like you were able to reproduce the problem earlier here.

@m-natarajan
Friendly bump

ZhenjaHorbach · 2025-09-09T10:37:53Z

@mountiny
Could you please run adhoc builds for this?

github-actions · 2025-09-09T14:24:18Z

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2025-09-09T15:04:47Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #68223.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/68223/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/68223/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/68223/NewExpensify.dmg	https://68223.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

ZhenjaHorbach · 2025-09-10T16:15:02Z

Asked QA team here

m-natarajan · 2025-09-10T17:20:06Z

Not reproducible on iPhone 16/18.3.1 build v9.2.3-0 PR:68223 Ad-Hoc

ScreenRecording_09-10-2025.13-15-45_1.MP4

ZhenjaHorbach · 2025-09-10T17:31:46Z

In this case, LGTM!

mountiny · 2025-09-10T19:21:28Z

@jmusial @ZhenjaHorbach can you please check the reasure failure? maybe we need to adjust mocks

jmusial · 2025-09-11T10:47:01Z

@jmusial @ZhenjaHorbach can you please check the reasure failure? maybe we need to adjust mocks

I merged main and it's passing on my local ... Pipeline shows merge conflict with Mobile-Expensify but I don't thinks it's coming from this PR..

EDIT: ok, there is a percentage diff again - looking into it now, although so far passes on my local ;(

jmusial · 2025-09-11T13:38:48Z

Ok, I checked and there is indeed an extra render that is a result of adding a

    const {isSmallScreenWidth} = useResponsiveLayout();
    if (isSmallScreenWidth) {

in src/components/PopoverWithMeasuredContent/index.tsx

Given that reported render duration is flat 0, I'd say that's ok, what do you think @mountiny ?

 - [ReportActionCompose] should press create button [render]: 0.0 ms → 0.0 ms  | 4 → 5 (+1, +25.0%) 🔴

mountiny

Just a small NAB, you can address that in another PR.

Yeah seems like the extra render is expected here but it should not cause pref regression so moving this ahead

mountiny · 2025-09-11T21:30:08Z

src/components/PopoverWithMeasuredContent/index.tsx

+
+/**
+ * Logic for PopoverWithMeasuredContent is in PopoverWithMeasuredContentBase.
+ * This component is a perf optimization, it return BOTTOM_DOCKED early, for small screens avoiding Popover measurement logic calculations.


I think this reads better

Suggested change

* This component is a perf optimization, it return BOTTOM_DOCKED early, for small screens avoiding Popover measurement logic calculations.

* This component is a perf optimization, it returns a BOTTOM_DOCKED modal early for small screens, avoiding Popover measurement logic calculations.

OSBotify · 2025-09-11T21:46:39Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-09-12T00:31:29Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.2.13-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-09-15T12:19:57Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.2.13-1 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

jmusial added 2 commits August 8, 2025 17:29

all the changes again

e779968

Merge branch 'main' into feat/popover-optimization-v2

55aadb2

jmusial marked this pull request as ready for review August 18, 2025 09:01

jmusial requested a review from a team as a code owner August 18, 2025 09:01

melvin-bot bot requested review from ZhenjaHorbach and removed request for a team August 18, 2025 09:01

mollfpr added the Ready To Build label Aug 19, 2025

This comment has been minimized.

Sign in to view

Merge branch 'main' into feat/popover-optimization-v2

1e3dcf1

jmusial added 2 commits September 9, 2025 11:57

Merge branch 'main' into feat/popover-optimization-v2

919534b

remove the old file

ffbe89c

mountiny assigned jmusial Sep 9, 2025

jmusial mentioned this pull request Sep 10, 2025

[Due for payment 2025-09-22] [Due for payment 2025-08-15] [$250] Optimize the PopoverWithMeasuredContent bottom_docked modal performance #67034

Closed

Merge branch 'main' into feat/popover-optimization-v2

89798b0

ZhenjaHorbach approved these changes Sep 10, 2025

View reviewed changes

melvin-bot bot requested a review from mountiny September 10, 2025 17:32

Merge branch 'main' into feat/popover-optimization-v2

dddf62d

Merge branch 'main' into feat/popover-optimization-v2

f05cf46

jmusial mentioned this pull request Sep 11, 2025

Verify account for delegate user flow uses navigation modal #68401

Merged

49 tasks

jmusial added 2 commits September 11, 2025 15:03

revert merge leftover changes

aa3dba8

Merge branch 'main' into feat/popover-optimization-v2

50015c4

mountiny approved these changes Sep 11, 2025

View reviewed changes

mountiny merged commit c7b5990 into Expensify:main Sep 11, 2025
22 of 23 checks passed

OSBotify mentioned this pull request Sep 11, 2025

Deploy Checklist: New Expensify 2025-09-11 #70433

Closed

30 tasks

	* This component is a perf optimization, it return BOTTOM_DOCKED early, for small screens avoiding Popover measurement logic calculations.
	* This component is a perf optimization, it returns a BOTTOM_DOCKED modal early for small screens, avoiding Popover measurement logic calculations.

Conversation

jmusial commented Aug 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

1. Dropdown button in Search Filters

2. Worspaces 3 dots menu

3. Reaction modal

4. Revert testcase

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Revert testcase videos

Uh oh!

melvin-bot bot commented Aug 18, 2025

Uh oh!

jmusial commented Aug 18, 2025

Uh oh!

ZhenjaHorbach commented Aug 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Aug 19, 2025

Uh oh!

This comment has been minimized.

jmusial commented Aug 19, 2025

Uh oh!

ZhenjaHorbach commented Aug 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

ZhenjaHorbach commented Aug 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ZhenjaHorbach commented Aug 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ZhenjaHorbach commented Aug 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jmusial commented Aug 22, 2025

Uh oh!

ZhenjaHorbach commented Aug 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ZhenjaHorbach commented Aug 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jmusial commented Aug 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jmusial commented Aug 22, 2025

Uh oh!

ZhenjaHorbach commented Aug 22, 2025

Uh oh!

jmusial commented Aug 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ZhenjaHorbach commented Aug 22, 2025

Uh oh!

jmusial commented Aug 27, 2025

Uh oh!

ZhenjaHorbach commented Aug 28, 2025

Uh oh!

ZhenjaHorbach commented Sep 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Sep 9, 2025

Uh oh!

github-actions bot commented Sep 9, 2025

Uh oh!

ZhenjaHorbach commented Sep 10, 2025

Uh oh!

m-natarajan commented Sep 10, 2025

Uh oh!

ZhenjaHorbach commented Sep 10, 2025

Uh oh!

mountiny commented Sep 10, 2025

jmusial commented Aug 8, 2025 •

edited

Loading

ZhenjaHorbach commented Aug 19, 2025 •

edited

Loading

ZhenjaHorbach commented Aug 21, 2025 •

edited

Loading

ZhenjaHorbach commented Aug 21, 2025 •

edited

Loading

ZhenjaHorbach commented Aug 21, 2025 •

edited

Loading

ZhenjaHorbach commented Aug 21, 2025 •

edited

Loading

ZhenjaHorbach commented Aug 22, 2025 •

edited

Loading

ZhenjaHorbach commented Aug 22, 2025 •

edited

Loading

jmusial commented Aug 22, 2025 •

edited

Loading

jmusial commented Aug 22, 2025 •

edited

Loading

ZhenjaHorbach commented Sep 9, 2025 •

edited

Loading

jmusial commented Sep 11, 2025 •

edited

Loading