[CP Staging] Update drafts syntax by luacmartins · Pull Request #68480 · Expensify/App

luacmartins · 2025-08-13T22:31:49Z

Explanation of Change

Updates the Drafts syntax to Draft to be consistent with other statuses.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/535345
$ #69037

Tests

Pre-condition: an account with unsubmitted reports

Navigate to reports
Type status:
Verify that you see draft as the suggestion, instead of drafts
Select it
Verify that draft is highlighted
Submit the query
Verify that the search works
Open the Filters RHP
Verify that you see Status as Draft

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Screen.Recording.2025-08-21.at.4.55.57.PM.mov

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2025-08-21T22:57:54Z

@linhvovan29546 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

luacmartins · 2025-08-21T23:12:26Z

@linhvovan29546 the .js files are autogenerated. You don't need to review those

linhvovan29546

@luacmartins I did a quick check and this looks good to me. I just left a minor comment.

linhvovan29546 · 2025-08-22T00:39:55Z

Could you also please create an issue in the App for this PR?

linhvovan29546 · 2025-08-22T01:41:30Z

BUG: The app crashes when typing status:dra
Step:

Navigate to Reports.
Type status:dra in the search field.
Press Enter — the app crashes.

Screen.Recording.2025-08-22.at.08.37.49.mov

linhvovan29546 · 2025-08-22T02:00:18Z

NAB: I'm unsure if this is intended behavior or a bug. If I type status:drafts and press Enter, the search field auto-corrects to status:draft

Screen.Recording.2025-08-22.at.08.51.20.mov

luacmartins · 2025-08-22T17:08:05Z

@linhvovan29546 this bug is also present for other invalid statuses and in production. This is being addressed as part of this issue #68674

This one is expected #68480 (comment)

luacmartins · 2025-08-22T17:12:42Z

Actually for the crash, I decided to just include a fix on this PR since it's simple enough

linhvovan29546 · 2025-08-22T23:32:07Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-08-23.at.16.26.12.mov

Android: mWeb Chrome

Screen.Recording.2025-08-23.at.16.29.50.mov

iOS: HybridApp

Screen.Recording.2025-08-23.at.16.12.41.mov

iOS: mWeb Safari

Screen.Recording.2025-08-23.at.16.19.45.mov

MacOS: Chrome / Safari

Screen.Recording.2025-08-23.at.16.02.01.mov

MacOS: Desktop

Screen.Recording.2025-08-23.at.16.35.40.mov

linhvovan29546 · 2025-08-22T23:32:23Z

I'll complete check list today!

linhvovan29546

LGTM!
NAB: @luacmartins You forgot to select a checkbox in the description

melvin-bot · 2025-08-23T09:42:00Z

@srikarparsi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2025-08-23T09:42:02Z

🎯 @linhvovan29546, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #69099.

OSBotify · 2025-08-25T06:21:25Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Update drafts syntax (cherry picked from commit 5505a57) (cherry-picked to staging by luacmartins)

OSBotify · 2025-08-25T20:21:58Z

🚀 Cherry-picked to staging by https://github.com/luacmartins in version: 9.1.98-8 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2025-08-25T21:46:44Z

🚀 Cherry-picked to staging by https://github.com/luacmartins in version: 9.1.98-10 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2025-08-26T11:01:13Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.1.98-12 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-08-26T11:20:29Z

🚀 Cherry-picked to staging by https://github.com/luacmartins in version: 9.1.99-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2025-08-28T01:18:14Z

🚀 Deployed to production by https://github.com/thienlnam in version: 9.1.99-11 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

suneox · 2025-12-15T15:17:42Z

+                    ...CONST.SEARCH.STATUS.TASK,
+                });
        }
+        return suggestedStatuses.map((value) => getUserFriendlyValue(value));


Coming from #75908 checklist we should filter out empty suggested item (ALL option)

update drafts syntax

77481ce

luacmartins self-assigned this Aug 13, 2025

luacmartins added 6 commits August 19, 2025 16:40

resolve conflicts

ce04c3b

fix prettier

5d59193

resolve conflicts

d19e97c

update translation keys

43417ff

rm unecessary code

cbe5c11

add highlights

af89caf

luacmartins marked this pull request as ready for review August 21, 2025 22:57

luacmartins requested a review from a team as a code owner August 21, 2025 22:57

melvin-bot bot requested review from linhvovan29546 and removed request for a team August 21, 2025 22:57

linhvovan29546 suggested changes Aug 22, 2025

View reviewed changes

Comment thread src/components/Search/SearchAutocompleteList.tsx

rm map

cd718f6

luacmartins requested a review from linhvovan29546 August 22, 2025 17:08

fix crash

6a0e643

luacmartins mentioned this pull request Aug 22, 2025

[Due for payment 2025-09-12] [$250] Reports - App crashes when searching with "group-by:reports,from,card" #68674

Closed

8 tasks

use typeguard

71cd642

linhvovan29546 approved these changes Aug 23, 2025

View reviewed changes

melvin-bot bot requested a review from srikarparsi August 23, 2025 09:41

melvin-bot bot mentioned this pull request Aug 23, 2025

Payment issue for E/App PR#68480 #69099

Closed

srikarparsi approved these changes Aug 25, 2025

View reviewed changes

srikarparsi merged commit 5505a57 into main Aug 25, 2025
26 checks passed

srikarparsi deleted the cmartins-updateDrafts branch August 25, 2025 06:10

luacmartins mentioned this pull request Aug 25, 2025

Reports - In reports page, app crashes on searching type: expense status:all #69105

Closed

16 tasks

OSBotify pushed a commit that referenced this pull request Aug 25, 2025

Merge pull request #68480 from Expensify/cmartins-updateDrafts

f583bdc

Update drafts syntax (cherry picked from commit 5505a57) (cherry-picked to staging by luacmartins)

OSBotify added the CP Staging marks PRs that have been CP'd to staging label Aug 25, 2025

OSBotify mentioned this pull request Aug 25, 2025

Deploy Checklist: New Expensify 2025-08-22 #69038

Closed

luacmartins changed the title ~~Update drafts syntax~~ [CP Staging] Update drafts syntax Aug 25, 2025

melvin-bot bot mentioned this pull request Aug 28, 2025

[Due for payment 2025-09-04] Update status:drafts to status:draft #69037

Closed

suneox reviewed Dec 15, 2025

View reviewed changes

Conversation

luacmartins commented Aug 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Aug 21, 2025

Uh oh!

luacmartins commented Aug 21, 2025

Uh oh!

linhvovan29546 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

linhvovan29546 commented Aug 22, 2025

Uh oh!

linhvovan29546 commented Aug 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

linhvovan29546 commented Aug 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

luacmartins commented Aug 22, 2025

Uh oh!

luacmartins commented Aug 22, 2025

Uh oh!

linhvovan29546 commented Aug 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

linhvovan29546 commented Aug 22, 2025

Uh oh!

linhvovan29546 left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Aug 23, 2025

Uh oh!

melvin-bot bot commented Aug 23, 2025

Uh oh!

Uh oh!

OSBotify commented Aug 25, 2025

Uh oh!

OSBotify commented Aug 25, 2025

Uh oh!

OSBotify commented Aug 25, 2025

Uh oh!

OSBotify commented Aug 26, 2025

Uh oh!

OSBotify commented Aug 26, 2025

Uh oh!

OSBotify commented Aug 28, 2025

Uh oh!

suneox Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

luacmartins commented Aug 13, 2025 •

edited

Loading

linhvovan29546 commented Aug 22, 2025 •

edited

Loading

linhvovan29546 commented Aug 22, 2025 •

edited

Loading

linhvovan29546 commented Aug 22, 2025 •

edited

Loading