Updating Trips doc with new fee information#68864
Conversation
We needed to clarify the $15 vs $25 trip fee so I added it.
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
@madmax330 @RachCHopkins One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
A preview of your ExpensifyHelp changes have been deployed to https://4a5fbf43.helpdot.pages.dev ⚡️ |
There was a problem hiding this comment.
Reveiwed the changes and they look good to me and are accurate.
There appears to be an extra return after the indented "Note" bullet, but there is not an extra return in my markdown.
I don't know why it's there or how to remove the extra return.
|
It's probably something mark-down specific @strepanier03, why don't you change the order? It would make just as much sense as
|
changed order around to workaround markdown.
removed an extra return.
|
Good call Rach, I did that. This is ready if everyone agrees. |
|
LGTM! |
|
All yours @madmax330 |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
|
🚀 Deployed to staging by https://github.com/madmax330 in version: 9.1.99-0 🚀
|
|
@strepanier03 Any QA steps here? |
|
🚀 Deployed to production by https://github.com/thienlnam in version: 9.1.99-11 🚀
|
We needed to clarify the $15 vs $25 trip fee so I added it.
Explanation of Change
Fixed Issues
$
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop