Skip to content

fix: order of distance rates is not preserved after reset #68980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcochavezf merged 2 commits into from
Aug 25, 2025
+2 −1
Merged

fix: order of distance rates is not preserved after reset #68980

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe88846
fix: order of distance rates is not preserved after reset
nkdengineer Aug 22, 2025
9acb094
remove dependency
nkdengineer Aug 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/pages/workspace/distanceRates/PolicyDistanceRatesPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ import {
} from '@libs/actions/Policy/DistanceRate';
import {convertAmountToDisplayString} from '@libs/CurrencyUtils';
import {canUseTouchScreen} from '@libs/DeviceCapabilities';
import localeCompare from '@libs/LocaleCompare';
import Navigation from '@libs/Navigation/Navigation';
import type {PlatformStackScreenProps} from '@libs/Navigation/PlatformStackNavigation/types';
import {getDistanceRateCustomUnit} from '@libs/PolicyUtils';
Expand Down Expand Up @@ -233,7 +234,7 @@ function PolicyDistanceRatesPage({
const normalizedSearchInput = StringUtils.normalize(searchInput.toLowerCase());
return rateText.includes(normalizedSearchInput);
}, []);
const sortRates = useCallback((rates: RateForList[]) => rates, []);
const sortRates = useCallback((rates: RateForList[]) => rates.sort((a, b) => localeCompare(a.text ?? '', b.text ?? '')), []);
Copy link
Copy Markdown
Contributor

@shubham1206agra shubham1206agra Aug 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nkdengineer We have deprecated the localeCompare method from @libs/LocaleCompare. Can you please use localeCompare from useLocalize hook, and make the amends in the follow-up PR?

Copy link
Copy Markdown
Member

@parasharrajat parasharrajat Aug 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, good call. @nkdengineer feel free to create a follow-up any time.

const [inputValue, setInputValue, filteredDistanceRatesList] = useSearchResults(distanceRatesList, filterRate, sortRates);

const addRate = () => {
Expand Down
Loading