Skip to content

[CP Staging] Revert "fix: inverted flatlist overscroll recoil"#69310

Merged
yuwenmemon merged 1 commit intomainfrom
revert-68895-fix/flatlist-overscroll-recoil
Aug 27, 2025
Merged

[CP Staging] Revert "fix: inverted flatlist overscroll recoil"#69310
yuwenmemon merged 1 commit intomainfrom
revert-68895-fix/flatlist-overscroll-recoil

Conversation

@yuwenmemon
Copy link
Copy Markdown
Contributor

@yuwenmemon yuwenmemon commented Aug 26, 2025

Reverts #68895

$ #69262

Tested and made sure scrolling works again:

Kapture.2025-08-26.at.23.43.08.mp4

@yuwenmemon yuwenmemon requested a review from a team as a code owner August 26, 2025 22:14
@melvin-bot melvin-bot Bot requested a review from srikarparsi August 26, 2025 22:14
@melvin-bot
Copy link
Copy Markdown

melvin-bot Bot commented Aug 26, 2025

@srikarparsi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot Bot removed the request for review from a team August 26, 2025 22:14
@srikarparsi
Copy link
Copy Markdown
Contributor

Hey @yuwenmemon, is this for this issue

@yuwenmemon
Copy link
Copy Markdown
Contributor Author

@srikarparsi Yeah I'm coming back to this might be the issue but I'm gonna make an ad-hoc build to be sure

@github-actions
Copy link
Copy Markdown
Contributor

🚧 @yuwenmemon has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions
Copy link
Copy Markdown
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #69310.

Android 🤖 iOS 🍎
⏩ SKIPPED ⏩ ⏩ SKIPPED ⏩
The build for Android was skipped The build for iOS was skipped
Desktop 💻 Web 🕸️
⏩ SKIPPED ⏩ https://69310.pr-testing.expensify.com
The build for Desktop was skipped Web

👀 View the workflow run that generated this build 👀

@yuwenmemon yuwenmemon changed the title Revert "fix: inverted flatlist overscroll recoil" [CP Staging] Revert "fix: inverted flatlist overscroll recoil" Aug 27, 2025
@yuwenmemon
Copy link
Copy Markdown
Contributor Author

No need for checklists, this is a straight revert

@yuwenmemon yuwenmemon merged commit 83e3549 into main Aug 27, 2025
21 of 25 checks passed
@yuwenmemon yuwenmemon deleted the revert-68895-fix/flatlist-overscroll-recoil branch August 27, 2025 06:49
@melvin-bot
Copy link
Copy Markdown

melvin-bot Bot commented Aug 27, 2025

@yuwenmemon looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@melvin-bot melvin-bot Bot added the Emergency label Aug 27, 2025
@OSBotify
Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify pushed a commit that referenced this pull request Aug 27, 2025
…erscroll-recoil

[CP Staging] Revert "fix: inverted flatlist overscroll recoil"

(cherry picked from commit 83e3549)

(cherry-picked to staging by thienlnam)
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Aug 27, 2025
@yuwenmemon
Copy link
Copy Markdown
Contributor Author

Not an emergency, straight revert

@OSBotify
Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/thienlnam in version: 9.1.99-9 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@yuwenmemon
Copy link
Copy Markdown
Contributor Author

QA passes on staging

@OSBotify
Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/thienlnam in version: 9.1.99-10 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 cancelled 🔪
🍎 iOS 🍎 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/thienlnam in version: 9.1.99-11 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/thienlnam in version: 9.2.0-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Copy Markdown
Contributor

OSBotify commented Sep 2, 2025

🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.0-5 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 failure ❌
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Copy Markdown
Contributor

OSBotify commented Sep 2, 2025

🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.0-5 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CP Staging marks PRs that have been CP'd to staging Ready To Build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants