Skip to content

Revert "Merge workspace.accounting.enableContinuousReconciliation translation"#69311

Merged
thienlnam merged 1 commit intomainfrom
revert-68257-merge-translation-18
Aug 26, 2025
Merged

Revert "Merge workspace.accounting.enableContinuousReconciliation translation"#69311
thienlnam merged 1 commit intomainfrom
revert-68257-merge-translation-18

Conversation

@roryabraham
Copy link
Copy Markdown
Contributor

@roryabraham roryabraham commented Aug 26, 2025 •
edited
Loading

Reverts #68257 to fix a deploy blocker: #69293

@roryabraham roryabraham self-assigned this Aug 26, 2025
@roryabraham roryabraham requested a review from a team as a code owner August 26, 2025 23:08
@melvin-bot melvin-bot Bot requested a review from madmax330 August 26, 2025 23:08
@melvin-bot
Copy link
Copy Markdown

melvin-bot Bot commented Aug 26, 2025

@madmax330 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot Bot removed the request for review from a team August 26, 2025 23:08
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 26, 2025

🚧 @roryabraham has triggered a test Expensify/App build. You can view the workflow run here.

@roryabraham roryabraham requested review from NikkiWines and removed request for madmax330 August 26, 2025 23:09
NikkiWines
NikkiWines approved these changes Aug 26, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@NikkiWines NikkiWines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@thienlnam
Copy link
Copy Markdown
Contributor

thienlnam commented Aug 26, 2025

Looks like a straight revert

@thienlnam thienlnam merged commit b8703e5 into main Aug 26, 2025
22 of 26 checks passed
@thienlnam thienlnam deleted the revert-68257-merge-translation-18 branch August 26, 2025 23:32
@melvin-bot melvin-bot Bot added the Emergency label Aug 26, 2025
@melvin-bot
Copy link
Copy Markdown

melvin-bot Bot commented Aug 26, 2025

@thienlnam looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@thienlnam
Copy link
Copy Markdown
Contributor

thienlnam commented Aug 26, 2025

#69311 (comment)

OSBotify pushed a commit that referenced this pull request Aug 26, 2025
@thienlnam @OSBotify
Merge pull request #69311 from Expensify/revert-68257-merge-translati…
fa1f641 
…on-18

Revert "Merge workspace.accounting.enableContinuousReconciliation translation"

(cherry picked from commit b8703e5)

(cherry-picked to staging by roryabraham)
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Aug 26, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 26, 2025

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #69311.

Android 🤖 iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/69311/index.html https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/69311/index.html
Android iOS
Desktop 💻 Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/69311/NewExpensify.dmg https://69311.pr-testing.expensify.com
Desktop Web

👀 View the workflow run that generated this build 👀

@OSBotify
Copy link
Copy Markdown
Contributor

OSBotify commented Aug 26, 2025

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Aug 26, 2025
Closed
@OSBotify
Copy link
Copy Markdown
Contributor

OSBotify commented Aug 27, 2025

🚀 Cherry-picked to staging by https://github.com/roryabraham in version: 9.1.99-5 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Copy Markdown
Contributor

OSBotify commented Aug 28, 2025

🚀 Deployed to production by https://github.com/thienlnam in version: 9.1.99-11 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Copy Markdown
Contributor

OSBotify commented Aug 28, 2025

🚀 Cherry-picked to staging by https://github.com/roryabraham in version: 9.2.0-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Copy Markdown
Contributor

OSBotify commented Sep 2, 2025

🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.0-5 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 failure ❌
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Copy Markdown
Contributor

OSBotify commented Sep 2, 2025

🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.0-5 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NikkiWines NikkiWines NikkiWines approved these changes

+1 more reviewer

@thienlnam thienlnam thienlnam approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@roryabraham roryabraham

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@roryabraham @thienlnam @OSBotify @NikkiWines