Refactor ONYXKEYS.COLLECTION.REPORT_NAME_VALUE_PAIRS in src/libs/actions/Task.ts #70139

parasharrajat · 2025-09-08T20:01:18Z

Explanation of Change

Fixed Issues

$ #67798
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

_Note: Steps do not indicate the process of getting both of following tasks in the account. Please follow the standard test steps for getting these tasks _

Test drive task.

Log in using a new account, complete onboarding via track and manage expense purpose or some other purpose which creates the test drive task in the account.
Complete the test drive from FAB. Verify that the test drive task is completed in chat.
Or complete the test drive from Reports. Verify that the test drive task is completed in chat.

Setup Categories task.

Create a workspace category and verify that the setup category task is completed in #admins or the concierge report.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

…ons/Task.ts

melvin-bot · 2025-09-09T08:11:50Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

DylanDylann · 2025-09-16T07:21:42Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

DylanDylann · 2025-09-16T07:21:51Z

@parasharrajat Please merge the latest main

parasharrajat · 2025-09-16T08:20:10Z

Done.

luacmartins · 2025-09-16T14:54:04Z

src/libs/actions/Task.ts

+// allReportNameValuePair is used on getFinishOnboardingTaskOnyxData to generate Onyx optimistic data
+Onyx.connectWithoutView({


I think we should make getFinishOnboardingTaskOnyxData a pure function since this function is in an action file that could be connected to a view in the future.

@luacmartins They don’t return data directly for rendering. If it’s purely related to an action (with no connection to UI)

IMO, it’s fine to use connectWithoutView in this case. If you’re not comfortable with it, we can start a thread in the newdot room to discuss this further and decide on a consistent approach for similar cases in the future.

I disagree. This is an action file that's not tied to network, pusher, etc. This function could very easily be added to a view where it's used for rendering. I think the general rule is that if it's an action file not tied to one of the pre-defined exceptions (online/offline listeners, pusher events, network requests) we should make it a pure function. Any exceptions to that case should be discussed and agreed upon.

cc @tgolen since we discussed this

In this case, allReportNameValuePair isn’t used for rendering the UI. We only use it to build optimistic data, which is fetched when the user performs an action that triggers it. Therefore, we don’t need to worry about outdated data here. That’s why I suggest to use connectWithoutView. I’d love to hear more of your thoughts on this matter

@DylanDylann you are right and I agree that it technically meets the bar for using connectWithoutView here, but I think from a bigger picture, we really want to promote the code using the best patterns.

I think connectWithoutView is best used in src/lib files, and the src/action files should try to stick to pure functions as much as possible. This way, people don't see the Onyx.connect pattern in the action files and aren't as tempted to copy it to some other spot, or begin referencing the impure function without realizing it.

@tgolen Thanks for the explanation.

@parasharrajat Could you update the PR?

Updated. Thanks for waiting.

tgolen · 2025-09-19T14:54:37Z

bump @parasharrajat Will you be able to update the PR soon?

parasharrajat · 2025-09-19T15:20:08Z

I was out sick for the last 2 days. So I couldn't update. I will work on it soon.

tgolen · 2025-09-23T14:14:04Z

@parasharrajat I'm sorry you haven't been feeling well. Will you have a chance to look at this soon?

parasharrajat · 2025-09-23T14:20:55Z

Yes, I will check it today.

luacmartins · 2025-09-24T21:08:42Z

@parasharrajat did you get a chance to check this PR?

parasharrajat · 2025-09-25T12:17:04Z

I have started working on more refactors. I will start pushing updates shortly.

luacmartins · 2025-09-25T17:34:43Z

Thanks @parasharrajat

tgolen · 2025-09-29T16:52:58Z

Hi @parasharrajat any update here?

parasharrajat · 2025-09-30T10:46:13Z

It's updated. Thanks for waiting. I was occupied with some urgent task follow-ups.

parasharrajat · 2025-09-30T10:47:16Z

@DylanDylann Should I add test steps for this, or will it be no QA?

github-actions · 2025-09-30T11:26:49Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

codecov · 2025-09-30T13:07:12Z

Codecov Report

❌ Patch coverage is 66.66667% with 9 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
...s/workspace/categories/WorkspaceCategoriesPage.tsx	40.00%	3 Missing ⚠️
src/components/TestDrive/TestDriveDemo.tsx	0.00%	2 Missing ⚠️
...es/home/sidebar/FloatingActionButtonAndPopover.tsx	33.33%	2 Missing ⚠️
src/pages/Search/EmptySearchView.tsx	50.00%	1 Missing ⚠️
...es/iou/request/step/IOURequestStepConfirmation.tsx	50.00%	1 Missing ⚠️

📢 Thoughts on this report? Let us know!

src/hooks/useOnboardingTask.ts

luacmartins

LGTM. Thanks for addressing the comments

tgolen · 2025-09-30T19:47:24Z

@DylanDylann do you want one last look at this before merging?

DylanDylann

LGTM

DylanDylann · 2025-10-01T08:34:22Z

@DylanDylann Should I add test steps for this, or will it be no QA?

@parasharrajat Yes, please add a sample flow to the QA step

parasharrajat · 2025-10-01T11:50:59Z

Update QA steps to test basic flows.

OSBotify · 2025-10-02T05:15:36Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.2.22-1 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-10-03T17:35:37Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.2.22-6 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Refactor ONYXKEYS.COLLECTION.REPORT_NAME_VALUE_PAIRS in src/libs/acti…

44b00a1

…ons/Task.ts

melvin-bot bot assigned parasharrajat Sep 8, 2025

parasharrajat changed the title ~~Refactor ONYXKEYS.COLLECTION.REPORT_NAME_VALUE_PAIRS in src/libs/actions/Task.ts~~ [No QA] Refactor ONYXKEYS.COLLECTION.REPORT_NAME_VALUE_PAIRS in src/libs/actions/Task.ts Sep 9, 2025

parasharrajat marked this pull request as ready for review September 9, 2025 08:11

parasharrajat requested a review from a team as a code owner September 9, 2025 08:11

melvin-bot bot requested review from DylanDylann and removed request for a team September 9, 2025 08:11

parasharrajat force-pushed the onyx/67798 branch from c689a4a to 44b00a1 Compare September 9, 2025 08:38

DylanDylann approved these changes Sep 16, 2025

View reviewed changes

melvin-bot bot requested a review from luacmartins September 16, 2025 07:22

Merge branch 'main' of github.com:Expensify/App into onyx/67798

c3c3736

luacmartins requested changes Sep 16, 2025

View reviewed changes

parasharrajat added 6 commits September 30, 2025 15:06

Merge branch 'main' of github.com:Expensify/App into onyx/67798

9c397fd

Refactor completeTestDriveTask

1799d13

Rename task hook

ce61da9

Refactor getFinishOnboardingTaskOnyxData

5db0dd9

Remove extra key

a227458

Remove comments

833f846

parasharrajat added 2 commits September 30, 2025 15:54

rename

d7c06ca

Update tests

81aca4c

parasharrajat requested a review from DylanDylann September 30, 2025 10:46

parasharrajat added 4 commits September 30, 2025 16:34

fix tasks

f5444c7

Rename and refactor

f9f8fcb

remove extra word

1a97f39

Reset warning count

6befee3

parasharrajat added 2 commits September 30, 2025 18:22

Missing dependency

8cc0952

fix tests

c09d169

tgolen requested changes Sep 30, 2025

View reviewed changes

src/hooks/useOnboardingTask.ts Outdated Show resolved Hide resolved

src/hooks/useOnboardingTask.ts Outdated Show resolved Hide resolved

Rename hook

7a7ca01

luacmartins requested review from luacmartins and tgolen September 30, 2025 18:08

luacmartins approved these changes Sep 30, 2025

View reviewed changes

tgolen approved these changes Sep 30, 2025

View reviewed changes

DylanDylann reviewed Oct 1, 2025

View reviewed changes

parasharrajat changed the title ~~[No QA] Refactor ONYXKEYS.COLLECTION.REPORT_NAME_VALUE_PAIRS in src/libs/actions/Task.ts~~ Refactor ONYXKEYS.COLLECTION.REPORT_NAME_VALUE_PAIRS in src/libs/actions/Task.ts Oct 1, 2025

luacmartins merged commit 296677a into Expensify:main Oct 1, 2025
32 checks passed

Julesssss mentioned this pull request Oct 1, 2025

[Due for payment 2025-11-13] [$250] EX-43 - How would you like to get started - Task not autocompleted after test drive #71688

Closed

8 tasks

OSBotify mentioned this pull request Oct 2, 2025

Deploy Checklist: New Expensify 2025-10-02 #71726

Closed

52 tasks

DylanDylann mentioned this pull request Jan 15, 2026

[BETA] Allow zero-amount expenses - ROUND 5 #79197

Merged

53 tasks

		// allReportNameValuePair is used on getFinishOnboardingTaskOnyxData to generate Onyx optimistic data
		Onyx.connectWithoutView({

Refactor ONYXKEYS.COLLECTION.REPORT_NAME_VALUE_PAIRS in src/libs/actions/Task.ts #70139

Refactor ONYXKEYS.COLLECTION.REPORT_NAME_VALUE_PAIRS in src/libs/actions/Task.ts #70139

Uh oh!

Conversation

parasharrajat commented Sep 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

Test drive task.

Setup Categories task.

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Sep 9, 2025

Uh oh!

DylanDylann commented Sep 16, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

DylanDylann commented Sep 16, 2025

Uh oh!

parasharrajat commented Sep 16, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tgolen commented Sep 19, 2025

Uh oh!

parasharrajat commented Sep 19, 2025

Uh oh!

tgolen commented Sep 23, 2025

Uh oh!

parasharrajat commented Sep 23, 2025

Uh oh!

luacmartins commented Sep 24, 2025

Uh oh!

parasharrajat commented Sep 25, 2025

Uh oh!

luacmartins commented Sep 25, 2025

Uh oh!

tgolen commented Sep 29, 2025

Uh oh!

parasharrajat commented Sep 30, 2025

Uh oh!

parasharrajat commented Sep 30, 2025

Uh oh!

github-actions bot commented Sep 30, 2025

Uh oh!

codecov bot commented Sep 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

luacmartins left a comment

Choose a reason for hiding this comment

Uh oh!

tgolen commented Sep 30, 2025

Uh oh!

DylanDylann left a comment

Choose a reason for hiding this comment

Uh oh!

parasharrajat commented Sep 8, 2025 •

edited

Loading

codecov bot commented Sep 30, 2025 •

edited

Loading