[No QA] Update help articles to use the new retract button name#72357
[No QA] Update help articles to use the new retract button name#72357VictoriaExpensify merged 6 commits intomainfrom
Conversation
|
A preview of your ExpensifyHelp changes have been deployed to https://7eaa03cc.helpdot.pages.dev ⚡️ Updated articles: |
|
All set for review! |
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
@rushatgabhane @VictoriaExpensify One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
| @@ -1,7 +1,7 @@ | |||
| --- | |||
| title: Create-and-Submit-Reports.md | |||
There was a problem hiding this comment.
Metadata violation: The title should match the actual article title, not the filename. Change title: Create-and-Submit-Reports.md to title: Create and Submit Reports to follow proper YAML metadata formatting.
There was a problem hiding this comment.
IDT this is right. This is the convention other articles seem to use.
HelpDot Documentation ReviewOverall AssessmentThis PR performs a focused terminology update across four help articles to align with recent UI changes in both OldDot and NewDot applications. The changes consistently replace "Undo submit" and "Undo close" with "Retract" and update state terminology (open→draft, processing→outstanding, closed→done) where applicable. Scores Summary
Key FindingsStrengths:
Areas for attention:
Recommendations
Files Reviewed
Note: This is a terminology alignment update that successfully maintains content quality while implementing necessary UI consistency changes. |
| @@ -1,7 +1,7 @@ | |||
| --- | |||
| title: Create-and-Submit-Reports.md | |||
There was a problem hiding this comment.
AI Readiness violation: The title should not end with ".md" extension. This should be just "Create and Submit Reports" to be more readable and AI-friendly.
There was a problem hiding this comment.
Same as above
HelpDot Documentation ReviewOverall AssessmentPR #72357 implements a systematic terminology update across 4 help articles, standardizing button names from 'Undo submit'/'Undo close' to 'Retract' and updating report status language (open→draft, processing→outstanding, closed→done) in New Expensify documentation. The changes are functionally accurate and maintain consistency across the documentation set. Scores Summary
Key FindingsStrengths:
Areas for Improvement:
RecommendationsHigh Priority:
Medium Priority:
Files Reviewed
Overall Impact AssessmentThis PR successfully modernizes the documentation to reflect UI changes while maintaining clarity and user accessibility. The updates will reduce user confusion by aligning help content with actual application interfaces. The systematic approach ensures consistency across the help ecosystem. Recommendation: Approve - These changes improve documentation accuracy and user experience with minimal risk. |
|
@VictoriaExpensify as an fyi the AI review bot ran wild here and reviewed the changes many times over. I made a few of the changes flagged where there were typos, but most of the stuff is stylistic and has existed in the articles for a while or not actually correct suggestions by the AI. LMK if any questions! |
|
@VictoriaExpensify could you add the PR reviewer checklist here? That way the test passes before I merge. |
|
@VictoriaExpensify looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
|
🚀 Deployed to staging by https://github.com/VictoriaExpensify in version: 9.2.44-0 🚀
|
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.2.44-5 🚀
|
Explanation of Change
Updating
Undo submitandUndo closetoRetractin the following help articles because we updated the button names in OldDot and NewDot here:Fixed Issues
$ #68039
QA Steps
Undo submitorUndo closenow sayRetract.opennow saydraft, processing now sayoutstanding, andclosednow saydone.PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.