Skip to content

Fix: Don't show negative transactions on Add unreported expense screen #72552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nkuoch merged 2 commits into from
Oct 20, 2025
Merged

Fix: Don't show negative transactions on Add unreported expense screen #72552

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
68fcb18
Enhance AddUnreportedExpense component to disallow negative expense v…
kubabutkiewicz Oct 14, 2025
ae0aaf4
Merge branch 'main' of github.com:callstack-internal/Expensify-App in…
kubabutkiewicz Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/pages/AddUnreportedExpense.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ import interceptAnonymousUser from '@libs/interceptAnonymousUser';
import type {AddUnreportedExpensesParamList} from '@libs/Navigation/types';
import Permissions from '@libs/Permissions';
import {canSubmitPerDiemExpenseFromWorkspace, getPerDiemCustomUnit} from '@libs/PolicyUtils';
import {isIOUReport} from '@libs/ReportUtils';
import {getTransactionDetails, isIOUReport} from '@libs/ReportUtils';
import {shouldRestrictUserBillableActions} from '@libs/SubscriptionUtils';
import tokenizedSearch from '@libs/tokenizedSearch';
import {createUnreportedExpenseSections, getAmount, getCurrency, getDescription, getMerchant, isPerDiemRequest} from '@libs/TransactionUtils';
Expand Down Expand Up @@ -74,6 +74,11 @@ function AddUnreportedExpense({route}: AddUnreportedExpensePageType) {
return false;
}

// Negative values are not allowed for unreported expenses
if ((getTransactionDetails(item)?.amount ?? 0) < 0) {
return false;
}

if (isPerDiemRequest(item)) {
// Only show per diem expenses if the target workspace has per diem enabled and the per diem expense was created in the same workspace
const workspacePerDiemUnit = getPerDiemCustomUnit(policy);
Expand Down
Loading