fix: update default option and styles for company card start date step by daledah · Pull Request #72842 · Expensify/App

daledah · 2025-10-17T07:44:37Z

Explanation of Change

Fixed Issues

$ #71537
PROPOSAL: #71537 (comment)

Tests

Precondition: WS is connected to a Company Card feed

Go to WS -> Company Cards
Click Assign card
Verify that: The default selection in the card assignment flow for transactions is "Custom date" with today's date preselected
Verify that: The selection style matches with design.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Precondition: WS is connected to a Company Card feed

Go to WS -> Company Cards
Click Assign card
Verify that: The default selection in the card assignment flow for transactions is "Custom date" with today's date preselected
Verify that: The selection style matches with design.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-10-17.at.16.47.15.mov

Android: mWeb Chrome

Screen.Recording.2025-10-17.at.16.48.02.mov

iOS: Native

Screen.Recording.2025-10-17.at.16.48.30.mov

iOS: mWeb Safari

Screen.Recording.2025-10-17.at.16.50.00.mov

MacOS: Chrome / Safari

Screen.Recording.2025-10-17.at.16.50.23.mov

MacOS: Desktop

Screen.Recording.2025-10-17.at.16.50.43.mov

codecov · 2025-10-17T07:56:56Z

Codecov Report

❌ Patch coverage is 57.89474% with 8 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
...mpanyCards/assignCard/TransactionStartDateStep.tsx	0.00%	5 Missing ⚠️
...ts/SelectionList/ListItem/SingleSelectListItem.tsx	0.00%	1 Missing ⚠️
...SelectionListWithSections/SingleSelectListItem.tsx	0.00%	1 Missing ⚠️
...ace/companyCards/assignCard/AssignCardFeedPage.tsx	0.00%	1 Missing ⚠️

Files with missing lines	Coverage Δ
src/ROUTES.ts	`11.09% <ø> (-0.13%)`	⬇️
src/SCREENS.ts	`100.00% <ø> (ø)`
src/components/SelectionList/BaseSelectionList.tsx	`56.36% <100.00%> (+0.26%)`	⬆️
...components/SelectionList/ListItem/BaseListItem.tsx	`90.00% <100.00%> (+0.25%)`	⬆️
...onents/SelectionList/ListItem/ListItemRenderer.tsx	`75.00% <ø> (ø)`
...omponents/SelectionList/ListItem/RadioListItem.tsx	`88.46% <100.00%> (+0.46%)`	⬆️
...ponents/SelectionListWithSections/BaseListItem.tsx	`97.67% <100.00%> (+0.05%)`	⬆️
...ListWithSections/BaseSelectionListItemRenderer.tsx	`88.88% <100.00%> (+0.65%)`	⬆️
...ListWithSections/BaseSelectionListWithSections.tsx	`75.71% <100.00%> (+0.05%)`	⬆️
...onents/SelectionListWithSections/RadioListItem.tsx	`100.00% <100.00%> (ø)`
... and 7 more

... and 11 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

melvin-bot · 2025-10-17T10:00:28Z

@suneox Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Julesssss · 2025-10-21T22:52:19Z

Hey @suneox, this should be ready for your review again

Julesssss

Looking good to me 👍

suneox · 2025-10-22T10:20:04Z

Hey @suneox, this should be ready for your review again

Yes, I'll double check this PR in few hours

Julesssss

@suneox, I see this comment was marked outdated, are any further changes necessary?

LGTM . Thank you for your hard work!

suneox · 2025-10-23T01:58:54Z

@daledah We’re unable to move to the next step after an error appears when choosing a different option

Screen.Recording.2025-10-23.at.08.56.26.mov

suneox · 2025-10-23T16:47:57Z

@suneox, I see this comment was marked outdated, are any further changes necessary?

LGTM . Thank you for your hard work!

This is just to pre-run the review workflow before merging to ensure everything works correctly.

daledah · 2025-10-27T02:58:08Z

We’re unable to move to the next step after an error appears when choosing a different option

Fixed!

Julesssss

Thanks, just waiting for next C+ review

suneox · 2025-11-01T09:05:03Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-11-01.at.15.55.59.mp4

Android: mWeb Chrome

Screen.Recording.2025-11-01.at.15.57.13.mp4

iOS: HybridApp

Screen.Recording.2025-11-01.at.15.59.57.mp4

iOS: mWeb Safari

Screen.Recording.2025-11-01.at.15.58.19.mp4

MacOS: Chrome / Safari

Screen.Recording.2025-11-01.at.15.49.46.mp4

MacOS: Desktop

Screen.Recording.2025-11-01.at.15.54.26.mp4

suneox · 2025-11-01T09:12:22Z

@daledah We still have a conflict and please make sure to retest after resolving it

daledah · 2025-11-03T09:50:04Z

@suneox i updated

suneox · 2025-11-03T14:44:17Z

@Julesssss This issue includes a UI component update, so we can trigger a build for @Expensify/design to review

github-actions · 2025-11-03T18:43:16Z

🚧 @Julesssss has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2025-11-03T19:15:19Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #72842.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/72842/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/72842/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/72842/NewExpensify.dmg	https://72842.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

dubielzyk-expensify · 2025-11-04T00:16:01Z

Videos look good to me. Couldn't test adhoc build as my test cards are broken.

OSBotify · 2025-11-04T18:01:01Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-11-04T21:13:29Z

🚀 Deployed to staging by https://github.com/Julesssss in version: 9.2.44-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-11-05T20:06:54Z

🚀 Deployed to production by https://github.com/luacmartins in version: 9.2.44-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

hungvu193 · 2025-12-19T02:37:53Z

+                                    onInputChange={(value) => {
+                                        setErrorText('');
+                                        setStartDate(value);
+                                    }}


In #76108, we decided that we should also add validation on input change.

fix: update default option and styles for company card start date step

453b5aa

melvin-bot Bot assigned daledah Oct 17, 2025

daledah added 3 commits October 17, 2025 16:51

fix: lint

04f0ba0

fix: lint

1820f4b

fix: deprecated prop

1633c7e

daledah marked this pull request as ready for review October 17, 2025 10:00

daledah requested a review from a team as a code owner October 17, 2025 10:00

melvin-bot Bot requested review from suneox and removed request for a team October 17, 2025 10:00

fix: remove unused

b99c20d

suneox reviewed Oct 18, 2025

View reviewed changes

Comment thread src/components/SelectionListWithSections/BaseSelectionListWithSections.tsx

suneox reviewed Oct 18, 2025

View reviewed changes

Comment thread src/pages/workspace/companyCards/assignCard/TransactionStartDateStep.tsx

suneox reviewed Oct 18, 2025

View reviewed changes

Comment thread src/pages/workspace/companyCards/assignCard/TransactionStartDateStep.tsx Outdated

daledah added 3 commits October 21, 2025 00:27

Merge branch 'main' into fix/71537

a7a2dbe

fix: add validation, remove unused page

fcc293f

fix: lint

230a387

Julesssss reviewed Oct 21, 2025

View reviewed changes

This comment was marked as outdated.

Sign in to view

Julesssss reviewed Oct 22, 2025

View reviewed changes

daledah added 2 commits October 27, 2025 09:33

Merge branch 'main' into fix/71537

6fc4e9e

fix bugs

ee2f965

Julesssss reviewed Oct 27, 2025

View reviewed changes

suneox reviewed Oct 28, 2025

View reviewed changes

Comment thread src/pages/workspace/companyCards/assignCard/TransactionStartDateStep.tsx Outdated

daledah added 6 commits October 30, 2025 16:02

resolve conflict

781b21e

fix prettier

354106e

fix lint

4c16a04

resolve comments

84ce0eb

Merge branch 'main' into fix/71537

4fb1f40

fix lint

811e7a7

This comment was marked as outdated.

Sign in to view

suneox reviewed Nov 1, 2025

View reviewed changes

Comment thread src/components/SelectionListWithSections/types.ts Outdated

resolve conflict

9032d39

suneox approved these changes Nov 4, 2025

View reviewed changes

melvin-bot Bot requested a review from Julesssss November 4, 2025 17:45

Julesssss approved these changes Nov 4, 2025

View reviewed changes

Julesssss merged commit 0f3906e into Expensify:main Nov 4, 2025
26 checks passed

OSBotify mentioned this pull request Nov 4, 2025

Deploy Checklist: New Expensify 2025-11-04 #74235

Closed

56 tasks

melvin-bot Bot mentioned this pull request Nov 5, 2025

[Due for payment 2025-11-12] [$250] Update default card transaction start date to "Custom date" with today's date preselected #71537

Closed

16 tasks

hungvu193 reviewed Dec 19, 2025

View reviewed changes

Conversation

daledah commented Oct 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Oct 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented Oct 17, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Julesssss commented Oct 21, 2025

Uh oh!

Julesssss left a comment

Choose a reason for hiding this comment

Uh oh!

suneox commented Oct 22, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Julesssss left a comment

Choose a reason for hiding this comment

Uh oh!

suneox commented Oct 23, 2025

Uh oh!

suneox commented Oct 23, 2025

Uh oh!

daledah commented Oct 27, 2025

Uh oh!

Julesssss left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This comment was marked as outdated.

suneox commented Nov 1, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

suneox commented Nov 1, 2025

Uh oh!

daledah commented Nov 3, 2025

Uh oh!

suneox commented Nov 3, 2025

Uh oh!

github-actions Bot commented Nov 3, 2025

Uh oh!

github-actions Bot commented Nov 3, 2025

Uh oh!

dubielzyk-expensify commented Nov 4, 2025

Uh oh!

Uh oh!

OSBotify commented Nov 4, 2025

Uh oh!

OSBotify commented Nov 4, 2025

Uh oh!

OSBotify commented Nov 5, 2025

Uh oh!

hungvu193 Dec 19, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

daledah commented Oct 17, 2025 •

edited

Loading

codecov Bot commented Oct 17, 2025 •

edited

Loading