Eliran/update card view by elirangoshen · Pull Request #73090 · Expensify/App

elirangoshen · 2025-10-21T11:27:01Z

Explanation of Change

Adding icon and text to card view for unvaldiated card holder user

Fixed Issues

$ #72765
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

Access card view with assigned card of unvalidated card holder user
You should see grey text and icon as in screenshot
Access card view with assigned card of validated card holder user
You shouln't see grey text and icon as in screenshot

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I verified there are no new alerts related to the canBeMissing param for useOnyx
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If new assets were added or existing ones were modified, I verified that:
- The assets are optimized and compressed (for SVG files, run npm run compress-svg)
- The assets load correctly across all supported platforms.
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

codecov · 2025-10-21T11:39:54Z

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
...e/companyCards/WorkspaceCompanyCardDetailsPage.tsx	0.00%	1 Missing ⚠️
...xpensifyCard/WorkspaceExpensifyCardDetailsPage.tsx	0.00%	1 Missing ⚠️

Files with missing lines	Coverage Δ
...e/companyCards/WorkspaceCompanyCardDetailsPage.tsx	`0.00% <0.00%> (ø)`
...xpensifyCard/WorkspaceExpensifyCardDetailsPage.tsx	`0.00% <0.00%> (ø)`

... and 1565 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

melvin-bot · 2025-10-21T13:01:26Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

DylanDylann · 2025-10-22T05:31:16Z

The change looks straighforward. However, we currently cannot assign a card to unvalidated users. @elirangoshen I am not sure how to test this PR.

DylanDylann · 2025-10-22T05:41:51Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

elirangoshen · 2025-10-22T10:06:35Z

#72765

Maybe @madmax330 can assist ? as I see he opened the issue.
Im tagging also @fabioh8010

madmax330 · 2025-10-22T10:47:15Z

THanks @elirangoshen @DylanDylann
We'll try to get the backend deployed today so we can test

fabioh8010

LGTM from the code perspective

elirangoshen · 2025-10-27T09:55:08Z

Hi @madmax330 ,
I wanted to ask if there is any updates about this :)

madmax330 · 2025-10-27T09:58:05Z

Yeah, the backend PR was merged, should be deployed today

madmax330 · 2025-10-28T10:13:51Z

@elirangoshen the backend PR for expensify cards was deployed, so we should be able to test this now with a test expensify card feed

elirangoshen · 2025-10-30T09:04:05Z

@elirangoshen the backend PR for expensify cards was deployed, so we should be able to test this now with a test expensify card feed

Thanks ! Great news :)

DylanDylann · 2025-10-30T09:15:30Z

@elirangoshen Please update to display the pending status on ExpensifyCard too

DylanDylann · 2025-10-30T09:16:17Z

@madmax330 Should we update to allow assigning a company card to unvalidated users?

madmax330 · 2025-10-30T09:23:34Z

Should we update to allow assigning a company card to unvalidated users?

Yes, that PR should be deployed today

madmax330 · 2025-10-30T11:50:27Z

Yes, that PR should be deployed today

This is deployed now, you should be able to test both expensify cards and third party cards

DylanDylann · 2025-10-30T12:20:05Z

@elirangoshen please let me know when you update the pending status on the Expensify Card

melvin-bot · 2025-10-30T13:19:53Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

Look at the code and make sure there are no malicious changes.
Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

elirangoshen · 2025-10-30T14:02:48Z

@elirangoshen please let me know when you update the pending status on the Expensify Card

I updated and now tested and its working, I also fixed lint error related o use of depracated function

@DylanDylann

elirangoshen · 2025-10-30T14:59:51Z

@@ -87,7 +89,7 @@ function WorkspaceExpensifyCardDetailsPage({route}: WorkspaceExpensifyCardDetail
    const deactivateCard = () => {
        setIsDeactivateModalVisible(false);
        shouldGoBack.current = true;
-        InteractionManager.runAfterInteractions(() => {
+        requestAnimationFrame(() => {


due to eslint error of deprecation of InteractionManager

@elirangoshen Is there any guideline confirming that we can use requestAnimationFrame instead of InteractionManager.runAfterInteractions?

I think we can safely add

// eslint-disable-next-line @typescript-eslint/no-deprecated

and we will handle this deprecation in the deprecation epic

@elirangoshen Kindly bump

DylanDylann · 2025-10-30T15:47:33Z

@elirangoshen I think it shouldn't be truncated, we should display it fully

cc @madmax330

madmax330 · 2025-10-30T16:29:28Z

I think it shouldn't be truncated, we should display it fully

Yeah I agree

elirangoshen · 2025-10-31T09:11:36Z

@elirangoshen I think it shouldn't be truncated, we should display it fully

cc @madmax330

Ok I fixed it
Please check again @madmax330

DylanDylann · 2025-11-03T10:01:07Z

@elirangoshen One comment: #73090 (comment)

elirangoshen · 2025-11-03T11:46:39Z

@DylanDylann

thanks for the update,

Done

elirangoshen · 2025-11-04T08:47:36Z

thanks for the approve @DylanDylann ,

@madmax330 what do you think ?

OSBotify · 2025-11-04T09:33:09Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-11-04T21:13:44Z

🚀 Deployed to staging by https://github.com/madmax330 in version: 9.2.44-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-11-05T20:07:09Z

🚀 Deployed to production by https://github.com/luacmartins in version: 9.2.44-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

melvin-bot Bot assigned elirangoshen Oct 21, 2025

elirangoshen marked this pull request as ready for review October 21, 2025 13:01

elirangoshen requested a review from a team as a code owner October 21, 2025 13:01

melvin-bot Bot requested review from DylanDylann and removed request for a team October 21, 2025 13:01

elirangoshen mentioned this pull request Oct 21, 2025

[CLARIFY REGRESSION STEPS][Due for payment 2025-11-12] Update card view to show pending for unvalidated users #72765

Closed

DylanDylann approved these changes Oct 22, 2025

View reviewed changes

melvin-bot Bot requested a review from madmax330 October 22, 2025 05:42

fabioh8010 approved these changes Oct 22, 2025

View reviewed changes

elirangoshen added 3 commits October 30, 2025 14:20

adding card text

8465235

add space between icon and label

cb27af3

add pending to expensify card

8e40a54

elirangoshen force-pushed the eliran/update-card-view branch from ed64643 to 8e40a54 Compare October 30, 2025 13:21

fix es lint error

630966c

elirangoshen commented Oct 30, 2025

View reviewed changes

remove truncterad copy

18f3e34

pr fixes

8413801

DylanDylann approved these changes Nov 3, 2025

View reviewed changes

madmax330 approved these changes Nov 4, 2025

View reviewed changes

madmax330 merged commit 52b7390 into Expensify:main Nov 4, 2025
27 checks passed

OSBotify mentioned this pull request Nov 4, 2025

Deploy Checklist: New Expensify 2025-11-04 #74235

Closed

56 tasks

Conversation

elirangoshen commented Oct 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Oct 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented Oct 21, 2025

Uh oh!

DylanDylann commented Oct 22, 2025

Uh oh!

DylanDylann commented Oct 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

elirangoshen commented Oct 22, 2025

Uh oh!

madmax330 commented Oct 22, 2025

Uh oh!

fabioh8010 left a comment

Choose a reason for hiding this comment

Uh oh!

elirangoshen commented Oct 27, 2025

Uh oh!

madmax330 commented Oct 27, 2025

Uh oh!

madmax330 commented Oct 28, 2025

Uh oh!

elirangoshen commented Oct 30, 2025

Uh oh!

DylanDylann commented Oct 30, 2025

Uh oh!

DylanDylann commented Oct 30, 2025

Uh oh!

madmax330 commented Oct 30, 2025

Uh oh!

madmax330 commented Oct 30, 2025

Uh oh!

DylanDylann commented Oct 30, 2025

Uh oh!

melvin-bot Bot commented Oct 30, 2025

Uh oh!

elirangoshen commented Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

elirangoshen Oct 30, 2025

Choose a reason for hiding this comment

Uh oh!

DylanDylann Oct 30, 2025

Choose a reason for hiding this comment

Uh oh!

DylanDylann Oct 30, 2025

Choose a reason for hiding this comment

Uh oh!

DylanDylann Oct 31, 2025

Choose a reason for hiding this comment

Uh oh!

DylanDylann commented Oct 30, 2025

Uh oh!

madmax330 commented Oct 30, 2025

Uh oh!

elirangoshen commented Oct 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DylanDylann commented Nov 3, 2025

Uh oh!

elirangoshen commented Nov 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

elirangoshen commented Nov 4, 2025

Uh oh!

elirangoshen commented Oct 21, 2025 •

edited

Loading

codecov Bot commented Oct 21, 2025 •

edited

Loading

DylanDylann commented Oct 22, 2025 •

edited

Loading

elirangoshen commented Oct 30, 2025 •

edited

Loading

elirangoshen commented Oct 31, 2025 •

edited

Loading

elirangoshen commented Nov 3, 2025 •

edited

Loading