Skip to content

[HOLD] [NO QA] Automatically check off NO QA Mobile-Expensify PRs from checklist #73148

Open
Julesssss wants to merge 11 commits intomainfrom
jules-improveAppDeployChecklist
Open

[HOLD] [NO QA] Automatically check off NO QA Mobile-Expensify PRs from checklist #73148
Julesssss wants to merge 11 commits intomainfrom
jules-improveAppDeployChecklist

Conversation

@Julesssss
Copy link
Copy Markdown
Contributor

@Julesssss Julesssss commented Oct 21, 2025 •
edited
Loading

Explanation of Change

This PR ensures that Mobile-Expensify PRs get automatically checked off the checklist. Currently this only works for App PRs, see example:

494624378-06f9ad63-db75-42d0-8a2e-319b1dc4382a

You only need to review the ts file, the GH action files are auto-generated.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/551600

Tests

@Julesssss will run this workflow once it hits staging to verify the workflow wasn't broken

Offline tests

N/A

QA Steps

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop

@Julesssss Julesssss self-assigned this Oct 21, 2025
@Julesssss Julesssss requested a review from blimpich October 21, 2025 19:02
@Julesssss Julesssss marked this pull request as ready for review October 21, 2025 19:03
@Julesssss Julesssss requested a review from a team as a code owner October 21, 2025 19:03
@melvin-bot melvin-bot bot requested review from Beamanator and removed request for a team October 21, 2025 19:04
@melvin-bot
Copy link
Copy Markdown

melvin-bot bot commented Oct 21, 2025

@Beamanator Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 21, 2025 •
edited by github-actions bot
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
see 141 files with indirect coverage changes

@Julesssss Julesssss changed the title [NO QA] Automatically check off NO QA Mobile-Expensify PRs from checklist [HOLD] [NO QA] Automatically check off NO QA Mobile-Expensify PRs from checklist Oct 21, 2025
@Julesssss
Copy link
Copy Markdown
Contributor Author

Julesssss commented Oct 21, 2025

There seems to be a bug here, the workflow gets stuck and doesn't locate Mobile-Expensify PRs here.

I'll let you know when the PR is ready for review

@Julesssss
Merge branch 'main' into jules-improveAppDeployChecklist
f17e5c9 
* main: (6483 commits)
  Update Mobile-Expensify submodule to 794fd88
  Update Mobile-Expensify submodule version to 9.2.67-10
  Update version to 9.2.67-10
  Update Mobile-Expensify submodule version to 9.2.67-9
  Update version to 9.2.67-9
  Update Mobile-Expensify submodule version to 9.2.67-8
  Update version to 9.2.67-8
  fix prettier
  reverted deprecated getReportName
  reverted deprecated getReportName
  Add lastSearchParams?.queryJSON in deps
  fix lint
  Update Mobile-Expensify submodule version to 9.2.67-7
  Update version to 9.2.67-7
  fix lint
  update transaction count
  fix: move getReportName import to ReportNameUtils
  Update Mobile-Expensify submodule version to 9.2.67-6
  Update version to 9.2.67-6
  Update Mobile-Expensify submodule version to 9.2.67-5
  ...

# Conflicts:
#	.github/actions/javascript/authorChecklist/index.js
#	.github/actions/javascript/awaitStagingDeploys/index.js
#	.github/actions/javascript/checkAndroidStatus/index.js
#	.github/actions/javascript/checkDeployBlockers/index.js
#	.github/actions/javascript/checkSVGCompression/index.js
#	.github/actions/javascript/createOrUpdateStagingDeploy/index.js
#	.github/actions/javascript/getArtifactInfo/index.js
#	.github/actions/javascript/getDeployPullRequestList/index.js
#	.github/actions/javascript/getPreviousVersion/index.js
#	.github/actions/javascript/getPullRequestDetails/index.js
#	.github/actions/javascript/getPullRequestIncrementalChanges/index.js
#	.github/actions/javascript/isStagingDeployLocked/index.js
#	.github/actions/javascript/markPullRequestsAsDeployed/index.js
#	.github/actions/javascript/postTestBuildComment/index.js
#	.github/actions/javascript/proposalPoliceComment/index.js
#	.github/actions/javascript/reopenIssueWithComment/index.js
#	.github/actions/javascript/reviewerChecklist/index.js
#	.github/actions/javascript/verifySignedCommits/index.js
#	.github/libs/GithubUtils.ts
@blimpich blimpich removed their request for review January 19, 2026 20:27
@Beamanator
Copy link
Copy Markdown
Contributor

Beamanator commented Feb 13, 2026

@Julesssss any progress with this? Or is it working fine now?

@Julesssss
Copy link
Copy Markdown
Contributor Author

Julesssss commented Feb 13, 2026

Nah this is stale. Don't have time to finish it currently 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Beamanator Beamanator Awaiting requested review from Beamanator

At least 1 approving review is required to merge this pull request.

Assignees

@Julesssss Julesssss

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Julesssss @Beamanator